From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754690AbdDDVnv (ORCPT ); Tue, 4 Apr 2017 17:43:51 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:51560 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754217AbdDDVnu (ORCPT ); Tue, 4 Apr 2017 17:43:50 -0400 Date: Tue, 4 Apr 2017 16:43:39 -0500 From: Reza Arbab To: Michal Hocko Cc: Mel Gorman , linux-mm@kvack.org, Andrew Morton , Vlastimil Babka , Andrea Arcangeli , Yasuaki Ishimatsu , Tang Chen , qiuxishi@huawei.com, Kani Toshimitsu , slaoub@gmail.com, Joonsoo Kim , Andi Kleen , Zhang Zhen , David Rientjes , Daniel Kiper , Igor Mammedov , Vitaly Kuznetsov , LKML , Chris Metcalf , Dan Williams , Heiko Carstens , Lai Jiangshan , Martin Schwidefsky Subject: Re: [PATCH 0/6] mm: make movable onlining suck less References: <20170403195830.64libncet5l6vuvb@arbab-laptop> <20170403202337.GA12482@dhcp22.suse.cz> <20170403204213.rs7k2cvsnconel2z@arbab-laptop> <20170404072329.GA15132@dhcp22.suse.cz> <20170404073412.GC15132@dhcp22.suse.cz> <20170404082302.GE15132@dhcp22.suse.cz> <20170404160239.ftvuxklioo6zvuxl@arbab-laptop> <20170404164452.GQ15132@dhcp22.suse.cz> <20170404183012.a6biape5y7vu6cjm@arbab-laptop> <20170404194122.GS15132@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20170404194122.GS15132@dhcp22.suse.cz> Organization: IBM Linux Technology Center User-Agent: NeoMutt/20170306 (1.8.0) X-TM-AS-GCONF: 00 x-cbid: 17040421-0020-0000-0000-00000BB2EF4A X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006883; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000208; SDB=6.00843132; UDB=6.00415389; IPR=6.00621307; BA=6.00005266; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00014912; XFM=3.00000013; UTC=2017-04-04 21:43:48 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17040421-0021-0000-0000-00005B67A593 Message-Id: <20170404214339.6o4c4uhwudyhzbbo@arbab-laptop> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-04_19:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1704040184 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 04, 2017 at 09:41:22PM +0200, Michal Hocko wrote: >On Tue 04-04-17 13:30:13, Reza Arbab wrote: >> I think I found another edge case. You >> get an oops when removing all of a node's memory: >> >> __nr_to_section >> __pfn_to_section >> find_biggest_section_pfn >> shrink_pgdat_span >> __remove_zone >> __remove_section >> __remove_pages >> arch_remove_memory >> remove_memory > >Is this something new or an old issue? I believe the state after the >online should be the same as before. So if you onlined the full node >then there shouldn't be any difference. Let me have a look... It's new. Without this patchset, I can repeatedly add_memory()->online_movable->offline->remove_memory() all of a node's memory. >>From 1b08ecef3e8ebcef585fe8f2b23155be54cce335 Mon Sep 17 00:00:00 2001 >From: Michal Hocko >Date: Tue, 4 Apr 2017 21:09:00 +0200 >Subject: [PATCH] mm, hotplug: get rid of zone/node shrinking > ...%<... >--- > mm/memory_hotplug.c | 207 ---------------------------------------------------- > 1 file changed, 207 deletions(-) Okay, getting further. With this I can again repeatedly add and remove, but now I'm seeing a weird variation of that earlier issue: 1. add_memory(), online_movable /sys/devices/system/node/nodeX/memoryY symlinks are created. 2. offline, remove_memory() The node is offlined, since all memory has been removed, so all of /sys/devices/system/node/nodeX is gone. This is normal. 3. add_memory(), online_movable The node is onlined, so /sys/devices/system/node/nodeX is recreated, and the memory is added, but just like earlier in this email thread, the memoryY links are not there. -- Reza Arbab From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f72.google.com (mail-pg0-f72.google.com [74.125.83.72]) by kanga.kvack.org (Postfix) with ESMTP id 07E606B0390 for ; Tue, 4 Apr 2017 17:43:51 -0400 (EDT) Received: by mail-pg0-f72.google.com with SMTP id n5so187966963pgd.19 for ; Tue, 04 Apr 2017 14:43:51 -0700 (PDT) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com. [148.163.156.1]) by mx.google.com with ESMTPS id l14si18644164plk.57.2017.04.04.14.43.49 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Apr 2017 14:43:50 -0700 (PDT) Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v34Lcjvt091243 for ; Tue, 4 Apr 2017 17:43:49 -0400 Received: from e36.co.us.ibm.com (e36.co.us.ibm.com [32.97.110.154]) by mx0a-001b2d01.pphosted.com with ESMTP id 29kuruk97k-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 04 Apr 2017 17:43:49 -0400 Received: from localhost by e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 4 Apr 2017 15:43:48 -0600 Date: Tue, 4 Apr 2017 16:43:39 -0500 From: Reza Arbab Subject: Re: [PATCH 0/6] mm: make movable onlining suck less References: <20170403195830.64libncet5l6vuvb@arbab-laptop> <20170403202337.GA12482@dhcp22.suse.cz> <20170403204213.rs7k2cvsnconel2z@arbab-laptop> <20170404072329.GA15132@dhcp22.suse.cz> <20170404073412.GC15132@dhcp22.suse.cz> <20170404082302.GE15132@dhcp22.suse.cz> <20170404160239.ftvuxklioo6zvuxl@arbab-laptop> <20170404164452.GQ15132@dhcp22.suse.cz> <20170404183012.a6biape5y7vu6cjm@arbab-laptop> <20170404194122.GS15132@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20170404194122.GS15132@dhcp22.suse.cz> Message-Id: <20170404214339.6o4c4uhwudyhzbbo@arbab-laptop> Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: Mel Gorman , linux-mm@kvack.org, Andrew Morton , Vlastimil Babka , Andrea Arcangeli , Yasuaki Ishimatsu , Tang Chen , qiuxishi@huawei.com, Kani Toshimitsu , slaoub@gmail.com, Joonsoo Kim , Andi Kleen , Zhang Zhen , David Rientjes , Daniel Kiper , Igor Mammedov , Vitaly Kuznetsov , LKML , Chris Metcalf , Dan Williams , Heiko Carstens , Lai Jiangshan , Martin Schwidefsky On Tue, Apr 04, 2017 at 09:41:22PM +0200, Michal Hocko wrote: >On Tue 04-04-17 13:30:13, Reza Arbab wrote: >> I think I found another edge case. You >> get an oops when removing all of a node's memory: >> >> __nr_to_section >> __pfn_to_section >> find_biggest_section_pfn >> shrink_pgdat_span >> __remove_zone >> __remove_section >> __remove_pages >> arch_remove_memory >> remove_memory > >Is this something new or an old issue? I believe the state after the >online should be the same as before. So if you onlined the full node >then there shouldn't be any difference. Let me have a look... It's new. Without this patchset, I can repeatedly add_memory()->online_movable->offline->remove_memory() all of a node's memory. >>From 1b08ecef3e8ebcef585fe8f2b23155be54cce335 Mon Sep 17 00:00:00 2001 >From: Michal Hocko >Date: Tue, 4 Apr 2017 21:09:00 +0200 >Subject: [PATCH] mm, hotplug: get rid of zone/node shrinking > ...%<... >--- > mm/memory_hotplug.c | 207 ---------------------------------------------------- > 1 file changed, 207 deletions(-) Okay, getting further. With this I can again repeatedly add and remove, but now I'm seeing a weird variation of that earlier issue: 1. add_memory(), online_movable /sys/devices/system/node/nodeX/memoryY symlinks are created. 2. offline, remove_memory() The node is offlined, since all memory has been removed, so all of /sys/devices/system/node/nodeX is gone. This is normal. 3. add_memory(), online_movable The node is onlined, so /sys/devices/system/node/nodeX is recreated, and the memory is added, but just like earlier in this email thread, the memoryY links are not there. -- Reza Arbab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org