All of
 help / color / mirror / Atom feed
From: Thomas Petazzoni <>
Subject: [Buildroot] [PATCH v3] board: Add support for Engicam i.CoreM6 Quad/Dual boards
Date: Tue, 4 Apr 2017 22:17:50 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>


On Tue,  4 Apr 2017 23:40:12 +0530, Jagan Teki wrote:
> From: Jagan Teki <>
> Add initial support for Engicam i.CoreM6 Quad/Dual board
> with below features:
> - U-Boot 2017.01
> - Linux 4.10
> - Default packages from buildroot
> Cc: Thomas Petazzoni <>
> Cc: Matteo Lisi <>
> Cc: Michael Trimarchi <>
> Signed-off-by: Jagan Teki <>

Thanks, looking better.

> diff --git a/board/engicam/common/ b/board/engicam/common/

Why do we have this 'common' folder, and this very flexible script? Do
you intend to submit the support for other boards?

This script is exactly the same as the one in
board/freescale/common/imx/, I definitely would like to
avoid duplication.

For now, if you're trying to submit the support for a single board, I
would suggest that you:

 1. Use a "fixed" genimage.cfg, i.e without %FILES% or %DTBS%

 2. Use support/scripts/

> +# Kernel

Since you're using a 4.10 kernel, you also need to set:


Best regards,

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering

  reply	other threads:[~2017-04-04 20:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-04 18:10 [Buildroot] [PATCH v3] board: Add support for Engicam i.CoreM6 Quad/Dual boards Jagan Teki
2017-04-04 20:17 ` Thomas Petazzoni [this message]
2017-04-05 15:56   ` Jagan Teki
2017-04-05 16:19     ` Thomas Petazzoni
2017-04-05 16:54       ` Jagan Teki
2017-04-05 16:32     ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.