From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752730AbdDEF25 (ORCPT ); Wed, 5 Apr 2017 01:28:57 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35676 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751298AbdDEF24 (ORCPT ); Wed, 5 Apr 2017 01:28:56 -0400 From: Ralph Sennhauser To: linux-arm-kernel@lists.infradead.org Cc: Ralph Sennhauser , Jason Cooper , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Mark Rutland , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/1] ARM: dts: armada-xp-linksys-mamba: use wan instead of internet for DSA port Date: Wed, 5 Apr 2017 07:28:46 +0200 Message-Id: <20170405052847.326-1-ralph.sennhauser@gmail.com> X-Mailer: git-send-email 2.10.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The LEDs for the "wan" port are already labeled "mamba:amber:wan" resp. "mamba:white:wan". So besides being an outlier with regard to the rest of the product line (see table below) changing the label fixes an internal inconsistency as well. This will be visible in user space. Given commit cb4f71c42988 ("ARM: dts: armada-38x: change order of ethernet DT nodes on Armada 38x") it's expected to happen anyway. Commit 499400c9ac20 ("ARM: dts: armada-xp-linksys-mamba: Utilize new DSA binding") switches to the new bindings, use this opportunity to do it now rather than later. |-----------------------------------------------------------------| | Labels used for the case and those used for the DSA ports | |-----------------------------------------------------------------| | case labels | armada-385-linksys-* | armada-xp-linksys-mamba | |---------------|-----------------------|-------------------------| | internet | wan | internet | | 1 | lan1 | lan1 | | 2 | lan2 | lan2 | | 3 | lan3 | lan3 | | 4 | lan4 | lan4 | |-----------------------------------------------------------------| Signed-off-by: Ralph Sennhauser --- Hi everybody, I underestimated the urge of people to make all the same before. While I do not particularly like this sort of change I see it coming anyway. So this patch is meant to make it a deliberate decision so it no longer is an item lurking in the shadows. Whether this patch gets taken or rejected my goal is reached. In hindsight wan would have been the better choice. Ralph arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts index 9efcf59..0143aed 100644 --- a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts +++ b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts @@ -354,7 +354,7 @@ port@4 { reg = <4>; - label = "internet"; + label = "wan"; }; port@5 { @@ -452,7 +452,7 @@ port@4 { reg = <4>; - label = "internet"; + label = "wan"; }; port@5 { -- 2.10.2 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ralph Sennhauser Subject: [PATCH 1/1] ARM: dts: armada-xp-linksys-mamba: use wan instead of internet for DSA port Date: Wed, 5 Apr 2017 07:28:46 +0200 Message-ID: <20170405052847.326-1-ralph.sennhauser@gmail.com> Return-path: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: Ralph Sennhauser , Jason Cooper , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Mark Rutland , Russell King , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org The LEDs for the "wan" port are already labeled "mamba:amber:wan" resp. "mamba:white:wan". So besides being an outlier with regard to the rest of the product line (see table below) changing the label fixes an internal inconsistency as well. This will be visible in user space. Given commit cb4f71c42988 ("ARM: dts: armada-38x: change order of ethernet DT nodes on Armada 38x") it's expected to happen anyway. Commit 499400c9ac20 ("ARM: dts: armada-xp-linksys-mamba: Utilize new DSA binding") switches to the new bindings, use this opportunity to do it now rather than later. |-----------------------------------------------------------------| | Labels used for the case and those used for the DSA ports | |-----------------------------------------------------------------| | case labels | armada-385-linksys-* | armada-xp-linksys-mamba | |---------------|-----------------------|-------------------------| | internet | wan | internet | | 1 | lan1 | lan1 | | 2 | lan2 | lan2 | | 3 | lan3 | lan3 | | 4 | lan4 | lan4 | |-----------------------------------------------------------------| Signed-off-by: Ralph Sennhauser --- Hi everybody, I underestimated the urge of people to make all the same before. While I do not particularly like this sort of change I see it coming anyway. So this patch is meant to make it a deliberate decision so it no longer is an item lurking in the shadows. Whether this patch gets taken or rejected my goal is reached. In hindsight wan would have been the better choice. Ralph arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts index 9efcf59..0143aed 100644 --- a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts +++ b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts @@ -354,7 +354,7 @@ port@4 { reg = <4>; - label = "internet"; + label = "wan"; }; port@5 { @@ -452,7 +452,7 @@ port@4 { reg = <4>; - label = "internet"; + label = "wan"; }; port@5 { -- 2.10.2 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: ralph.sennhauser@gmail.com (Ralph Sennhauser) Date: Wed, 5 Apr 2017 07:28:46 +0200 Subject: [PATCH 1/1] ARM: dts: armada-xp-linksys-mamba: use wan instead of internet for DSA port Message-ID: <20170405052847.326-1-ralph.sennhauser@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org The LEDs for the "wan" port are already labeled "mamba:amber:wan" resp. "mamba:white:wan". So besides being an outlier with regard to the rest of the product line (see table below) changing the label fixes an internal inconsistency as well. This will be visible in user space. Given commit cb4f71c42988 ("ARM: dts: armada-38x: change order of ethernet DT nodes on Armada 38x") it's expected to happen anyway. Commit 499400c9ac20 ("ARM: dts: armada-xp-linksys-mamba: Utilize new DSA binding") switches to the new bindings, use this opportunity to do it now rather than later. |-----------------------------------------------------------------| | Labels used for the case and those used for the DSA ports | |-----------------------------------------------------------------| | case labels | armada-385-linksys-* | armada-xp-linksys-mamba | |---------------|-----------------------|-------------------------| | internet | wan | internet | | 1 | lan1 | lan1 | | 2 | lan2 | lan2 | | 3 | lan3 | lan3 | | 4 | lan4 | lan4 | |-----------------------------------------------------------------| Signed-off-by: Ralph Sennhauser --- Hi everybody, I underestimated the urge of people to make all the same before. While I do not particularly like this sort of change I see it coming anyway. So this patch is meant to make it a deliberate decision so it no longer is an item lurking in the shadows. Whether this patch gets taken or rejected my goal is reached. In hindsight wan would have been the better choice. Ralph arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts index 9efcf59..0143aed 100644 --- a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts +++ b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts @@ -354,7 +354,7 @@ port at 4 { reg = <4>; - label = "internet"; + label = "wan"; }; port at 5 { @@ -452,7 +452,7 @@ port at 4 { reg = <4>; - label = "internet"; + label = "wan"; }; port at 5 { -- 2.10.2