From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 5 Apr 2017 08:20:20 +0200 From: Christoph Hellwig To: Bart Van Assche Cc: Christoph Hellwig , Jens Axboe , "linux-block@vger.kernel.org" , "Martin K . Petersen" , James Bottomley , Hannes Reinecke Subject: Re: [PATCH v2 4/5] scsi: Add scsi_restart_hctx() Message-ID: <20170405062020.GA26389@lst.de> References: <20170403232228.11208-1-bart.vanassche@sandisk.com> <20170403232228.11208-5-bart.vanassche@sandisk.com> <20170404064252.GD9168@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: List-ID: On Tue, Apr 04, 2017 at 03:56:34PM +0000, Bart Van Assche wrote: > > This looks like generic block layer code, why is it in SCSI? > > Hello Christoph, > > That's an excellent question. I assume that you are fine with moving > this code to the block layer? Yes. In fact I wonder if we need the blk_mq_ops method at all now that you're using RCU locking and don't need the scsi host_lock.