From: Karel Zak <kzak@redhat.com>
To: J William Piggott <elseifthen@gmx.com>
Cc: kerolasa@gmail.com, util-linux <util-linux@vger.kernel.org>
Subject: Re: [PATCH 3/3] agetty: make --remote to forward --nohostname as -H to login
Date: Wed, 5 Apr 2017 10:51:51 +0200 [thread overview]
Message-ID: <20170405085151.beeuqeovoqrkumjx@ws.net.home> (raw)
In-Reply-To: <35c0fb17-6b6e-35df-fe2f-18dd14f3987c@gmx.com>
On Tue, Apr 04, 2017 at 09:03:08PM -0400, J William Piggott wrote:
>
> I don't understand this:
>
> 8< ---
>
> -o, --login-options "/path/command --option argument -- \u"
> Options that are passed to the login program. \u is replaced
> by the login name. The default is "/bin/login -- \u".
> 8< ---
>
> Is this saying the argument must include the login command? Is that what
> "/path/command" represents? If yes, then the second line is incorrect.
> If no, then the last sentence is incorrect.
from code:
login_argv[login_argc++] = options.login;
...
login_options_to_argv(login_argv, &login_argc,
options.logopt, username);
...
execv(options.login, login_argv);
where:
options.login is --login-program
login-options is --login-options
so the man page is wrong, --login-options should be without the path.
I'll fix it.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2017-04-05 8:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-02 8:14 [PATCH 1/3] agetty: remove variable that is set but not read Sami Kerola
2017-04-02 8:14 ` [PATCH 2/3] lib/cpuset: stop changing variable that is " Sami Kerola
2017-04-02 8:14 ` [PATCH 3/3] agetty: make --remote to forward --nohostname as -H to login Sami Kerola
2017-04-03 1:13 ` J William Piggott
2017-04-03 8:40 ` Sami Kerola
2017-04-03 21:20 ` Sami Kerola
2017-04-05 1:03 ` J William Piggott
2017-04-05 8:51 ` Karel Zak [this message]
2017-04-05 15:24 ` J William Piggott
2017-04-05 23:33 ` J William Piggott
2017-04-06 8:41 ` Karel Zak
2017-04-06 14:21 ` [PATCH] agetty: various man-page fixes J William Piggott
2017-04-10 13:47 ` Karel Zak
2017-04-03 8:56 ` [PATCH 3/3] agetty: make --remote to forward --nohostname as -H to login Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170405085151.beeuqeovoqrkumjx@ws.net.home \
--to=kzak@redhat.com \
--cc=elseifthen@gmx.com \
--cc=kerolasa@gmail.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.