From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34806) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cvgjR-0003wY-AV for qemu-devel@nongnu.org; Wed, 05 Apr 2017 04:56:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cvgjO-00067a-4Y for qemu-devel@nongnu.org; Wed, 05 Apr 2017 04:56:01 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:56696 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cvgjN-00065S-UB for qemu-devel@nongnu.org; Wed, 05 Apr 2017 04:55:58 -0400 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v358raUg026776 for ; Wed, 5 Apr 2017 04:55:56 -0400 Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109]) by mx0b-001b2d01.pphosted.com with ESMTP id 29mtpqpxty-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 05 Apr 2017 04:55:55 -0400 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 5 Apr 2017 09:55:53 +0100 Date: Wed, 5 Apr 2017 10:55:47 +0200 From: Cornelia Huck In-Reply-To: <20170404202429.14643-22-ehabkost@redhat.com> References: <20170404202429.14643-1-ehabkost@redhat.com> <20170404202429.14643-22-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: <20170405105547.00b5ed92.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH v2 21/21] s390-pcibus: No need to set user_creatable=false explicitly List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, Peter Maydell , Thomas Huth , Frank Blaschka , Pierre Morel , Alexander Graf , Markus Armbruster , Christian Borntraeger , Yi Min Zhao , Marcel Apfelbaum , Laszlo Ersek , Richard Henderson On Tue, 4 Apr 2017 17:24:29 -0300 Eduardo Habkost wrote: > TYPE_S390_PCI_HOST_BRIDGE is a subclass of TYPE_PCI_HOST_BRIDGE, > which is a subclass of TYPE_SYS_BUS_DEVICE. TYPE_SYS_BUS_DEVICE > already sets user_creatable=false, so we don't require an > explicit user_creatable=false assignment in > s390_pcihost_class_init(). > > Cc: Alexander Graf > Cc: Christian Borntraeger > Cc: Cornelia Huck > Cc: Frank Blaschka > Cc: Laszlo Ersek > Cc: Marcel Apfelbaum > Cc: Markus Armbruster > Cc: Peter Maydell > Cc: Pierre Morel > Cc: Richard Henderson > Cc: Thomas Huth > Cc: Yi Min Zhao > Signed-off-by: Eduardo Habkost > --- > Changes series v1 -> v2: > * Previous patch was: > "s390: Add FIXME for unexplained user_creatable=false line", > but now we know we can remove the explicit user_creatable=false > assignment > --- > hw/s390x/s390-pci-bus.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c > index 1ec30c45ce..973893df07 100644 > --- a/hw/s390x/s390-pci-bus.c > +++ b/hw/s390x/s390-pci-bus.c > @@ -867,7 +867,6 @@ static void s390_pcihost_class_init(ObjectClass *klass, void *data) > DeviceClass *dc = DEVICE_CLASS(klass); > HotplugHandlerClass *hc = HOTPLUG_HANDLER_CLASS(klass); > > - dc->user_creatable = false; > dc->reset = s390_pcihost_reset; > k->init = s390_pcihost_init; > hc->plug = s390_pcihost_hot_plug; Acked-by: Cornelia Huck