From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933759AbdDELPF (ORCPT ); Wed, 5 Apr 2017 07:15:05 -0400 Received: from smtp2.provo.novell.com ([137.65.250.81]:43928 "EHLO smtp2.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755033AbdDELOe (ORCPT ); Wed, 5 Apr 2017 07:14:34 -0400 Date: Wed, 5 Apr 2017 13:13:00 +0200 From: Petr Tesarik To: Daniel Kiper Cc: , , , , , , , Subject: Re: [Xen-devel] [PATCH v2] xen, kdump: handle pv domain in paddr_vmcoreinfo_note() Message-ID: <20170405131300.6a92fd6a@hananiah.suse.cz> In-Reply-To: <0106a5b2-7c66-41bd-9a43-42974242b3af@default> References: <0106a5b2-7c66-41bd-9a43-42974242b3af@default> Organization: SUSE Linux X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.31; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 4 Apr 2017 12:42:53 -0700 (PDT) Daniel Kiper wrote: > > On 03/04/17 14:42, Daniel Kiper wrote: > > > On Fri, Mar 31, 2017 at 12:14:38PM +0200, Juergen Gross wrote: > > >> For kdump to work correctly it needs the physical address of > > >> vmcoreinfo_note. When running as dom0 this means the virtual address > > >> has to be translated to the related machine address. > > >> > > >> paddr_vmcoreinfo_note() is meant to do the translation via > > >> __pa_symbol() only, but being attributed "weak" it can be replaced > > >> easily in Xen case. > > >> > > >> Signed-off-by: Juergen Gross > > > > > > Have you tested this patch with latest crash tool? Do dom0 and Xen > > > hypervisor analysis work without any issue (at least basic commands > > > like dmesg, bt, ps, etc.)? If yes for both you can add: > > > > > > Reviewed-by: Daniel Kiper > > > > This patch isn't for dump analysis, but for dump creation. Petr has > > I know that. However, it may have impact on crash analysis. So, > I would expect that you or anybody else in your behalf will do > at least minimal crash tool tests. > > > verified that the dump is in the expected format. Please ask Petr > > for further details, e.g. user side modifications being necessary. > > So, if Petr did relevant tests that is nice. However, then, IMO, this > patch begs Petr Tested-by. Actually, I tested with this patch applied on top of kernel 4.4 (SLES 12 SP2). It matches what traditional Xen had always done, so I am quite confident it will work with a later kernel, but to give my Tested-by, let me first re-run the test on master, hopefully until today EOB. HTH, Petr T