From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Wed, 5 Apr 2017 09:42:59 -0400 Subject: [U-Boot] [PATCH] common, kconfig: Fix defaut value of BOOTSTAGE_STASH_SIZE In-Reply-To: <20170402092242.11BE11201A5@gemini.denx.de> References: <20170401224812.11646-1-iwamatsu@nigauri.org> <20170402092242.11BE11201A5@gemini.denx.de> Message-ID: <20170405134259.GA19897@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sun, Apr 02, 2017 at 11:22:42AM +0200, Wolfgang Denk wrote: > Dear Nobuhiro, > > In message <20170401224812.11646-1-iwamatsu@nigauri.org> you wrote: > > The default value of BOOTSTAGE_STASH_SIZE should be set to hexadecimal, > > but an integer value is set. This fixes the BOOTSTAGE_STASH_SIZE number > > from hexadecimal to integer. > ... > > - default 4096 > > + default 0x1000 > > help > > This should be large enough to hold the bootstage stash. A value of > > 4096 (4KiB) is normally plenty. > > Would it make sense to also fix the help message, and maybe even to > add a note to the help message that this should be a hex number? Yes, perhaps s/4096/0x1000/ in the help message will be clear enough since Kconfig tooling will take care of saying "THIS IS HEX!" somwwhere relevant. Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: