From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Ladi Prosek <lprosek@redhat.com>
Cc: kvm@vger.kernel.org, kai.huang@linux.intel.com, wanpeng.li@hotmail.com
Subject: Re: [PATCH] KVM: nVMX: initialize PML fields in vmcs02
Date: Wed, 5 Apr 2017 16:49:39 +0200 [thread overview]
Message-ID: <20170405144939.GB13944@potion> (raw)
In-Reply-To: <20170404121853.28057-1-lprosek@redhat.com>
2017-04-04 14:18+0200, Ladi Prosek:
> L2 was running with uninitialized PML fields which led to incomplete
> dirty bitmap logging. This manifested as all kinds of subtle erratic
> behavior of the nested guest.
>
> Fixes: 843e4330573c ("KVM: VMX: Add PML support in VMX")
> Signed-off-by: Ladi Prosek <lprosek@redhat.com>
> ---
Applied to kvm/master, thanks.
(I should get a newer test machine ...)
> arch/x86/kvm/vmx.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 2ee00db..f47d701 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -10267,6 +10267,18 @@ static int prepare_vmcs02(struct kvm_vcpu *vcpu, struct vmcs12 *vmcs12,
>
> }
>
> + if (enable_pml) {
> + /*
> + * Conceptually we want to copy the PML address and index from
> + * vmcs01 here, and then back to vmcs01 on nested vmexit. But,
> + * since we always flush the log on each vmexit, this happens
> + * to be equivalent to simply resetting the fields in vmcs02.
> + */
> + ASSERT(vmx->pml_pg);
> + vmcs_write64(PML_ADDRESS, page_to_phys(vmx->pml_pg));
> + vmcs_write16(GUEST_PML_INDEX, PML_ENTITY_NUM - 1);
> + }
> +
> if (nested_cpu_has_ept(vmcs12)) {
> kvm_mmu_unload(vcpu);
> nested_ept_init_mmu_context(vcpu);
> --
> 2.9.3
>
prev parent reply other threads:[~2017-04-05 14:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 12:18 [PATCH] KVM: nVMX: initialize PML fields in vmcs02 Ladi Prosek
2017-04-04 12:44 ` David Hildenbrand
2017-04-04 12:55 ` Ladi Prosek
2017-04-04 13:09 ` David Hildenbrand
2017-04-04 13:19 ` Ladi Prosek
2017-04-04 13:34 ` David Hildenbrand
2017-04-04 13:25 ` David Hildenbrand
2017-04-04 13:37 ` Ladi Prosek
2017-04-04 13:55 ` Paolo Bonzini
2017-04-04 14:22 ` David Hildenbrand
2017-04-05 14:49 ` Radim Krčmář [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170405144939.GB13944@potion \
--to=rkrcmar@redhat.com \
--cc=kai.huang@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=lprosek@redhat.com \
--cc=wanpeng.li@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.