From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933007AbdDEPtq (ORCPT ); Wed, 5 Apr 2017 11:49:46 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:35717 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755336AbdDEPtD (ORCPT ); Wed, 5 Apr 2017 11:49:03 -0400 Date: Wed, 5 Apr 2017 10:48:52 -0500 From: Reza Arbab To: Michal Hocko Cc: Mel Gorman , linux-mm@kvack.org, Andrew Morton , Vlastimil Babka , Andrea Arcangeli , Yasuaki Ishimatsu , Tang Chen , qiuxishi@huawei.com, Kani Toshimitsu , slaoub@gmail.com, Joonsoo Kim , Andi Kleen , Zhang Zhen , David Rientjes , Daniel Kiper , Igor Mammedov , Vitaly Kuznetsov , LKML , Chris Metcalf , Dan Williams , Heiko Carstens , Lai Jiangshan , Martin Schwidefsky Subject: Re: [PATCH 0/6] mm: make movable onlining suck less References: <20170403204213.rs7k2cvsnconel2z@arbab-laptop> <20170404072329.GA15132@dhcp22.suse.cz> <20170404073412.GC15132@dhcp22.suse.cz> <20170404082302.GE15132@dhcp22.suse.cz> <20170404160239.ftvuxklioo6zvuxl@arbab-laptop> <20170404164452.GQ15132@dhcp22.suse.cz> <20170404183012.a6biape5y7vu6cjm@arbab-laptop> <20170404194122.GS15132@dhcp22.suse.cz> <20170404214339.6o4c4uhwudyhzbbo@arbab-laptop> <20170405064239.GB6035@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20170405064239.GB6035@dhcp22.suse.cz> Organization: IBM Linux Technology Center User-Agent: NeoMutt/20170306 (1.8.0) X-TM-AS-GCONF: 00 x-cbid: 17040515-0056-0000-0000-0000032EC6A7 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006886; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000208; SDB=6.00843491; UDB=6.00415606; IPR=6.00621669; BA=6.00005271; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00014923; XFM=3.00000013; UTC=2017-04-05 15:49:01 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17040515-0057-0000-0000-00000764C898 Message-Id: <20170405154852.kdkwuudjv2jwvj5g@arbab-laptop> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-05_12:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1704050136 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 05, 2017 at 08:42:39AM +0200, Michal Hocko wrote: >On Tue 04-04-17 16:43:39, Reza Arbab wrote: >> Okay, getting further. With this I can again repeatedly add and >> remove, but now I'm seeing a weird variation of that earlier issue: >> >> 1. add_memory(), online_movable >> /sys/devices/system/node/nodeX/memoryY symlinks are created. >> >> 2. offline, remove_memory() >> The node is offlined, since all memory has been removed, so all of >> /sys/devices/system/node/nodeX is gone. This is normal. >> >> 3. add_memory(), online_movable >> The node is onlined, so /sys/devices/system/node/nodeX is recreated, >> and the memory is added, but just like earlier in this email thread, >> the memoryY links are not there. > >Could you add some printks to see why the sysfs creation failed please? Ah, simple enough. It's this, right at the top of register_mem_sect_under_node(): if (!node_online(nid)) return 0; That being the case, I really don't understand why your patches make any difference. Is node_set_online() being called later than before somehow? -- Reza Arbab From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f70.google.com (mail-pg0-f70.google.com [74.125.83.70]) by kanga.kvack.org (Postfix) with ESMTP id 43BA26B039F for ; Wed, 5 Apr 2017 11:49:10 -0400 (EDT) Received: by mail-pg0-f70.google.com with SMTP id r129so8775140pgr.18 for ; Wed, 05 Apr 2017 08:49:10 -0700 (PDT) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com. [148.163.156.1]) by mx.google.com with ESMTPS id j64si20920699pge.346.2017.04.05.08.49.09 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Apr 2017 08:49:09 -0700 (PDT) Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v35Fn7ss089295 for ; Wed, 5 Apr 2017 11:49:09 -0400 Received: from e19.ny.us.ibm.com (e19.ny.us.ibm.com [129.33.205.209]) by mx0a-001b2d01.pphosted.com with ESMTP id 29mspyph7t-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 05 Apr 2017 11:49:08 -0400 Received: from localhost by e19.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 5 Apr 2017 11:49:01 -0400 Date: Wed, 5 Apr 2017 10:48:52 -0500 From: Reza Arbab Subject: Re: [PATCH 0/6] mm: make movable onlining suck less References: <20170403204213.rs7k2cvsnconel2z@arbab-laptop> <20170404072329.GA15132@dhcp22.suse.cz> <20170404073412.GC15132@dhcp22.suse.cz> <20170404082302.GE15132@dhcp22.suse.cz> <20170404160239.ftvuxklioo6zvuxl@arbab-laptop> <20170404164452.GQ15132@dhcp22.suse.cz> <20170404183012.a6biape5y7vu6cjm@arbab-laptop> <20170404194122.GS15132@dhcp22.suse.cz> <20170404214339.6o4c4uhwudyhzbbo@arbab-laptop> <20170405064239.GB6035@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20170405064239.GB6035@dhcp22.suse.cz> Message-Id: <20170405154852.kdkwuudjv2jwvj5g@arbab-laptop> Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: Mel Gorman , linux-mm@kvack.org, Andrew Morton , Vlastimil Babka , Andrea Arcangeli , Yasuaki Ishimatsu , Tang Chen , qiuxishi@huawei.com, Kani Toshimitsu , slaoub@gmail.com, Joonsoo Kim , Andi Kleen , Zhang Zhen , David Rientjes , Daniel Kiper , Igor Mammedov , Vitaly Kuznetsov , LKML , Chris Metcalf , Dan Williams , Heiko Carstens , Lai Jiangshan , Martin Schwidefsky On Wed, Apr 05, 2017 at 08:42:39AM +0200, Michal Hocko wrote: >On Tue 04-04-17 16:43:39, Reza Arbab wrote: >> Okay, getting further. With this I can again repeatedly add and >> remove, but now I'm seeing a weird variation of that earlier issue: >> >> 1. add_memory(), online_movable >> /sys/devices/system/node/nodeX/memoryY symlinks are created. >> >> 2. offline, remove_memory() >> The node is offlined, since all memory has been removed, so all of >> /sys/devices/system/node/nodeX is gone. This is normal. >> >> 3. add_memory(), online_movable >> The node is onlined, so /sys/devices/system/node/nodeX is recreated, >> and the memory is added, but just like earlier in this email thread, >> the memoryY links are not there. > >Could you add some printks to see why the sysfs creation failed please? Ah, simple enough. It's this, right at the top of register_mem_sect_under_node(): if (!node_online(nid)) return 0; That being the case, I really don't understand why your patches make any difference. Is node_set_online() being called later than before somehow? -- Reza Arbab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org