[PATCH libdrm] configure.ac: pthread-stubs is not a thing on GNU/kFreeBSD

[PATCH libdrm] configure.ac: pthread-stubs is not a thing on GNU/kFreeBSD

[Emil Velikov]

From: Emil Velikov <emil.velikov@collabora.com>

As mentioned on the xcb mailing list, the platform uses the GLIBC
forwarding mechanism.

https://lists.freedesktop.org/archives/xcb/2016-November/010896.html

Cc: Andreas Boll <andreas.boll.dev@gmail.com>
Reported-by: Andreas Boll <andreas.boll.dev@gmail.com>
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
---
I'm slightly inclined to go a single *gnu* but I'm not 100% sure if that
won't catch some corner case platforms. Opinions ?
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index f1a13090..0f6fe46d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -64,7 +64,7 @@ LT_INIT([disable-static])
 dnl pthread-stubs is mandatory on BSD platforms, due to the nature of the
 dnl project. Even then there's a notable issue as described in the project README
 case "$host_os" in
-linux* | cygwin* | darwin* | solaris* | gnu*)
+linux* | cygwin* | darwin* | solaris* | *-gnu* | gnu*)
     pthread_stubs_possible="no"
     ;;
 * )
-- 
2.11.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH libdrm] configure.ac: pthread-stubs is not a thing on GNU/kFreeBSD

[Eric Engestrom]

On Wednesday, 2017-04-05 17:24:31 +0100, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov@collabora.com>
> 
> As mentioned on the xcb mailing list, the platform uses the GLIBC
> forwarding mechanism.
> 
> https://lists.freedesktop.org/archives/xcb/2016-November/010896.html
> 
> Cc: Andreas Boll <andreas.boll.dev@gmail.com>
> Reported-by: Andreas Boll <andreas.boll.dev@gmail.com>
> Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
> ---
> I'm slightly inclined to go a single *gnu* but I'm not 100% sure if that
> won't catch some corner case platforms. Opinions ?

Go with `*gnu*` and replace it with something more complex if/when
someone reports this breaks their platform?
Without knowing any more, it's almost as likely that this hypothetical
platform would match `*-gnu*` as well anyway.

Either way:
Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>

> ---
>  configure.ac | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index f1a13090..0f6fe46d 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -64,7 +64,7 @@ LT_INIT([disable-static])
>  dnl pthread-stubs is mandatory on BSD platforms, due to the nature of the
>  dnl project. Even then there's a notable issue as described in the project README
>  case "$host_os" in
> -linux* | cygwin* | darwin* | solaris* | gnu*)
> +linux* | cygwin* | darwin* | solaris* | *-gnu* | gnu*)
>      pthread_stubs_possible="no"
>      ;;
>  * )
> -- 
> 2.11.1
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH libdrm] configure.ac: pthread-stubs is not a thing on GNU/kFreeBSD

[Andreas Boll]

2017-04-05 18:43 GMT+02:00 Eric Engestrom <eric.engestrom@imgtec.com>:
> On Wednesday, 2017-04-05 17:24:31 +0100, Emil Velikov wrote:
>> From: Emil Velikov <emil.velikov@collabora.com>
>>
>> As mentioned on the xcb mailing list, the platform uses the GLIBC
>> forwarding mechanism.
>>
>> https://lists.freedesktop.org/archives/xcb/2016-November/010896.html
>>
>> Cc: Andreas Boll <andreas.boll.dev@gmail.com>
>> Reported-by: Andreas Boll <andreas.boll.dev@gmail.com>
>> Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
>> ---
>> I'm slightly inclined to go a single *gnu* but I'm not 100% sure if that
>> won't catch some corner case platforms. Opinions ?
>
> Go with `*gnu*` and replace it with something more complex if/when
> someone reports this breaks their platform?
> Without knowing any more, it's almost as likely that this hypothetical
> platform would match `*-gnu*` as well anyway.
>
> Either way:
> Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>

Yeah, sounds good.

Either way too for this and the mesa patch:
Reviewed-by: Andreas Boll <andreas.boll.dev@gmail.com>

>
>> ---
>>  configure.ac | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index f1a13090..0f6fe46d 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -64,7 +64,7 @@ LT_INIT([disable-static])
>>  dnl pthread-stubs is mandatory on BSD platforms, due to the nature of the
>>  dnl project. Even then there's a notable issue as described in the project README
>>  case "$host_os" in
>> -linux* | cygwin* | darwin* | solaris* | gnu*)
>> +linux* | cygwin* | darwin* | solaris* | *-gnu* | gnu*)
>>      pthread_stubs_possible="no"
>>      ;;
>>  * )
>> --
>> 2.11.1
>>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel