* [PATCH] clk: sunxi-ng: Display index when clock registration fails
@ 2017-04-05 16:52 ` Priit Laes
0 siblings, 0 replies; 4+ messages in thread
From: Priit Laes @ 2017-04-05 16:52 UTC (permalink / raw)
To: linux-arm-kernel, linux-clk, linux-kernel
Cc: Maxime Ripard, Chen-Yu Tsai, Michael Turquette, Stephen Boyd, Priit Laes
Add clock index to clock registration failure message. Clock name
is sometimes not available, when things go really wrong.
Signed-off-by: Priit Laes <plaes@plaes.org>
---
drivers/clk/sunxi-ng/ccu_common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/sunxi-ng/ccu_common.c b/drivers/clk/sunxi-ng/ccu_common.c
index 8a47baf..188fa50 100644
--- a/drivers/clk/sunxi-ng/ccu_common.c
+++ b/drivers/clk/sunxi-ng/ccu_common.c
@@ -63,8 +63,8 @@ int sunxi_ccu_probe(struct device_node *node, void __iomem *reg,
ret = clk_hw_register(NULL, hw);
if (ret) {
- pr_err("Couldn't register clock %s\n",
- clk_hw_get_name(hw));
+ pr_err("Couldn't register clock %d - %s\n",
+ i, clk_hw_get_name(hw));
goto err_clk_unreg;
}
}
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] clk: sunxi-ng: Display index when clock registration fails
@ 2017-04-05 16:52 ` Priit Laes
0 siblings, 0 replies; 4+ messages in thread
From: Priit Laes @ 2017-04-05 16:52 UTC (permalink / raw)
To: linux-arm-kernel
Add clock index to clock registration failure message. Clock name
is sometimes not available, when things go really wrong.
Signed-off-by: Priit Laes <plaes@plaes.org>
---
drivers/clk/sunxi-ng/ccu_common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/sunxi-ng/ccu_common.c b/drivers/clk/sunxi-ng/ccu_common.c
index 8a47baf..188fa50 100644
--- a/drivers/clk/sunxi-ng/ccu_common.c
+++ b/drivers/clk/sunxi-ng/ccu_common.c
@@ -63,8 +63,8 @@ int sunxi_ccu_probe(struct device_node *node, void __iomem *reg,
ret = clk_hw_register(NULL, hw);
if (ret) {
- pr_err("Couldn't register clock %s\n",
- clk_hw_get_name(hw));
+ pr_err("Couldn't register clock %d - %s\n",
+ i, clk_hw_get_name(hw));
goto err_clk_unreg;
}
}
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: sunxi-ng: Display index when clock registration fails
2017-04-05 16:52 ` Priit Laes
@ 2017-04-06 7:10 ` Maxime Ripard
-1 siblings, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2017-04-06 7:10 UTC (permalink / raw)
To: Priit Laes
Cc: linux-arm-kernel, linux-clk, linux-kernel, Chen-Yu Tsai,
Michael Turquette, Stephen Boyd
[-- Attachment #1: Type: text/plain, Size: 373 bytes --]
On Wed, Apr 05, 2017 at 07:52:27PM +0300, Priit Laes wrote:
> Add clock index to clock registration failure message. Clock name
> is sometimes not available, when things go really wrong.
>
> Signed-off-by: Priit Laes <plaes@plaes.org>
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] clk: sunxi-ng: Display index when clock registration fails
@ 2017-04-06 7:10 ` Maxime Ripard
0 siblings, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2017-04-06 7:10 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Apr 05, 2017 at 07:52:27PM +0300, Priit Laes wrote:
> Add clock index to clock registration failure message. Clock name
> is sometimes not available, when things go really wrong.
>
> Signed-off-by: Priit Laes <plaes@plaes.org>
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170406/77046f9f/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-06 7:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-05 16:52 [PATCH] clk: sunxi-ng: Display index when clock registration fails Priit Laes
2017-04-05 16:52 ` Priit Laes
2017-04-06 7:10 ` Maxime Ripard
2017-04-06 7:10 ` Maxime Ripard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.