All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: git@jeffhostetler.com
Cc: git@vger.kernel.org, gitster@pobox.com,
	Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH v1 1/2] string-list: use ALLOC_GROW macro when reallocing string_list
Date: Wed, 5 Apr 2017 16:09:55 -0400	[thread overview]
Message-ID: <20170405200954.jmjvuzwjploenbho@sigill.intra.peff.net> (raw)
In-Reply-To: <20170405195600.54801-2-git@jeffhostetler.com>

On Wed, Apr 05, 2017 at 07:55:59PM +0000, git@jeffhostetler.com wrote:

> From: Jeff Hostetler <jeffhost@microsoft.com>
> 
> Use ALLOC_GROW() macro when reallocing a string_list array
> rather than simply increasing it by 32.  This is a performance
> optimization.
> 
> During status on a very large repo and there are many changes,
> a significant percentage of the total run time was spent
> reallocing the wt_status.changes array.
> 
> This change decreased the time in wt_status_collect_changes_worktree()
> from 125 seconds to 45 seconds on my very large repository.

Oof. Looks like the original was quadratic. I'm surprised this didn't
bite us more often. I guess we don't usually use string-lists for big
lists.

Aside from the redundant size-check that Stefan pointed out, the patch
looks obviously correct. I grepped for "alloc +=" and "alloc =.*+' to
see if there were any other cases, but didn't find any. Obviously that
is dependent on calling the variable "alloc", but that is normal for us
(and it does turn up a number of cases that do allocate correctly).

-Peff

  parent reply	other threads:[~2017-04-05 20:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-05 19:55 [PATCH v1 0/2] string-list: use ALLOC_GROW macro when reallocing git
2017-04-05 19:55 ` [PATCH v1 1/2] string-list: use ALLOC_GROW macro when reallocing string_list git
2017-04-05 20:00   ` Stefan Beller
2017-04-05 20:09   ` Jeff King [this message]
2017-04-05 21:12     ` Jeff Hostetler
2017-04-05 21:26   ` Jonathan Nieder
2017-04-05 19:56 ` [PATCH v1 2/2] p0005-status: time status on very large repo git
2017-04-05 21:33   ` Jonathan Nieder
2017-04-06 13:26     ` Jeff Hostetler
2017-04-07  4:29       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170405200954.jmjvuzwjploenbho@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@jeffhostetler.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jeffhost@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.