All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: git@jeffhostetler.com
Cc: git@vger.kernel.org, gitster@pobox.com, peff@peff.net,
	Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH v2 1/2] string-list: use ALLOC_GROW macro when reallocing string_list
Date: Wed, 5 Apr 2017 14:35:48 -0700	[thread overview]
Message-ID: <20170405213548.GI8741@aiede.mtv.corp.google.com> (raw)
In-Reply-To: <20170405210920.56549-2-git@jeffhostetler.com>

git@jeffhostetler.com wrote:

> During status on a very large repo and there are many changes,
> a significant percentage of the total run time was spent

nit: s/was/is/ (see comments on v1)

> reallocing the wt_status.changes array.
[...]
> Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
> ---
>  string-list.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

With or without that wording tweak,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

  reply	other threads:[~2017-04-05 21:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-05 21:09 [PATCH v2 0/2] string-list: use ALLOC_GROW macro when reallocing git
2017-04-05 21:09 ` [PATCH v2 1/2] string-list: use ALLOC_GROW macro when reallocing string_list git
2017-04-05 21:35   ` Jonathan Nieder [this message]
2017-04-05 21:09 ` [PATCH v2 2/2] p0005-status: time status on very large repo git

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170405213548.GI8741@aiede.mtv.corp.google.com \
    --to=jrnieder@gmail.com \
    --cc=git@jeffhostetler.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jeffhost@microsoft.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.