All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: sparclinux@vger.kernel.org
Subject: Re: [PATCH] sparc64: Fix kernel panic due to erroneous #ifdef surrounding pmd_write()
Date: Thu, 06 Apr 2017 19:06:45 +0000	[thread overview]
Message-ID: <20170406.120645.1470638295356870742.davem@davemloft.net> (raw)

From: Tom Hromatka <tom.hromatka@oracle.com>
Date: Fri, 31 Mar 2017 16:31:42 -0600

> This commit moves sparc64's prototype of pmd_write() outside
> of the CONFIG_TRANSPARENT_HUGEPAGE ifdef.
> 
> In 2013, commit a7b9403f0e6d ("sparc64: Encode huge PMDs using PTE
> encoding.") exposed a path where pmd_write() could be called without
> CONFIG_TRANSPARENT_HUGEPAGE defined.  This can result in the panic below.
> 
> The diff is awkward to read, but the changes are straightforward.
> pmd_write() was moved outside of #ifdef CONFIG_TRANSPARENT_HUGEPAGE.
> Also, __HAVE_ARCH_PMD_WRITE was defined.
> 
> kernel BUG at include/asm-generic/pgtable.h:576!
 ...
> Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

Applied.

             reply	other threads:[~2017-04-06 19:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-06 19:06 David Miller [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-03-31 22:31 [PATCH] sparc64: Fix kernel panic due to erroneous #ifdef surrounding pmd_write() Tom Hromatka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170406.120645.1470638295356870742.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.