All of lore.kernel.org
 help / color / mirror / Atom feed
From: Haozhong Zhang <haozhong.zhang@intel.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, xen-devel@lists.xen.org
Subject: Re: [PATCH 1/2] xen/mce: fix static variables 'found_error' and 'mce_fatal_cpus'
Date: Thu, 6 Apr 2017 16:49:12 +0800	[thread overview]
Message-ID: <20170406084912.kqcddxeaygojupl5@hz-desktop> (raw)
In-Reply-To: <58E6106A020000780014DB6E@prv-mh.provo.novell.com>

On 04/06/17 01:54 -0600, Jan Beulich wrote:
> >>> On 06.04.17 at 06:55, <haozhong.zhang@intel.com> wrote:
> > 1. Move them into mcheck_cmn_handler() which is their only user.
> 
> This part is uncontroversial.
> 
> > 2. Always (re-)initialize them to clear historical information.
> 
> But without further explanation I'm not convinced this part is correct.
> That's a good indication that you should split patches.
>
> I assume, btw, that you're aware that these patches won't go
> in very soon (not until after 4.9 has been branched off), unless
> they fix an actual bug.
>

Please drop this patch as it does not fix any bug. I was blind.
'found_error' is already cleared after mcheck_cmn_handler() used it.
Non-empty 'mce_fatal_errors' results in mc_panic(), so there is no
need to clear it.

Sorry for the noise.

Haozhong

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-04-06  8:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-06  4:55 [PATCH 1/2] xen/mce: fix static variables 'found_error' and 'mce_fatal_cpus' Haozhong Zhang
2017-04-06  4:55 ` [PATCH 2/2] xen/mce: fix static variable 'severity_cpu' Haozhong Zhang
2017-04-06  8:06   ` Jan Beulich
2017-04-06  8:49     ` Haozhong Zhang
2017-04-06  9:18       ` Jan Beulich
2017-04-06  7:54 ` [PATCH 1/2] xen/mce: fix static variables 'found_error' and 'mce_fatal_cpus' Jan Beulich
2017-04-06  8:49   ` Haozhong Zhang [this message]
2017-04-06  9:17     ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170406084912.kqcddxeaygojupl5@hz-desktop \
    --to=haozhong.zhang@intel.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.