From: Peter Zijlstra <firstname.lastname@example.org> To: Michal Hocko <email@example.com> Cc: Srikar Dronamraju <firstname.lastname@example.org>, Ingo Molnar <email@example.com>, LKML <firstname.lastname@example.org>, Mel Gorman <email@example.com>, Rik van Riel <firstname.lastname@example.org> Subject: Re: [PATCH] sched: Fix numabalancing to work with isolated cpus Date: Thu, 6 Apr 2017 11:23:29 +0200 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <20170406073436.GD5497@dhcp22.suse.cz> On Thu, Apr 06, 2017 at 09:34:36AM +0200, Michal Hocko wrote: > On Thu 06-04-17 12:49:50, Srikar Dronamraju wrote: > > Similar example that I gave in my reply to Mel. > > > > Lets consider 2 node, 24 core with 12 cores in each node. > > Cores 0-11 in Node 1 and cores 12-23 in the other node. > > Lets also disable smt/hyperthreading, enable isolcpus from core > > 6-11,12-17. Lets run 48 thread ebizzy workload and give it a cpu list > > of say 11,12-17 using taskset. > > > > Now all the 48 ebizzy threads will only run on core 11. It will never > > spread to other cores even in the same node(or in the same node/but > > isolated cpus) or to the different nodes. i.e even if numabalancing is > > running or not, even if my fix is around or not, all threads will be > > confined to core 11, even though the cpus_allowed is 11,12-17. Argh, why such a convoluted example :-( > Isn't that a bug in isolcpus implementation? It is certainly an > unexpected behavior I would say. Is this documented anywhere? Without engaging the brain too much to decipher the example; it does look right. isolcpus will have no balancing. > Isn't sched_setaffinity the only way how to actually make it possible to > run on isolcpus? Think so.. Personally I hate isolcpus and never use it. > I would really like to see it confirmed by the scheduler maintainers and > documented properly as well. What you are claiming here is rather > surprising to my understanding of what isolcpus acutally is. isolcpus gets you a set of fully partitioned CPUs. What's surprising about that?
next prev parent reply other threads:[~2017-04-06 9:23 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-04 17:27 Srikar Dronamraju 2017-04-04 18:56 ` Rik van Riel 2017-04-04 20:37 ` Mel Gorman 2017-04-05 1:50 ` Srikar Dronamraju 2017-04-05 8:09 ` Mel Gorman 2017-04-05 12:57 ` Michal Hocko 2017-04-05 15:22 ` Srikar Dronamraju 2017-04-05 16:44 ` Michal Hocko 2017-04-06 7:19 ` Srikar Dronamraju 2017-04-06 7:34 ` Michal Hocko 2017-04-06 9:23 ` Peter Zijlstra [this message] 2017-04-06 10:13 ` Michal Hocko 2017-04-06 10:29 ` Peter Zijlstra 2017-04-06 10:42 ` Michal Hocko 2017-04-06 10:47 ` Peter Zijlstra 2017-04-06 13:44 ` Michal Hocko 2017-04-06 7:36 ` Mike Galbraith 2017-04-06 7:36 ` Peter Zijlstra
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] sched: Fix numabalancing to work with isolated cpus' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.