From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailapp01.imgtec.com ([195.59.15.196]:11502 "EHLO imgpgp01.kl.imgtec.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757164AbdDFJ3v (ORCPT ); Thu, 6 Apr 2017 05:29:51 -0400 Date: Thu, 6 Apr 2017 10:29:47 +0100 From: James Hogan To: Amit Pundir CC: , , Felix Fietkau , Subject: Re: [PATCH v2 for-4.9 04/32] MIPS: Lantiq: Fix cascaded IRQ setup Message-ID: <20170406092947.GQ31606@jhogan-linux.le.imgtec.org> References: <1491388344-13521-1-git-send-email-amit.pundir@linaro.org> <1491388344-13521-5-git-send-email-amit.pundir@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8HHeiRpSfOSMcPVo" Content-Disposition: inline In-Reply-To: <1491388344-13521-5-git-send-email-amit.pundir@linaro.org> Sender: stable-owner@vger.kernel.org List-ID: --8HHeiRpSfOSMcPVo Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Amit, On Wed, Apr 05, 2017 at 04:01:56PM +0530, Amit Pundir wrote: > From: Felix Fietkau >=20 > With the IRQ stack changes integrated, the XRX200 devices started > emitting a constant stream of kernel messages like this: >=20 > [ 565.415310] Spurious IRQ: CAUSE=3D0x1100c300 >=20 > This is caused by IP0 getting handled by plat_irq_dispatch() rather than > its vectored interrupt handler, which is fixed by commit de856416e714 > ("MIPS: IRQ Stack: Fix erroneous jal to plat_irq_dispatch"). >=20 > Fix plat_irq_dispatch() to handle non-vectored IPI interrupts correctly > by setting up IP2-6 as proper chained IRQ handlers and calling do_IRQ > for all MIPS CPU interrupts. >=20 > Signed-off-by: Felix Fietkau > Acked-by: John Crispin > Cc: linux-mips@linux-mips.org > Patchwork: https://patchwork.linux-mips.org/patch/15077/ > [james.hogan@imgtec.com: tweaked commit message] > Signed-off-by: James Hogan >=20 > (cherry picked from commit 6c356eda225e3ee134ed4176b9ae3a76f793f4dd) > Signed-off-by: Amit Pundir Is there a particular reason this is desired in stable? I was under the impression it was only helpful in the presence of a bug in the separate IRQ stack stuff in 4.11, which was fixed in the above mentioned commit de856416e714 ("MIPS: IRQ Stack: Fix erroneous jal to plat_irq_dispatch"), and otherwise just a nice to have cleanup. If you've cherry picked the IRQ stack work, have you also cherry-picked de856416e714? Cheers James --8HHeiRpSfOSMcPVo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJY5gqEAAoJEGwLaZPeOHZ6PAEQAIqVEPVRWYEM2dwbTEeUmkSh 1ycYD7wXDIsi6RNXqtIr35+L0lRUE758BKAWom1SIWHKrQh32XUO7s0QnLUoSA8v BWQBBkmOIHfSFwbbXM08ep89CcexxVWqljgOC8qgMD1HI9raXpuhABQMZy96xtHH IfOua1NpYZuFPCVTpo/r2qHPXDy5TK1JHl2pcm9E+NgkDcA+q9yTcmN9nulzbtdV 5kZDpU+9J0V/KnyiugRnAGl5OIoCG2TwtCm9AwZk/5X1TXL9YSGgtFsBCa/HBffx rBRqFhNRbZIyPru+Lsc/YRpZbmsl8S833raR2gDmKR5ezN6eA347Q679oHUgU5cQ STv5Q/xW/qEx7P419W3d3QMN8KxWRM4n1w4Mze7rOaY/xsxsOKU4Iw8om5xBuujd LgIZwRd9YZqwf6/h6/EGL8p1/7w7ne8LDYCXLuk0i6di+e8lwQZDnpNZMlB7iarF rVbvon50OURuS5exG8llnR5k6FwZsX/OQKHfNCwSfx+hYNEJAsMvVN/1FZsArub4 3YrL5hUWOknCFrcPE60EaV/CvlhH+joHhul2UGBgWX9cvDfBm78MWRE+vLnK1kVu dQD/1uUY4laDNl057iupAeKnAjgy9YghxT1RoUaqmR8b6HVEY0BRDukXHJIOz5S8 JtSALxKqh6eFuBQW5jmW =ZbgZ -----END PGP SIGNATURE----- --8HHeiRpSfOSMcPVo-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailapp01.imgtec.com ([195.59.15.196]:28999 "EHLO imgpgp01.kl.imgtec.org" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S23990519AbdDFJ3xtafWJ (ORCPT ); Thu, 6 Apr 2017 11:29:53 +0200 Date: Thu, 6 Apr 2017 10:29:47 +0100 From: James Hogan Subject: Re: [PATCH v2 for-4.9 04/32] MIPS: Lantiq: Fix cascaded IRQ setup Message-ID: <20170406092947.GQ31606@jhogan-linux.le.imgtec.org> References: <1491388344-13521-1-git-send-email-amit.pundir@linaro.org> <1491388344-13521-5-git-send-email-amit.pundir@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8HHeiRpSfOSMcPVo" Content-Disposition: inline In-Reply-To: <1491388344-13521-5-git-send-email-amit.pundir@linaro.org> Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Amit Pundir Cc: stable@vger.kernel.org, gregkh@linuxfoundation.org, Felix Fietkau , linux-mips@linux-mips.org Message-ID: <20170406092947.yHYGacq1uLZUTMABHb9us1DFRYBlMBQfxiDJKsEoFUQ@z> --8HHeiRpSfOSMcPVo Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Amit, On Wed, Apr 05, 2017 at 04:01:56PM +0530, Amit Pundir wrote: > From: Felix Fietkau >=20 > With the IRQ stack changes integrated, the XRX200 devices started > emitting a constant stream of kernel messages like this: >=20 > [ 565.415310] Spurious IRQ: CAUSE=3D0x1100c300 >=20 > This is caused by IP0 getting handled by plat_irq_dispatch() rather than > its vectored interrupt handler, which is fixed by commit de856416e714 > ("MIPS: IRQ Stack: Fix erroneous jal to plat_irq_dispatch"). >=20 > Fix plat_irq_dispatch() to handle non-vectored IPI interrupts correctly > by setting up IP2-6 as proper chained IRQ handlers and calling do_IRQ > for all MIPS CPU interrupts. >=20 > Signed-off-by: Felix Fietkau > Acked-by: John Crispin > Cc: linux-mips@linux-mips.org > Patchwork: https://patchwork.linux-mips.org/patch/15077/ > [james.hogan@imgtec.com: tweaked commit message] > Signed-off-by: James Hogan >=20 > (cherry picked from commit 6c356eda225e3ee134ed4176b9ae3a76f793f4dd) > Signed-off-by: Amit Pundir Is there a particular reason this is desired in stable? I was under the impression it was only helpful in the presence of a bug in the separate IRQ stack stuff in 4.11, which was fixed in the above mentioned commit de856416e714 ("MIPS: IRQ Stack: Fix erroneous jal to plat_irq_dispatch"), and otherwise just a nice to have cleanup. If you've cherry picked the IRQ stack work, have you also cherry-picked de856416e714? Cheers James --8HHeiRpSfOSMcPVo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJY5gqEAAoJEGwLaZPeOHZ6PAEQAIqVEPVRWYEM2dwbTEeUmkSh 1ycYD7wXDIsi6RNXqtIr35+L0lRUE758BKAWom1SIWHKrQh32XUO7s0QnLUoSA8v BWQBBkmOIHfSFwbbXM08ep89CcexxVWqljgOC8qgMD1HI9raXpuhABQMZy96xtHH IfOua1NpYZuFPCVTpo/r2qHPXDy5TK1JHl2pcm9E+NgkDcA+q9yTcmN9nulzbtdV 5kZDpU+9J0V/KnyiugRnAGl5OIoCG2TwtCm9AwZk/5X1TXL9YSGgtFsBCa/HBffx rBRqFhNRbZIyPru+Lsc/YRpZbmsl8S833raR2gDmKR5ezN6eA347Q679oHUgU5cQ STv5Q/xW/qEx7P419W3d3QMN8KxWRM4n1w4Mze7rOaY/xsxsOKU4Iw8om5xBuujd LgIZwRd9YZqwf6/h6/EGL8p1/7w7ne8LDYCXLuk0i6di+e8lwQZDnpNZMlB7iarF rVbvon50OURuS5exG8llnR5k6FwZsX/OQKHfNCwSfx+hYNEJAsMvVN/1FZsArub4 3YrL5hUWOknCFrcPE60EaV/CvlhH+joHhul2UGBgWX9cvDfBm78MWRE+vLnK1kVu dQD/1uUY4laDNl057iupAeKnAjgy9YghxT1RoUaqmR8b6HVEY0BRDukXHJIOz5S8 JtSALxKqh6eFuBQW5jmW =ZbgZ -----END PGP SIGNATURE----- --8HHeiRpSfOSMcPVo--