From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934540AbdDFKkJ convert rfc822-to-8bit (ORCPT ); Thu, 6 Apr 2017 06:40:09 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:51331 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932442AbdDFKkB (ORCPT ); Thu, 6 Apr 2017 06:40:01 -0400 From: Juergen Borleis Organization: Pengutronix e.K. To: Andrew Lunn Subject: Re: [PATCH 2/4] net: dsa: add new DSA switch driver for the SMSC-LAN9303 Date: Thu, 6 Apr 2017 12:39:22 +0200 User-Agent: KMail/1.9.10 (enterprise35 0.20100827.1168748) Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, f.fainelli@gmail.com, kernel@pengutronix.de, vivien.didelot@savoirfairelinux.com, davem@davemloft.net References: <20170405092024.16048-1-jbe@pengutronix.de> <20170405092024.16048-3-jbe@pengutronix.de> <20170405181232.GE21965@lunn.ch> In-Reply-To: <20170405181232.GE21965@lunn.ch> X-KMail-QuotePrefix: > MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Content-Disposition: inline Message-Id: <201704061239.23151.jbe@pengutronix.de> X-SA-Exim-Connect-IP: 2001:67c:670:100:5e26:aff:fe2b:7cc4 X-SA-Exim-Mail-From: jbe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrew, On Wednesday 05 April 2017 20:12:32 Andrew Lunn wrote: > [...] > > drivers/net/phy/lan9303-core.c | 924 +++++++++++++++++++++++++++++++++++++++++ > > drivers/net/phy/lan9303.h | 21 + > > drivers/net/dsa please. Done in v2. > One general comment. I'm assuming parts of this code comes from > openwrt swconfig. In swconfig, i think they consider switches to be > part of the PHY layer. In DSA, switches are switches, PHYs are > PHYs. So the naming in this driver needs to reflect this. And the LAN9303 is a switch with built-in PHYs :) Juergen -- Pengutronix e.K.                            | Juergen Borleis             | Industrial Linux Solutions                  | http://www.pengutronix.de/  |