[Buildroot] [PATCH] fmt: new package

[Buildroot] [PATCH] fmt: new package

[Semyon Kolganov]

Signed-off-by: Semyon Kolganov <semenak94@mail.ru>
---
 package/Config.in     |  1 +
 package/fmt/Config.in |  6 ++++++
 package/fmt/fmt.hash  |  4 ++++
 package/fmt/fmt.mk    | 23 +++++++++++++++++++++++
 4 files changed, 34 insertions(+)
 create mode 100644 package/fmt/Config.in
 create mode 100755 package/fmt/fmt.hash
 create mode 100755 package/fmt/fmt.mk

diff --git a/package/Config.in b/package/Config.in
index 71bd44a..6f3399f 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1434,6 +1434,7 @@ menu "Text and terminal handling"
 	source "package/augeas/Config.in"
 	source "package/enchant/Config.in"
 	source "package/icu/Config.in"
+	source "package/fmt/Config.in"
 	source "package/libcli/Config.in"
 	source "package/libedit/Config.in"
 	source "package/libenca/Config.in"
diff --git a/package/fmt/Config.in b/package/fmt/Config.in
new file mode 100644
index 0000000..9ce2874
--- /dev/null
+++ b/package/fmt/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_FMT
+	bool "fmt"
+	help
+	  fmt is an open-source formatting library for C++. It can be used
+	  as a safe alternative to printf or as a fast alternative to
+	  IOStreams.
\ No newline at end of file
diff --git a/package/fmt/fmt.hash b/package/fmt/fmt.hash
new file mode 100755
index 0000000..31d4eaa
--- /dev/null
+++ b/package/fmt/fmt.hash
@@ -0,0 +1,4 @@
+# Calculated on http://onlinemd5.com/
+sha1	c7026a04f05331004888bf0ab8ef2ef3c002933c fmt-3.0.1.tar.gz
+# Calculated on http://onlinemd5.com/
+sha256	dce62ab75a161dd4353a98364feb166d35e7eea382169d59d9ce842c49c55bad fmt-3.0.1.tar.gz
diff --git a/package/fmt/fmt.mk b/package/fmt/fmt.mk
new file mode 100755
index 0000000..47a332d
--- /dev/null
+++ b/package/fmt/fmt.mk
@@ -0,0 +1,23 @@
+################################################################################
+#
+# fmt
+#
+################################################################################
+
+FMT_VERSION = 3.0.1
+FMT_SITE = $(call github,fmtlib,fmt,$(FMT_VERSION))
+FMT_LICENSE = BSD-2-Clause
+FMT_LICENSE_FILES = LICENSE.rst
+FMT_INSTALL_STAGING = YES
+
+FMT_CONF_OPTS = \
+	-DHAVE_OPEN=ON \
+	-DFMT_INSTALL=ON \
+	-DFMT_TEST=OFF
+
+define FMT_INSTALL_STAGING_CMDS
+	mkdir -p $(STAGING_DIR)/usr/include/fmt
+	cp -dpfr $(@D)/fmt/*.h $(STAGING_DIR)/usr/include/fmt
+endef
+
+$(eval $(cmake-package))
-- 
2.7.4

[Buildroot] [PATCH] fmt: new package

[Thomas Petazzoni]

Hello,

Thanks for this new version. For new versions, it is better if the
subject prefix is change, and you include a changelog.

To change the subject prefix:

	git format-patch -v2 HEAD^

will change [PATCH] into [PATCHv2]

On Thu,  6 Apr 2017 13:30:19 +0300, Semyon Kolganov wrote:
> Signed-off-by: Semyon Kolganov <semenak94@mail.ru>
> ---

And the changelog can be written here, detailing what changed between
v1 and v2.

> diff --git a/package/fmt/Config.in b/package/fmt/Config.in
> new file mode 100644
> index 0000000..9ce2874
> --- /dev/null
> +++ b/package/fmt/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_FMT
> +	bool "fmt"

Missed this on the first review: since this is a C++ package, you need
to do:

	depends on BR2_INSTALL_LIBSTDCPP

> +	help
> +	  fmt is an open-source formatting library for C++. It can be used
> +	  as a safe alternative to printf or as a fast alternative to
> +	  IOStreams.
> \ No newline at end of file

Still a missing new line here.

And since there's now a C++ dependency, you must add:

comment "fmt needs a toolchain w/ C++"
	depends on !BR2_INSTALL_LIBSTDCPP

> +FMT_CONF_OPTS = \
> +	-DHAVE_OPEN=ON \
> +	-DFMT_INSTALL=ON \
> +	-DFMT_TEST=OFF
> +
> +define FMT_INSTALL_STAGING_CMDS
> +	mkdir -p $(STAGING_DIR)/usr/include/fmt
> +	cp -dpfr $(@D)/fmt/*.h $(STAGING_DIR)/usr/include/fmt
> +endef

I still don't get this. For the target installation, you're using the
"make install" from the CMake packaging, but for the staging
installation, you're overriding the logic to only install the header
files. Why?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCHv2] fmt: new package PATCHv2

[Semyon Kolganov]

Signed-off-by: Semyon Kolganov <semenak94@mail.ru>
---
 package/Config.in     | 2 +-
 package/fmt/Config.in | 5 ++++-
 package/fmt/fmt.mk    | 5 -----
 3 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/package/Config.in b/package/Config.in
index 6f3399f..2bd55ec 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1433,8 +1433,8 @@ endmenu
 menu "Text and terminal handling"
 	source "package/augeas/Config.in"
 	source "package/enchant/Config.in"
-	source "package/icu/Config.in"
 	source "package/fmt/Config.in"
+	source "package/icu/Config.in"
 	source "package/libcli/Config.in"
 	source "package/libedit/Config.in"
 	source "package/libenca/Config.in"
diff --git a/package/fmt/Config.in b/package/fmt/Config.in
index 9ce2874..e829f1f 100644
--- a/package/fmt/Config.in
+++ b/package/fmt/Config.in
@@ -3,4 +3,7 @@ config BR2_PACKAGE_FMT
 	help
 	  fmt is an open-source formatting library for C++. It can be used
 	  as a safe alternative to printf or as a fast alternative to
-	  IOStreams.
\ No newline at end of file
+	  IOStreams.
+
+comment "fmt needs a toolchain w/ C++"
+	depends on !BR2_INSTALL_LIBSTDCPP
diff --git a/package/fmt/fmt.mk b/package/fmt/fmt.mk
index 47a332d..b7e3db0 100755
--- a/package/fmt/fmt.mk
+++ b/package/fmt/fmt.mk
@@ -15,9 +15,4 @@ FMT_CONF_OPTS = \
 	-DFMT_INSTALL=ON \
 	-DFMT_TEST=OFF
 
-define FMT_INSTALL_STAGING_CMDS
-	mkdir -p $(STAGING_DIR)/usr/include/fmt
-	cp -dpfr $(@D)/fmt/*.h $(STAGING_DIR)/usr/include/fmt
-endef
-
 $(eval $(cmake-package))
-- 
2.7.4

[Buildroot] [PATCHv2] fmt: new package PATCHv2

[Thomas Petazzoni]

Hello,

On Thu,  6 Apr 2017 15:02:03 +0300, Semyon Kolganov wrote:
> Signed-off-by: Semyon Kolganov <semenak94@mail.ru>

This is not a complete patch: what you have sent here is just the
difference compared to your previous version.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCHv3] fmt: new package PACKAGEv3

[Semyon Kolganov]

Signed-off-by: Semyon Kolganov <semenak94@mail.ru>

Changes between v2 and v3:
 - removed Staging section in fmt.mk file
 - formatting fixes
 - added dependency from w/ C++

Changes between v1 and v2:
 - formatting fixes
 - added right license
 - using Github helper to download
---
 package/Config.in     |  1 +
 package/fmt/Config.in |  9 +++++++++
 package/fmt/fmt.hash  |  4 ++++
 package/fmt/fmt.mk    | 18 ++++++++++++++++++
 4 files changed, 32 insertions(+)
 create mode 100644 package/fmt/Config.in
 create mode 100755 package/fmt/fmt.hash
 create mode 100755 package/fmt/fmt.mk

diff --git a/package/Config.in b/package/Config.in
index 71bd44a..2bd55ec 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1433,6 +1433,7 @@ endmenu
 menu "Text and terminal handling"
 	source "package/augeas/Config.in"
 	source "package/enchant/Config.in"
+	source "package/fmt/Config.in"
 	source "package/icu/Config.in"
 	source "package/libcli/Config.in"
 	source "package/libedit/Config.in"
diff --git a/package/fmt/Config.in b/package/fmt/Config.in
new file mode 100644
index 0000000..e829f1f
--- /dev/null
+++ b/package/fmt/Config.in
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_FMT
+	bool "fmt"
+	help
+	  fmt is an open-source formatting library for C++. It can be used
+	  as a safe alternative to printf or as a fast alternative to
+	  IOStreams.
+
+comment "fmt needs a toolchain w/ C++"
+	depends on !BR2_INSTALL_LIBSTDCPP
diff --git a/package/fmt/fmt.hash b/package/fmt/fmt.hash
new file mode 100755
index 0000000..31d4eaa
--- /dev/null
+++ b/package/fmt/fmt.hash
@@ -0,0 +1,4 @@
+# Calculated on http://onlinemd5.com/
+sha1	c7026a04f05331004888bf0ab8ef2ef3c002933c fmt-3.0.1.tar.gz
+# Calculated on http://onlinemd5.com/
+sha256	dce62ab75a161dd4353a98364feb166d35e7eea382169d59d9ce842c49c55bad fmt-3.0.1.tar.gz
diff --git a/package/fmt/fmt.mk b/package/fmt/fmt.mk
new file mode 100755
index 0000000..b7e3db0
--- /dev/null
+++ b/package/fmt/fmt.mk
@@ -0,0 +1,18 @@
+################################################################################
+#
+# fmt
+#
+################################################################################
+
+FMT_VERSION = 3.0.1
+FMT_SITE = $(call github,fmtlib,fmt,$(FMT_VERSION))
+FMT_LICENSE = BSD-2-Clause
+FMT_LICENSE_FILES = LICENSE.rst
+FMT_INSTALL_STAGING = YES
+
+FMT_CONF_OPTS = \
+	-DHAVE_OPEN=ON \
+	-DFMT_INSTALL=ON \
+	-DFMT_TEST=OFF
+
+$(eval $(cmake-package))
-- 
2.7.4

[Buildroot] [PATCHv4] fmt: new package

[Semyon Kolganov]

Signed-off-by: Semyon Kolganov <semenak94@mail.ru>

Changes between v3 and v4:
 - fix misprint

Changes between v2 and v3:
 - removed Staging section in fmt.mk file
 - formatting fixes
 - added dependency from w/ C++

Changes between v1 and v2:
 - formatting fixes
 - added right license
 - using Github helper to download
---
 package/Config.in     |  1 +
 package/fmt/Config.in |  9 +++++++++
 package/fmt/fmt.hash  |  4 ++++
 package/fmt/fmt.mk    | 18 ++++++++++++++++++
 4 files changed, 32 insertions(+)
 create mode 100644 package/fmt/Config.in
 create mode 100755 package/fmt/fmt.hash
 create mode 100755 package/fmt/fmt.mk

diff --git a/package/Config.in b/package/Config.in
index 71bd44a..2bd55ec 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1433,6 +1433,7 @@ endmenu
 menu "Text and terminal handling"
 	source "package/augeas/Config.in"
 	source "package/enchant/Config.in"
+	source "package/fmt/Config.in"
 	source "package/icu/Config.in"
 	source "package/libcli/Config.in"
 	source "package/libedit/Config.in"
diff --git a/package/fmt/Config.in b/package/fmt/Config.in
new file mode 100644
index 0000000..112d116
--- /dev/null
+++ b/package/fmt/Config.in
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_FMT
+	bool "fmt"
+	help
+	  fmt is an open-source formatting library for C++. It can be used
+	  as a safe alternative to printf or as a fast alternative to
+	  IOStreams.
+
+comment "fmt needs a toolchain w/ C++"
+	depends on BR2_INSTALL_LIBSTDCPP
diff --git a/package/fmt/fmt.hash b/package/fmt/fmt.hash
new file mode 100755
index 0000000..31d4eaa
--- /dev/null
+++ b/package/fmt/fmt.hash
@@ -0,0 +1,4 @@
+# Calculated on http://onlinemd5.com/
+sha1	c7026a04f05331004888bf0ab8ef2ef3c002933c fmt-3.0.1.tar.gz
+# Calculated on http://onlinemd5.com/
+sha256	dce62ab75a161dd4353a98364feb166d35e7eea382169d59d9ce842c49c55bad fmt-3.0.1.tar.gz
diff --git a/package/fmt/fmt.mk b/package/fmt/fmt.mk
new file mode 100755
index 0000000..b7e3db0
--- /dev/null
+++ b/package/fmt/fmt.mk
@@ -0,0 +1,18 @@
+################################################################################
+#
+# fmt
+#
+################################################################################
+
+FMT_VERSION = 3.0.1
+FMT_SITE = $(call github,fmtlib,fmt,$(FMT_VERSION))
+FMT_LICENSE = BSD-2-Clause
+FMT_LICENSE_FILES = LICENSE.rst
+FMT_INSTALL_STAGING = YES
+
+FMT_CONF_OPTS = \
+	-DHAVE_OPEN=ON \
+	-DFMT_INSTALL=ON \
+	-DFMT_TEST=OFF
+
+$(eval $(cmake-package))
-- 
2.7.4

[Buildroot] [PATCHv4] fmt: new package

[Baruch Siach]

Hi Semyon,

On Thu, Apr 06, 2017 at 05:27:02PM +0300, Semyon Kolganov wrote:
> +config BR2_PACKAGE_FMT
> +	bool "fmt"
> +	help
> +	  fmt is an open-source formatting library for C++. It can be used
> +	  as a safe alternative to printf or as a fast alternative to
> +	  IOStreams.
> +
> +comment "fmt needs a toolchain w/ C++"
> +	depends on BR2_INSTALL_LIBSTDCPP

This should be the dependency of BR2_PACKAGE_FMT, not of the comment. The 
comment should depend on !BR2_INSTALL_LIBSTDCPP, that is, the comment shows 
when the toolchain has no C++ support.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

[Buildroot] [PATCHv5] fmt: new package

[Semyon Kolganov]

Signed-off-by: Semyon Kolganov <semenak94@mail.ru>

Changes between v4 and v5:
 - added dependcy from LIBSTDCPP to fmt

Changes between v3 and v4:
 - fixed misprint

Changes between v2 and v3:
 - removed Staging section in fmt.mk file
 - formatting fixes
 - added dependency from w/ C++

Changes between v1 and v2:
 - formatting fixes
 - added right license
 - using Github helper to download
---
 package/Config.in     |  1 +
 package/fmt/Config.in | 10 ++++++++++
 package/fmt/fmt.hash  |  4 ++++
 package/fmt/fmt.mk    | 18 ++++++++++++++++++
 4 files changed, 33 insertions(+)
 create mode 100644 package/fmt/Config.in
 create mode 100755 package/fmt/fmt.hash
 create mode 100755 package/fmt/fmt.mk

diff --git a/package/Config.in b/package/Config.in
index 71bd44a..2bd55ec 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1433,6 +1433,7 @@ endmenu
 menu "Text and terminal handling"
 	source "package/augeas/Config.in"
 	source "package/enchant/Config.in"
+	source "package/fmt/Config.in"
 	source "package/icu/Config.in"
 	source "package/libcli/Config.in"
 	source "package/libedit/Config.in"
diff --git a/package/fmt/Config.in b/package/fmt/Config.in
new file mode 100644
index 0000000..4c68357
--- /dev/null
+++ b/package/fmt/Config.in
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_FMT
+	bool "fmt"
+	depends on BR2_INSTALL_LIBSTDCPP
+	help
+	  fmt is an open-source formatting library for C++. It can be used
+	  as a safe alternative to printf or as a fast alternative to
+	  IOStreams.
+
+comment "fmt needs a toolchain w/ C++"
+	depends on !BR2_INSTALL_LIBSTDCPP
diff --git a/package/fmt/fmt.hash b/package/fmt/fmt.hash
new file mode 100755
index 0000000..31d4eaa
--- /dev/null
+++ b/package/fmt/fmt.hash
@@ -0,0 +1,4 @@
+# Calculated on http://onlinemd5.com/
+sha1	c7026a04f05331004888bf0ab8ef2ef3c002933c fmt-3.0.1.tar.gz
+# Calculated on http://onlinemd5.com/
+sha256	dce62ab75a161dd4353a98364feb166d35e7eea382169d59d9ce842c49c55bad fmt-3.0.1.tar.gz
diff --git a/package/fmt/fmt.mk b/package/fmt/fmt.mk
new file mode 100755
index 0000000..b7e3db0
--- /dev/null
+++ b/package/fmt/fmt.mk
@@ -0,0 +1,18 @@
+################################################################################
+#
+# fmt
+#
+################################################################################
+
+FMT_VERSION = 3.0.1
+FMT_SITE = $(call github,fmtlib,fmt,$(FMT_VERSION))
+FMT_LICENSE = BSD-2-Clause
+FMT_LICENSE_FILES = LICENSE.rst
+FMT_INSTALL_STAGING = YES
+
+FMT_CONF_OPTS = \
+	-DHAVE_OPEN=ON \
+	-DFMT_INSTALL=ON \
+	-DFMT_TEST=OFF
+
+$(eval $(cmake-package))
-- 
2.7.4

[Buildroot] [PATCHv5] fmt: new package

[Thomas Petazzoni]

Hello,

On Thu,  6 Apr 2017 18:41:17 +0300, Semyon Kolganov wrote:
> Signed-off-by: Semyon Kolganov <semenak94@mail.ru>
> 
> Changes between v4 and v5:
>  - added dependcy from LIBSTDCPP to fmt
> 
> Changes between v3 and v4:
>  - fixed misprint
> 
> Changes between v2 and v3:
>  - removed Staging section in fmt.mk file
>  - formatting fixes
>  - added dependency from w/ C++
> 
> Changes between v1 and v2:
>  - formatting fixes
>  - added right license
>  - using Github helper to download
> ---
>  package/Config.in     |  1 +
>  package/fmt/Config.in | 10 ++++++++++
>  package/fmt/fmt.hash  |  4 ++++
>  package/fmt/fmt.mk    | 18 ++++++++++++++++++
>  4 files changed, 33 insertions(+)
>  create mode 100644 package/fmt/Config.in
>  create mode 100755 package/fmt/fmt.hash
>  create mode 100755 package/fmt/fmt.mk

Applied to master with the following changes:

    [Thomas:
     - add entry to DEVELOPERS file
     - add missing wchar dependency
     - minor tweaks.]

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com