From: Stefan Hajnoczi <email@example.com> To: "Xu, Anthony" <firstname.lastname@example.org>, "'email@example.com'" <firstname.lastname@example.org>, 'Paolo Bonzini' <email@example.com> Subject: Re: [Qemu-devel] [PATCH] Put all trace.o into libqemuutil.a Date: Thu, 6 Apr 2017 14:23:01 +0100 [thread overview] Message-ID: <20170406132301.GM21895@stefanha-x1.localdomain> (raw) In-Reply-To: <firstname.lastname@example.org> [-- Attachment #1: Type: text/plain, Size: 1296 bytes --] On Wed, Apr 05, 2017 at 11:15:58AM +0300, Lluís Vilanova wrote: > Xu, Anthony writes: > > > Put all trace.o into libqemuutil.a > > Currently all trace.o are linked into qemu-system, qemu-img, > > qemu-nbd, qemu-io etc., even the corresponding components > > are not included. > > Put all trace.o into libqemuutil.a that the linker would only pull in .o > > files containing symbols that are actually referenced by the > > program. > > I think this change conflicts with some of the guest code tracing patches I have > in the queue (I won't be able to send the new series until the end of the month, > sorry). > > AFAIR, some of my patches need to link different code for utils and qemu's main > binaries. Although there might be a better way of doing it that I missed. I don't know the details of your unsent patches, but one possible solution is stubs/* where we stub out functions that are unavailable in tools. That way the same code links in the main QEMU program and in utils. When the code runs in utils, it either doesn't take the code path that reaches the stub function or it calls the stub and continues unaware that the call was a noop. If you want to discuss further, feel free to post an RFC preview series of your work in progress. Stefan [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2017-04-06 13:23 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-04 21:39 Xu, Anthony 2017-04-05 8:15 ` Lluís Vilanova 2017-04-06 13:23 ` Stefan Hajnoczi [this message] 2017-04-05 9:14 ` Daniel P. Berrange 2017-04-06 14:38 ` Stefan Hajnoczi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170406132301.GM21895@stefanha-x1.localdomain \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [Qemu-devel] [PATCH] Put all trace.o into libqemuutil.a' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.