All of
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <>
To: "Xu, Anthony" <>
Cc: "''" <>,
	'Daniel Berrange' <>,
	'Paolo Bonzini' <>
Subject: Re: [Qemu-devel] [PATCH] Put all trace.o into libqemuutil.a
Date: Thu, 6 Apr 2017 15:38:07 +0100	[thread overview]
Message-ID: <20170406143807.GN21895@stefanha-x1.localdomain> (raw)
In-Reply-To: <>

[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]

On Tue, Apr 04, 2017 at 09:39:39PM +0000, Xu, Anthony wrote:

Thanks, applied to my tracing-next tree:

I fixed up the patch when applying it.  Comments below:

> Put all trace.o into libqemuutil.a

Please use the "trace: " prefix for tracing patches.

All components of QEMU have commonly used prefixes that make it easy to
identify which area a patch affects.  People reading the mailing list or
grepping through git logs rely on this.

> Currently all trace.o are linked into qemu-system, qemu-img, 
> qemu-nbd, qemu-io etc., even the corresponding components 
> are not included.
> Put all trace.o into libqemuutil.a that the linker would only pull in .o 
> files containing symbols that are actually referenced by the 
> program.
> Signed-off -by: Anthony Xu <>

Please use git-format-patch(1) to send correctly formatted patches in
the future.  git-am(1) was unable to apply your email and I had to do it


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

      parent reply	other threads:[~2017-04-06 14:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-04 21:39 Xu, Anthony
2017-04-05  8:15 ` Lluís Vilanova
2017-04-06 13:23   ` Stefan Hajnoczi
2017-04-05  9:14 ` Daniel P. Berrange
2017-04-06 14:38 ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170406143807.GN21895@stefanha-x1.localdomain \ \ \ \ \ \
    --subject='Re: [Qemu-devel] [PATCH] Put all trace.o into libqemuutil.a' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.