From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53978) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cw60O-0000mt-76 for qemu-devel@nongnu.org; Thu, 06 Apr 2017 07:55:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cw60J-0004Yc-MG for qemu-devel@nongnu.org; Thu, 06 Apr 2017 07:55:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46408) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cw60J-0004XD-Gt for qemu-devel@nongnu.org; Thu, 06 Apr 2017 07:55:07 -0400 Date: Thu, 6 Apr 2017 14:54:57 +0300 From: "Michael S. Tsirkin" Message-ID: <20170406145450-mutt-send-email-mst@kernel.org> References: <1491462524-1617-1-git-send-email-peterx@redhat.com> <1491462524-1617-3-git-send-email-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1491462524-1617-3-git-send-email-peterx@redhat.com> Subject: Re: [Qemu-devel] [PATCH v8 2/9] memory: provide IOMMU_NOTIFIER_FOREACH macro List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: qemu-devel@nongnu.org, tianyu.lan@intel.com, kevin.tian@intel.com, Marcel Apfelbaum , jan.kiszka@siemens.com, jasowang@redhat.com, David Gibson , alex.williamson@redhat.com, bd.aviv@gmail.com On Thu, Apr 06, 2017 at 03:08:37PM +0800, Peter Xu wrote: > Reviewed-by: David Gibson > Signed-off-by: Peter Xu Reviewed-by: Michael S. Tsirkin > --- > include/exec/memory.h | 3 +++ > memory.c | 4 ++-- > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/include/exec/memory.h b/include/exec/memory.h > index 0840c89..07e43da 100644 > --- a/include/exec/memory.h > +++ b/include/exec/memory.h > @@ -239,6 +239,9 @@ struct MemoryRegion { > IOMMUNotifierFlag iommu_notify_flags; > }; > > +#define IOMMU_NOTIFIER_FOREACH(n, mr) \ > + QLIST_FOREACH((n), &(mr)->iommu_notify, node) > + > /** > * MemoryListener: callbacks structure for updates to the physical memory map > * > diff --git a/memory.c b/memory.c > index 75ac595..7496b3d 100644 > --- a/memory.c > +++ b/memory.c > @@ -1583,7 +1583,7 @@ static void memory_region_update_iommu_notify_flags(MemoryRegion *mr) > IOMMUNotifierFlag flags = IOMMU_NOTIFIER_NONE; > IOMMUNotifier *iommu_notifier; > > - QLIST_FOREACH(iommu_notifier, &mr->iommu_notify, node) { > + IOMMU_NOTIFIER_FOREACH(iommu_notifier, mr) { > flags |= iommu_notifier->notifier_flags; > } > > @@ -1667,7 +1667,7 @@ void memory_region_notify_iommu(MemoryRegion *mr, > request_flags = IOMMU_NOTIFIER_UNMAP; > } > > - QLIST_FOREACH(iommu_notifier, &mr->iommu_notify, node) { > + IOMMU_NOTIFIER_FOREACH(iommu_notifier, mr) { > /* > * Skip the notification if the notification does not overlap > * with registered range. > -- > 2.7.4