From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, tianyu.lan@intel.com,
kevin.tian@intel.com, Marcel Apfelbaum <marcel@redhat.com>,
jan.kiszka@siemens.com, jasowang@redhat.com,
David Gibson <david@gibson.dropbear.id.au>,
alex.williamson@redhat.com, bd.aviv@gmail.com,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v8 6/9] intel_iommu: use the correct memory region for device IOTLB notification
Date: Thu, 6 Apr 2017 14:57:28 +0300 [thread overview]
Message-ID: <20170406145711-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1491462524-1617-7-git-send-email-peterx@redhat.com>
On Thu, Apr 06, 2017 at 03:08:41PM +0800, Peter Xu wrote:
> From: Jason Wang <jasowang@redhat.com>
>
> We have a specific memory region for DMAR now, so it's wrong to
> trigger the notifier with the root region.
>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> Reviewed-by: Peter Xu <peterx@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/i386/intel_iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
> index 22d8226..2412df4 100644
> --- a/hw/i386/intel_iommu.c
> +++ b/hw/i386/intel_iommu.c
> @@ -1457,7 +1457,7 @@ static bool vtd_process_device_iotlb_desc(IntelIOMMUState *s,
> entry.iova = addr;
> entry.perm = IOMMU_NONE;
> entry.translated_addr = 0;
> - memory_region_notify_iommu(entry.target_as->root, entry);
> + memory_region_notify_iommu(&vtd_dev_as->iommu, entry);
>
> done:
> return true;
> --
> 2.7.4
next prev parent reply other threads:[~2017-04-06 11:57 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 7:08 [Qemu-devel] [PATCH v8 0/9] VT-d: vfio enablement and misc enhances Peter Xu
2017-04-06 7:08 ` [Qemu-devel] [PATCH v8 1/9] memory: add section range info for IOMMU notifier Peter Xu
2017-04-06 10:42 ` Auger Eric
2017-04-06 10:52 ` Peter Xu
2017-04-06 11:54 ` Michael S. Tsirkin
2017-04-06 15:10 ` Alex Williamson
2017-04-06 7:08 ` [Qemu-devel] [PATCH v8 2/9] memory: provide IOMMU_NOTIFIER_FOREACH macro Peter Xu
2017-04-06 10:45 ` Auger Eric
2017-04-06 11:12 ` Peter Xu
2017-04-06 11:30 ` Auger Eric
2017-04-06 11:54 ` Michael S. Tsirkin
2017-04-06 7:08 ` [Qemu-devel] [PATCH v8 3/9] memory: provide iommu_replay_all() Peter Xu
2017-04-06 10:52 ` Auger Eric
2017-04-06 11:46 ` Peter Xu
2017-04-07 4:17 ` Peter Xu
2017-04-06 11:55 ` Michael S. Tsirkin
2017-04-06 7:08 ` [Qemu-devel] [PATCH v8 4/9] memory: introduce memory_region_notify_one() Peter Xu
2017-04-06 10:54 ` Auger Eric
2017-04-06 11:55 ` Michael S. Tsirkin
2017-04-06 7:08 ` [Qemu-devel] [PATCH v8 5/9] memory: add MemoryRegionIOMMUOps.replay() callback Peter Xu
2017-04-06 10:58 ` Auger Eric
2017-04-06 11:57 ` Michael S. Tsirkin
2017-04-06 7:08 ` [Qemu-devel] [PATCH v8 6/9] intel_iommu: use the correct memory region for device IOTLB notification Peter Xu
2017-04-06 11:57 ` Michael S. Tsirkin [this message]
2017-04-06 7:08 ` [Qemu-devel] [PATCH v8 7/9] intel_iommu: provide its own replay() callback Peter Xu
2017-04-06 11:57 ` Michael S. Tsirkin
2017-04-06 7:08 ` [Qemu-devel] [PATCH v8 8/9] intel_iommu: allow dynamic switch of IOMMU region Peter Xu
2017-04-06 11:58 ` Michael S. Tsirkin
2017-04-06 7:08 ` [Qemu-devel] [PATCH v8 9/9] intel_iommu: enable remote IOTLB Peter Xu
2017-04-06 11:58 ` Michael S. Tsirkin
2017-04-06 11:53 ` [Qemu-devel] [PATCH v8 0/9] VT-d: vfio enablement and misc enhances Michael S. Tsirkin
2017-04-06 15:25 ` Peter Xu
2017-04-06 12:00 ` Michael S. Tsirkin
2017-04-06 15:27 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170406145711-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=bd.aviv@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=ehabkost@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=jasowang@redhat.com \
--cc=kevin.tian@intel.com \
--cc=marcel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=tianyu.lan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.