From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932565AbdDFPrM (ORCPT ); Thu, 6 Apr 2017 11:47:12 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:47128 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751662AbdDFPrE (ORCPT ); Thu, 6 Apr 2017 11:47:04 -0400 Date: Thu, 6 Apr 2017 10:46:53 -0500 From: Reza Arbab To: Michal Hocko Cc: linux-mm@kvack.org, Andrew Morton , Mel Gorman , Vlastimil Babka , Andrea Arcangeli , Yasuaki Ishimatsu , Tang Chen , qiuxishi@huawei.com, Kani Toshimitsu , slaoub@gmail.com, Joonsoo Kim , Andi Kleen , Zhang Zhen , David Rientjes , Daniel Kiper , Igor Mammedov , Vitaly Kuznetsov , LKML , Chris Metcalf , Dan Williams , Heiko Carstens , Lai Jiangshan , Martin Schwidefsky Subject: Re: [PATCH 0/6] mm: make movable onlining suck less References: <20170330115454.32154-1-mhocko@kernel.org> <20170406130846.GL5497@dhcp22.suse.cz> <20170406152449.zmghwdb4y6hxn4pm@arbab-laptop> <20170406154127.GQ5497@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20170406154127.GQ5497@dhcp22.suse.cz> Organization: IBM Linux Technology Center User-Agent: NeoMutt/20170306 (1.8.0) X-TM-AS-GCONF: 00 x-cbid: 17040615-0044-0000-0000-000002F9B594 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006888; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000208; SDB=6.00843946; UDB=6.00415894; IPR=6.00622145; BA=6.00005273; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00014937; XFM=3.00000013; UTC=2017-04-06 15:47:01 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17040615-0045-0000-0000-00000727B648 Message-Id: <20170406154653.yv4i2k2r7hjq6mke@arbab-laptop> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-06_13:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=2 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1704060129 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 06, 2017 at 05:41:28PM +0200, Michal Hocko wrote: >On Thu 06-04-17 10:24:49, Reza Arbab wrote: >> On Thu, Apr 06, 2017 at 03:08:46PM +0200, Michal Hocko wrote: >> >OK, so after recent change mostly driven by testing from Reza Arbab >> >(thanks again) I believe I am getting to a working state finally. All I >> >currently have is >> >in git://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git tree >> >attempts/rewrite-mem_hotplug-WIP branch. I will highly appreciate more >> >testing of course and if there are no new issues found I will repost the >> >series for the review. >> >> Looking good! I can do my add/remove/repeat test and things seem fine. >> >> One thing--starting on the second iteration, I am seeing the WARN in >> free_area_init_node(); >> >> add_memory >> add_memory_resource >> hotadd_new_pgdat >> free_area_init_node >> WARN_ON(pgdat->nr_zones || pgdat->kswapd_classzone_idx); > >Have you tested with my attempts/rewrite-mem_hotplug-WIP mentioned >elsewhere? Because I suspect that "mm: get rid of zone_is_initialized" >might cause this. This was my first time using your git branch instead of applying the patches from this thread to v4.11-rc5 myself. -- Reza Arbab From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f70.google.com (mail-pg0-f70.google.com [74.125.83.70]) by kanga.kvack.org (Postfix) with ESMTP id 6DE136B0038 for ; Thu, 6 Apr 2017 11:47:05 -0400 (EDT) Received: by mail-pg0-f70.google.com with SMTP id 68so39951782pgj.23 for ; Thu, 06 Apr 2017 08:47:05 -0700 (PDT) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com. [148.163.156.1]) by mx.google.com with ESMTPS id e9si2209822plk.150.2017.04.06.08.47.04 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Apr 2017 08:47:04 -0700 (PDT) Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v36FdBE1116572 for ; Thu, 6 Apr 2017 11:47:04 -0400 Received: from e18.ny.us.ibm.com (e18.ny.us.ibm.com [129.33.205.208]) by mx0a-001b2d01.pphosted.com with ESMTP id 29nq7wvd10-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 06 Apr 2017 11:47:03 -0400 Received: from localhost by e18.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 6 Apr 2017 11:47:02 -0400 Date: Thu, 6 Apr 2017 10:46:53 -0500 From: Reza Arbab Subject: Re: [PATCH 0/6] mm: make movable onlining suck less References: <20170330115454.32154-1-mhocko@kernel.org> <20170406130846.GL5497@dhcp22.suse.cz> <20170406152449.zmghwdb4y6hxn4pm@arbab-laptop> <20170406154127.GQ5497@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20170406154127.GQ5497@dhcp22.suse.cz> Message-Id: <20170406154653.yv4i2k2r7hjq6mke@arbab-laptop> Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: linux-mm@kvack.org, Andrew Morton , Mel Gorman , Vlastimil Babka , Andrea Arcangeli , Yasuaki Ishimatsu , Tang Chen , qiuxishi@huawei.com, Kani Toshimitsu , slaoub@gmail.com, Joonsoo Kim , Andi Kleen , Zhang Zhen , David Rientjes , Daniel Kiper , Igor Mammedov , Vitaly Kuznetsov , LKML , Chris Metcalf , Dan Williams , Heiko Carstens , Lai Jiangshan , Martin Schwidefsky On Thu, Apr 06, 2017 at 05:41:28PM +0200, Michal Hocko wrote: >On Thu 06-04-17 10:24:49, Reza Arbab wrote: >> On Thu, Apr 06, 2017 at 03:08:46PM +0200, Michal Hocko wrote: >> >OK, so after recent change mostly driven by testing from Reza Arbab >> >(thanks again) I believe I am getting to a working state finally. All I >> >currently have is >> >in git://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git tree >> >attempts/rewrite-mem_hotplug-WIP branch. I will highly appreciate more >> >testing of course and if there are no new issues found I will repost the >> >series for the review. >> >> Looking good! I can do my add/remove/repeat test and things seem fine. >> >> One thing--starting on the second iteration, I am seeing the WARN in >> free_area_init_node(); >> >> add_memory >> add_memory_resource >> hotadd_new_pgdat >> free_area_init_node >> WARN_ON(pgdat->nr_zones || pgdat->kswapd_classzone_idx); > >Have you tested with my attempts/rewrite-mem_hotplug-WIP mentioned >elsewhere? Because I suspect that "mm: get rid of zone_is_initialized" >might cause this. This was my first time using your git branch instead of applying the patches from this thread to v4.11-rc5 myself. -- Reza Arbab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org