From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932977AbdDFXYP (ORCPT ); Thu, 6 Apr 2017 19:24:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43176 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755363AbdDFXXu (ORCPT ); Thu, 6 Apr 2017 19:23:50 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A00E351EE7 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=aarcange@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com A00E351EE7 From: Andrea Arcangeli To: Martin Kepplinger , Thorsten Leemhuis , daniel.vetter@intel.com, Dave Airlie , Chris Wilson Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH 0/5] Re: [Intel-gfx] [BUG][REGRESSION] i915 gpu hangs under load Date: Fri, 7 Apr 2017 01:23:42 +0200 Message-Id: <20170406232347.988-1-aarcange@redhat.com> In-Reply-To: <87pogtplxr.fsf@intel.com> References: <87pogtplxr.fsf@intel.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 06 Apr 2017 23:23:50 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I'm also getting kernel hangs every couple of days. For me it's still not fixed here in 4.11-rc5. It's hard to reproduce, the best reproducer is to build lineageos 14.1 on host while running LTP in a guest to stress the guest VM. Initially I thought it was related to the fact I upgraded the xf86 intel driver just a few weeks ago (I deferred any upgrade of the userland intel driver since last July because of a regression that never got fixed and broke xterm for me). After I found a workaround for the userland regression (appended at the end for reference) I started getting kernel hangs but they are separate issues as far as I can tell. It's not well tested so beware... (it survived a couple of builds and some VM reclaim but that's it). The first patch 1/5 is the potential fix for the i915 kernel hang. The rest are incremental improvements. And I've no great solution for when the shrinker was invoked with the struct_mutex held and and recurse on the lock. I don't think we can possibly wait in such case (other than flush work that the second patch does) but then practically it shouldn't be a big deal, the big RAM eater is unlikely to be i915 when the system is low on memory. Andrea Arcangeli (5): i915: avoid kernel hang caused by synchronize rcu struct_mutex deadlock i915: flush gem obj freeing workqueues to add accuracy to the i915 shrinker i915: initialize the free_list of the fencing atomic_helper i915: schedule while freeing the lists of gem objects i915: fence workqueue optimization drivers/gpu/drm/i915/i915_gem.c | 15 +++++++++++++++ drivers/gpu/drm/i915/i915_gem_shrinker.c | 15 +++++++++++---- drivers/gpu/drm/i915/intel_display.c | 7 ++++--- 3 files changed, 30 insertions(+), 7 deletions(-) === Userland workaround for unusable xterm after commit 3d3d18f086cdda72ee18a454db70ca72c6e3246c (unrelated to this kernel issue, just for reference of what I'm running in userland). diff --git a/src/sna/sna_accel.c b/src/sna/sna_accel.c index 11beb90..d349203 100644 --- a/src/sna/sna_accel.c +++ b/src/sna/sna_accel.c @@ -17430,11 +17430,15 @@ sna_flush_callback(CallbackListPtr *list, pointer user_data, pointer call_data) { struct sna *sna = user_data; +#if 0 if (!sna->needs_dri_flush) return; +#endif sna_accel_flush(sna); +#if 0 sna->needs_dri_flush = false; +#endif } static void From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrea Arcangeli Subject: [PATCH 0/5] Re: [BUG][REGRESSION] i915 gpu hangs under load Date: Fri, 7 Apr 2017 01:23:42 +0200 Message-ID: <20170406232347.988-1-aarcange@redhat.com> References: <87pogtplxr.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <87pogtplxr.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Martin Kepplinger , Thorsten Leemhuis , daniel.vetter@intel.com, Dave Airlie , Chris Wilson Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SSdtIGFsc28gZ2V0dGluZyBrZXJuZWwgaGFuZ3MgZXZlcnkgY291cGxlIG9mIGRheXMuIEZvciBt ZSBpdCdzIHN0aWxsCm5vdCBmaXhlZCBoZXJlIGluIDQuMTEtcmM1LiBJdCdzIGhhcmQgdG8gcmVw cm9kdWNlLCB0aGUgYmVzdApyZXByb2R1Y2VyIGlzIHRvIGJ1aWxkIGxpbmVhZ2VvcyAxNC4xIG9u IGhvc3Qgd2hpbGUgcnVubmluZyBMVFAgaW4gYQpndWVzdCB0byBzdHJlc3MgdGhlIGd1ZXN0IFZN LgoKSW5pdGlhbGx5IEkgdGhvdWdodCBpdCB3YXMgcmVsYXRlZCB0byB0aGUgZmFjdCBJIHVwZ3Jh ZGVkIHRoZSB4Zjg2CmludGVsIGRyaXZlciBqdXN0IGEgZmV3IHdlZWtzIGFnbyAoSSBkZWZlcnJl ZCBhbnkgdXBncmFkZSBvZiB0aGUKdXNlcmxhbmQgaW50ZWwgZHJpdmVyIHNpbmNlIGxhc3QgSnVs eSBiZWNhdXNlIG9mIGEgcmVncmVzc2lvbiB0aGF0Cm5ldmVyIGdvdCBmaXhlZCBhbmQgYnJva2Ug eHRlcm0gZm9yIG1lKS4gQWZ0ZXIgSSBmb3VuZCBhIHdvcmthcm91bmQKZm9yIHRoZSB1c2VybGFu ZCByZWdyZXNzaW9uIChhcHBlbmRlZCBhdCB0aGUgZW5kIGZvciByZWZlcmVuY2UpIEkKc3RhcnRl ZCBnZXR0aW5nIGtlcm5lbCBoYW5ncyBidXQgdGhleSBhcmUgc2VwYXJhdGUgaXNzdWVzIGFzIGZh ciBhcyBJCmNhbiB0ZWxsLgoKSXQncyBub3Qgd2VsbCB0ZXN0ZWQgc28gYmV3YXJlLi4uIChpdCBz dXJ2aXZlZCBhIGNvdXBsZSBvZiBidWlsZHMgYW5kCnNvbWUgVk0gcmVjbGFpbSBidXQgdGhhdCdz IGl0KS4KClRoZSBmaXJzdCBwYXRjaCAxLzUgaXMgdGhlIHBvdGVudGlhbCBmaXggZm9yIHRoZSBp OTE1IGtlcm5lbCBoYW5nLiBUaGUKcmVzdCBhcmUgaW5jcmVtZW50YWwgaW1wcm92ZW1lbnRzLgoK QW5kIEkndmUgbm8gZ3JlYXQgc29sdXRpb24gZm9yIHdoZW4gdGhlIHNocmlua2VyIHdhcyBpbnZv a2VkIHdpdGggdGhlCnN0cnVjdF9tdXRleCBoZWxkIGFuZCBhbmQgcmVjdXJzZSBvbiB0aGUgbG9j ay4gSSBkb24ndCB0aGluayB3ZSBjYW4KcG9zc2libHkgd2FpdCBpbiBzdWNoIGNhc2UgKG90aGVy IHRoYW4gZmx1c2ggd29yayB0aGF0IHRoZSBzZWNvbmQKcGF0Y2ggZG9lcykgYnV0IHRoZW4gcHJh Y3RpY2FsbHkgaXQgc2hvdWxkbid0IGJlIGEgYmlnIGRlYWwsIHRoZSBiaWcKUkFNIGVhdGVyIGlz IHVubGlrZWx5IHRvIGJlIGk5MTUgd2hlbiB0aGUgc3lzdGVtIGlzIGxvdyBvbiBtZW1vcnkuCgpB bmRyZWEgQXJjYW5nZWxpICg1KToKICBpOTE1OiBhdm9pZCBrZXJuZWwgaGFuZyBjYXVzZWQgYnkg c3luY2hyb25pemUgcmN1IHN0cnVjdF9tdXRleAogICAgZGVhZGxvY2sKICBpOTE1OiBmbHVzaCBn ZW0gb2JqIGZyZWVpbmcgd29ya3F1ZXVlcyB0byBhZGQgYWNjdXJhY3kgdG8gdGhlIGk5MTUKICAg IHNocmlua2VyCiAgaTkxNTogaW5pdGlhbGl6ZSB0aGUgZnJlZV9saXN0IG9mIHRoZSBmZW5jaW5n IGF0b21pY19oZWxwZXIKICBpOTE1OiBzY2hlZHVsZSB3aGlsZSBmcmVlaW5nIHRoZSBsaXN0cyBv ZiBnZW0gb2JqZWN0cwogIGk5MTU6IGZlbmNlIHdvcmtxdWV1ZSBvcHRpbWl6YXRpb24KCiBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jICAgICAgICAgIHwgMTUgKysrKysrKysrKysrKysr CiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9zaHJpbmtlci5jIHwgMTUgKysrKysrKysr KystLS0tCiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgICAgIHwgIDcgKysr Ky0tLQogMyBmaWxlcyBjaGFuZ2VkLCAzMCBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQoK PT09ClVzZXJsYW5kIHdvcmthcm91bmQgZm9yIHVudXNhYmxlIHh0ZXJtIGFmdGVyIGNvbW1pdAoz ZDNkMThmMDg2Y2RkYTcyZWUxOGE0NTRkYjcwY2E3MmM2ZTMyNDZjICh1bnJlbGF0ZWQgdG8gdGhp cyBrZXJuZWwKaXNzdWUsIGp1c3QgZm9yIHJlZmVyZW5jZSBvZiB3aGF0IEknbSBydW5uaW5nIGlu IHVzZXJsYW5kKS4KCmRpZmYgLS1naXQgYS9zcmMvc25hL3NuYV9hY2NlbC5jIGIvc3JjL3NuYS9z bmFfYWNjZWwuYwppbmRleCAxMWJlYjkwLi5kMzQ5MjAzIDEwMDY0NAotLS0gYS9zcmMvc25hL3Nu YV9hY2NlbC5jCisrKyBiL3NyYy9zbmEvc25hX2FjY2VsLmMKQEAgLTE3NDMwLDExICsxNzQzMCwx NSBAQCBzbmFfZmx1c2hfY2FsbGJhY2soQ2FsbGJhY2tMaXN0UHRyICpsaXN0LCBwb2ludGVyIHVz ZXJfZGF0YSwgcG9pbnRlciBjYWxsX2RhdGEpCiB7CiAJc3RydWN0IHNuYSAqc25hID0gdXNlcl9k YXRhOwogCisjaWYgMAogCWlmICghc25hLT5uZWVkc19kcmlfZmx1c2gpCiAJCXJldHVybjsKKyNl bmRpZgogCiAJc25hX2FjY2VsX2ZsdXNoKHNuYSk7CisjaWYgMAogCXNuYS0+bmVlZHNfZHJpX2Zs dXNoID0gZmFsc2U7CisjZW5kaWYKIH0KIAogc3RhdGljIHZvaWQKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50 ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=