From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Keepax Subject: Re: [PATCH 01/16] mfd: madera: Add register definitions for Cirrus Logic Madera codecs Date: Fri, 7 Apr 2017 09:48:23 +0100 Message-ID: <20170407084823.GB3412@localhost.localdomain> References: <1491386884-30689-1-git-send-email-rf@opensource.wolfsonmicro.com> <1491386884-30689-2-git-send-email-rf@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:39160 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754556AbdDGIrb (ORCPT ); Fri, 7 Apr 2017 04:47:31 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Linus Walleij Cc: Richard Fitzgerald , Alexandre Courbot , Rob Herring , Thomas Gleixner , Jason Cooper , Lee Jones , Mark Brown , "alsa-devel@alsa-project.org" , "open list:WOLFSON MICROELECTRONICS DRIVERS" , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" On Fri, Apr 07, 2017 at 10:30:12AM +0200, Linus Walleij wrote: > On Fri, Apr 7, 2017 at 10:27 AM, Linus Walleij wrote: > > On Wed, Apr 5, 2017 at 12:07 PM, Richard Fitzgerald > > wrote: > > > >> This patch adds a header file of register definitions for Cirrus > >> Logic "Madera" class codecs. These codecs are all based off a common > >> set of hardware IP so have a common register map (with a few minor > >> device-to-device variations). These are complex devices with a large > >> mber of features and so have a correspondingly large register set. > >> The registers.h file has been auto-generated from the hardware register > >> definitions, stripped down to only registers we need to access from > >> the driver. > >> > >> Signed-off-by: Richard Fitzgerald > > > > This: > > include/linux/mfd/madera/registers.h | 8832 ++++++++++++++++++++++++++++++++++ > > > > Get included in all subdrivers I suppose? > > > > So you are broadcasting 8800+ lines into every subdriver across the > > entire kernel. > > > > Just the time spent in the preprocessor parsing this will affect compilation > > time. > > Or maybe this is a necessary sacrifice to get the regmap cache > centralized in MFD. I don't know. I feel stupid. > > I guess I should focus on "my" subsystems... > This only gets included in files that are part of this driver, it shouldn't affect compilation time for anyone not building the madera driver and even then it should only affect compilation times for the 10 or so C files that make up the driver. Also I don't really see any other way to specify the registers for the device. Thanks, Charles From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756008AbdDGIrs (ORCPT ); Fri, 7 Apr 2017 04:47:48 -0400 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:39160 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754556AbdDGIrb (ORCPT ); Fri, 7 Apr 2017 04:47:31 -0400 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.wolfsonmicro.com Date: Fri, 7 Apr 2017 09:48:23 +0100 From: Charles Keepax To: Linus Walleij CC: Richard Fitzgerald , Alexandre Courbot , Rob Herring , Thomas Gleixner , Jason Cooper , Lee Jones , Mark Brown , "alsa-devel@alsa-project.org" , "open list:WOLFSON MICROELECTRONICS DRIVERS" , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 01/16] mfd: madera: Add register definitions for Cirrus Logic Madera codecs Message-ID: <20170407084823.GB3412@localhost.localdomain> References: <1491386884-30689-1-git-send-email-rf@opensource.wolfsonmicro.com> <1491386884-30689-2-git-send-email-rf@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1704070076 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 07, 2017 at 10:30:12AM +0200, Linus Walleij wrote: > On Fri, Apr 7, 2017 at 10:27 AM, Linus Walleij wrote: > > On Wed, Apr 5, 2017 at 12:07 PM, Richard Fitzgerald > > wrote: > > > >> This patch adds a header file of register definitions for Cirrus > >> Logic "Madera" class codecs. These codecs are all based off a common > >> set of hardware IP so have a common register map (with a few minor > >> device-to-device variations). These are complex devices with a large > >> mber of features and so have a correspondingly large register set. > >> The registers.h file has been auto-generated from the hardware register > >> definitions, stripped down to only registers we need to access from > >> the driver. > >> > >> Signed-off-by: Richard Fitzgerald > > > > This: > > include/linux/mfd/madera/registers.h | 8832 ++++++++++++++++++++++++++++++++++ > > > > Get included in all subdrivers I suppose? > > > > So you are broadcasting 8800+ lines into every subdriver across the > > entire kernel. > > > > Just the time spent in the preprocessor parsing this will affect compilation > > time. > > Or maybe this is a necessary sacrifice to get the regmap cache > centralized in MFD. I don't know. I feel stupid. > > I guess I should focus on "my" subsystems... > This only gets included in files that are part of this driver, it shouldn't affect compilation time for anyone not building the madera driver and even then it should only affect compilation times for the 10 or so C files that make up the driver. Also I don't really see any other way to specify the registers for the device. Thanks, Charles