From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 01/16] mfd: madera: Add register definitions for Cirrus Logic Madera codecs Date: Fri, 7 Apr 2017 12:14:58 +0100 Message-ID: <20170407111458.vw7oxemasqhcfepq@sirena.org.uk> References: <1491386884-30689-1-git-send-email-rf@opensource.wolfsonmicro.com> <1491386884-30689-2-git-send-email-rf@opensource.wolfsonmicro.com> <20170407084823.GB3412@localhost.localdomain> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="k4nxp35gqq27j42m" Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Linus Walleij Cc: Charles Keepax , Richard Fitzgerald , Alexandre Courbot , Rob Herring , Thomas Gleixner , Jason Cooper , Lee Jones , "alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org" , "open list:WOLFSON MICROELECTRONICS DRIVERS" , "linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-gpio@vger.kernel.org --k4nxp35gqq27j42m Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Apr 07, 2017 at 11:12:53AM +0200, Linus Walleij wrote: > On Fri, Apr 7, 2017 at 10:48 AM, Charles Keepax > > On Fri, Apr 07, 2017 at 10:30:12AM +0200, Linus Walleij wrote: > >> > Get included in all subdrivers I suppose? > >> > So you are broadcasting 8800+ lines into every subdriver across the > >> > entire kernel. > >> > Just the time spent in the preprocessor parsing this will affect compilation > >> > time. > >> Or maybe this is a necessary sacrifice to get the regmap cache > >> centralized in MFD. I don't know. I feel stupid. > >> I guess I should focus on "my" subsystems... > > This only gets included in files that are part of this driver, it > > shouldn't affect compilation time for anyone not building the > > madera driver and even then it should only affect compilation > > times for the 10 or so C files that make up the driver. Also I > > don't really see any other way to specify the registers for the > > device. > No when using regmap cache this seems necessary. > I was just wrong. Right. The other thing to bear in mind with things like this is that often if it's the chip vendor they've got mechanisms to generate the register definitions directly from the chip design so if we take the complete thing with minimal edits it's a great way of ensuring we've got information about the chip in the upstream kernel to support future development. --k4nxp35gqq27j42m Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAljndK4ACgkQJNaLcl1U h9AcrQf/fG+V7Yqvtyj+A9tD0Pa38YObImkcpc/f14hebTVi+wnwaAb31NfjLeZx MTN45CwPQBj80UhTFhFaYKeOOPAmtmH7QWr0PqW33f99e/Qcvv2nyQOTaw6Mqef8 p8JwoPBdrejXb+sftbbMhMt1Ti6ZIOGvV/v64REmHwxNp/nL5DkiqjEjHD2DgoKl ZrE4ayBB5w6YQgaWruaEuTEJQRL5R3HK9v8AyFtdY12iMlTsd+UTevqoJmi0vrLW hx2AdajwjehAC/n8rSY9vE+Gc+KAKcEHjYCNVWClP4hQ1y4vecVE6/bLsKDlze9C RTA+TF7mDZWi2Vokx9b+JqAZXk4NaQ== =4XT0 -----END PGP SIGNATURE----- --k4nxp35gqq27j42m-- -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755388AbdDGLP2 (ORCPT ); Fri, 7 Apr 2017 07:15:28 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:41410 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753883AbdDGLPT (ORCPT ); Fri, 7 Apr 2017 07:15:19 -0400 Date: Fri, 7 Apr 2017 12:14:58 +0100 From: Mark Brown To: Linus Walleij Cc: Charles Keepax , Richard Fitzgerald , Alexandre Courbot , Rob Herring , Thomas Gleixner , Jason Cooper , Lee Jones , "alsa-devel@alsa-project.org" , "open list:WOLFSON MICROELECTRONICS DRIVERS" , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Message-ID: <20170407111458.vw7oxemasqhcfepq@sirena.org.uk> References: <1491386884-30689-1-git-send-email-rf@opensource.wolfsonmicro.com> <1491386884-30689-2-git-send-email-rf@opensource.wolfsonmicro.com> <20170407084823.GB3412@localhost.localdomain> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="k4nxp35gqq27j42m" Content-Disposition: inline In-Reply-To: X-Cookie: Kleeneness is next to Godelness. User-Agent: NeoMutt/20170306 (1.8.0) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 01/16] mfd: madera: Add register definitions for Cirrus Logic Madera codecs X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --k4nxp35gqq27j42m Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Apr 07, 2017 at 11:12:53AM +0200, Linus Walleij wrote: > On Fri, Apr 7, 2017 at 10:48 AM, Charles Keepax > > On Fri, Apr 07, 2017 at 10:30:12AM +0200, Linus Walleij wrote: > >> > Get included in all subdrivers I suppose? > >> > So you are broadcasting 8800+ lines into every subdriver across the > >> > entire kernel. > >> > Just the time spent in the preprocessor parsing this will affect compilation > >> > time. > >> Or maybe this is a necessary sacrifice to get the regmap cache > >> centralized in MFD. I don't know. I feel stupid. > >> I guess I should focus on "my" subsystems... > > This only gets included in files that are part of this driver, it > > shouldn't affect compilation time for anyone not building the > > madera driver and even then it should only affect compilation > > times for the 10 or so C files that make up the driver. Also I > > don't really see any other way to specify the registers for the > > device. > No when using regmap cache this seems necessary. > I was just wrong. Right. The other thing to bear in mind with things like this is that often if it's the chip vendor they've got mechanisms to generate the register definitions directly from the chip design so if we take the complete thing with minimal edits it's a great way of ensuring we've got information about the chip in the upstream kernel to support future development. --k4nxp35gqq27j42m Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAljndK4ACgkQJNaLcl1U h9AcrQf/fG+V7Yqvtyj+A9tD0Pa38YObImkcpc/f14hebTVi+wnwaAb31NfjLeZx MTN45CwPQBj80UhTFhFaYKeOOPAmtmH7QWr0PqW33f99e/Qcvv2nyQOTaw6Mqef8 p8JwoPBdrejXb+sftbbMhMt1Ti6ZIOGvV/v64REmHwxNp/nL5DkiqjEjHD2DgoKl ZrE4ayBB5w6YQgaWruaEuTEJQRL5R3HK9v8AyFtdY12iMlTsd+UTevqoJmi0vrLW hx2AdajwjehAC/n8rSY9vE+Gc+KAKcEHjYCNVWClP4hQ1y4vecVE6/bLsKDlze9C RTA+TF7mDZWi2Vokx9b+JqAZXk4NaQ== =4XT0 -----END PGP SIGNATURE----- --k4nxp35gqq27j42m--