From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756514AbdDGOT5 (ORCPT ); Fri, 7 Apr 2017 10:19:57 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:49695 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756298AbdDGOTe (ORCPT ); Fri, 7 Apr 2017 10:19:34 -0400 Date: Fri, 7 Apr 2017 16:19:25 +0200 From: Andrew Lunn To: Juergen Borleis Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, f.fainelli@gmail.com, kernel@pengutronix.de, vivien.didelot@savoirfairelinux.com, davem@davemloft.net Subject: Re: [PATCH v2 4/4] net: dsa: LAN9303: add MDIO managed mode support Message-ID: <20170407141925.GB23415@lunn.ch> References: <20170407081502.30172-1-jbe@pengutronix.de> <20170407081502.30172-5-jbe@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170407081502.30172-5-jbe@pengutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +static const struct of_device_id lan9303_mdio_of_match[] = { > + { .compatible = "smsc,lan9303" }, > + { /* sentinel */ }, > +}; We still have the open question of is it a problem to have two different drivers using the same compatible string. Changing these strings is hard, once they are in use, so i would prefer to get this answered before the code is accepted. Andrew