From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933982AbdDGOpS (ORCPT ); Fri, 7 Apr 2017 10:45:18 -0400 Received: from mx2.suse.de ([195.135.220.15]:47392 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755611AbdDGOpJ (ORCPT ); Fri, 7 Apr 2017 10:45:09 -0400 Date: Fri, 7 Apr 2017 16:45:04 +0200 From: Michal Hocko To: Jerome Glisse Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, John Hubbard , Dan Williams , Naoya Horiguchi , David Nellans , Russell King , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Martin Schwidefsky , Heiko Carstens , Yoshinori Sato , Rich Felker , Chris Metcalf , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" Subject: Re: [HMM 01/16] mm/memory/hotplug: add memory type parameter to arch_add/remove_memory Message-ID: <20170407144504.GG16413@dhcp22.suse.cz> References: <20170405204026.3940-1-jglisse@redhat.com> <20170405204026.3940-2-jglisse@redhat.com> <20170407121349.GB16392@dhcp22.suse.cz> <20170407143246.GA15098@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170407143246.GA15098@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 07-04-17 10:32:49, Jerome Glisse wrote: > On Fri, Apr 07, 2017 at 02:13:49PM +0200, Michal Hocko wrote: > > On Wed 05-04-17 16:40:11, Jérôme Glisse wrote: > > > When hotpluging memory we want more information on the type of memory. > > > This is to extend ZONE_DEVICE to support new type of memory other than > > > the persistent memory. Existing user of ZONE_DEVICE (persistent memory) > > > will be left un-modified. > > > > My current hotplug rework [1] is touching this path as well. It is not > > really clear from the chage why you are changing this and what are the > > further expectations of MEMORY_DEVICE_PERSISTENT. Infact I have replaced > > for_device with want__memblock [2]. I plan to repost shortly but I would > > like to understand your modifications more to reduce potential conflicts > > in the code. Why do you need to distinguish different types of memory > > anyway. > > > > [1] http://lkml.kernel.org/r/20170330115454.32154-1-mhocko@kernel.org > > [2] the current patchset is in git://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git > > branch attempts/rewrite-mem_hotplug-WIP > > This is needed for UNADDRESSABLE memory type introduced in patch 3 and > the arch specific bits are in patch 4. Basicly for UNADDRESSABLE memory > i do not want the arch code to create a linear mapping for the range > being hotpluged. Adding memory_type in this patch allow to distinguish > between different type of ZONE_DEVICE. Why don't you use __add_pages directly then? -- Michal Hocko SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f198.google.com (mail-wr0-f198.google.com [209.85.128.198]) by kanga.kvack.org (Postfix) with ESMTP id 288866B0038 for ; Fri, 7 Apr 2017 10:45:10 -0400 (EDT) Received: by mail-wr0-f198.google.com with SMTP id z109so10756800wrb.1 for ; Fri, 07 Apr 2017 07:45:10 -0700 (PDT) Received: from mx2.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id s126si5087445wmd.156.2017.04.07.07.45.08 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 07 Apr 2017 07:45:08 -0700 (PDT) Date: Fri, 7 Apr 2017 16:45:04 +0200 From: Michal Hocko Subject: Re: [HMM 01/16] mm/memory/hotplug: add memory type parameter to arch_add/remove_memory Message-ID: <20170407144504.GG16413@dhcp22.suse.cz> References: <20170405204026.3940-1-jglisse@redhat.com> <20170405204026.3940-2-jglisse@redhat.com> <20170407121349.GB16392@dhcp22.suse.cz> <20170407143246.GA15098@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170407143246.GA15098@redhat.com> Sender: owner-linux-mm@kvack.org List-ID: To: Jerome Glisse Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, John Hubbard , Dan Williams , Naoya Horiguchi , David Nellans , Russell King , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Martin Schwidefsky , Heiko Carstens , Yoshinori Sato , Rich Felker , Chris Metcalf , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" On Fri 07-04-17 10:32:49, Jerome Glisse wrote: > On Fri, Apr 07, 2017 at 02:13:49PM +0200, Michal Hocko wrote: > > On Wed 05-04-17 16:40:11, Jerome Glisse wrote: > > > When hotpluging memory we want more information on the type of memory. > > > This is to extend ZONE_DEVICE to support new type of memory other than > > > the persistent memory. Existing user of ZONE_DEVICE (persistent memory) > > > will be left un-modified. > > > > My current hotplug rework [1] is touching this path as well. It is not > > really clear from the chage why you are changing this and what are the > > further expectations of MEMORY_DEVICE_PERSISTENT. Infact I have replaced > > for_device with want__memblock [2]. I plan to repost shortly but I would > > like to understand your modifications more to reduce potential conflicts > > in the code. Why do you need to distinguish different types of memory > > anyway. > > > > [1] http://lkml.kernel.org/r/20170330115454.32154-1-mhocko@kernel.org > > [2] the current patchset is in git://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git > > branch attempts/rewrite-mem_hotplug-WIP > > This is needed for UNADDRESSABLE memory type introduced in patch 3 and > the arch specific bits are in patch 4. Basicly for UNADDRESSABLE memory > i do not want the arch code to create a linear mapping for the range > being hotpluged. Adding memory_type in this patch allow to distinguish > between different type of ZONE_DEVICE. Why don't you use __add_pages directly then? -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org