From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/vmwgfx: Fix fbdev emulation using legacy functions Date: Fri, 7 Apr 2017 16:54:45 +0200 Message-ID: <20170407145445.khxwsdt2lh5bssox@phenom.ffwll.local> References: <20170406200256.26040-1-daniel.vetter@ffwll.ch> <8066e023-e77c-e618-8e78-3edf2565a44e@vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3B3656EB82 for ; Fri, 7 Apr 2017 14:54:50 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id x75so1849614wma.1 for ; Fri, 07 Apr 2017 07:54:50 -0700 (PDT) Content-Disposition: inline In-Reply-To: <8066e023-e77c-e618-8e78-3edf2565a44e@vmware.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thomas Hellstrom Cc: Daniel Vetter , DRI Development , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBBcHIgMDcsIDIwMTcgYXQgMTA6MzE6MjlBTSArMDIwMCwgVGhvbWFzIEhlbGxzdHJv bSB3cm90ZToKPiBIaSwgRGFuaWVsLgo+IAo+IEl0IGFwcGVhcnMgdG8gd29yayBmaW5lLiBUaGFu a3MhCgpPaCBzd2VldCwgdGJoIEkgZGlkbid0IGV4cGVjdCB0aGlzIGtpbmQgb2YgYmxpbmQgdHlw aW5nIHdpdGhvdXQgYSBjbGVhcgp0aGVvcnkgdG8gd29yayBvdXQgc28gd2VsbCA6LSkgRGlkIHlv dSB0ZXN0IHRoaXMgd2l0aApDT05GSUdfREVCVUdfV1dfTVVURVhfU0xPV1BBVEg/IEp1c3QgdG8g bWFrZSBzdXJlIEkgZGlkbid0IGJvdGNoIHVwIHRoZQpyZXRyeSBwYXRoLgoKPiBEbyB5b3Ugd2Fu dCB0byB0YWtlIGl0IHRocm91Z2ggZHJtLW1pc2Mgb3Igd2FudCBtZSB0byB0YWtlIGl0IHRocm91 Y2gKPiB2bXdnZngtbmV4dD8KClNlYW4gd2lsbCBwaWNrIGl0IHVwIGJlZm9yZSBoZSBkb2VzIHRo ZSBmaW5hbCA0LjEyIC1taXNjIHB1bGwgbGF0ZXIgdG9kYXksCnNvIHRoYXQgdGhpcyB2bXdnZngg cmVncmVzc2lvbiBpcyByZXNvbHZlZC4KCj4gUmV2aWV3ZWQtYnk6IFRob21hcyBIZWxsc3Ryb20g PHRoZWxsc3Ryb21Adm13YXJlLmNvbT4KClRoYW5rcyBmb3IgdGVzdGluZyZyZXZpZXcuCi1EYW5p ZWwKCj4gL1Rob21hcwo+IAo+IAo+IAo+IE9uIDA0LzA2LzIwMTcgMTA6MDIgUE0sIERhbmllbCBW ZXR0ZXIgd3JvdGU6Cj4gPiBJJ3ZlIGJyb2tlbiB0aGlzIGJ5IHJlbW92aW5nIHRoZSBiYWNrb2Zm IGhhbmRsaW5nIGZyb20gdGhlCj4gPiBzZXRfY29uZmlnMmF0b21pYyBoZWxwZXIgaW4KPiA+Cj4g PiBjb21taXQgMzhiNjQ0MWU0ZTc1YzBiMzE5Y2ZlNGQ5MzY0YzEwNTlmYzFlM2MyYgo+ID4gQXV0 aG9yOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+ID4gRGF0ZTogICBX ZWQgTWFyIDIyIDIyOjUwOjU4IDIwMTcgKzAxMDAKPiA+Cj4gPiAgICAgZHJtL2F0b21pYy1oZWxw ZXI6IFJlbW92ZSB0aGUgYmFja29mZiBoYWNrIGZyb20gc2V0X2NvbmZpZwo+ID4KPiA+IEZpeGlu ZyB0aGlzIHByb3Blcmx5IHdvdWxkIG1lYW4gd2UgZ2V0IHRvIHdpcmUgdGhlIGFjcXVpcmVfY3R4 IGFsbCB0aGUKPiA+IHdheSB0aHJvdWdoIHZtd2dmeCBmYmRldiBjb2RlLCBhbmQgZG9pbmcgdGhl IHNhbWUgd2FzIHRyaWNreSBmb3IgdGhlCj4gPiBzaGFyZWQgZmJkZXYgbGF5ZXIuIFByb2JhYmx5 IG11Y2ggYmV0dGVyIHRvIGxvb2sgaW50byByZWZhY3RvcmluZyB0aGUKPiA+IGVudGlyZSBjb2Rl IHRvIHVzZSB0aGUgaGVscGVycywgYnV0IHNpbmNlIHRoYXQncyBub3QgYSB2aWFibGUKPiA+IGxv bmctdGVybSBzb2x1dGlvbiBmaXggdGhlIGlzc3VlIGJ5IG9wZW4tY29kaW5nIGEgdm13Z2Z4IHZl cnNpb24gb2YKPiA+IHNldF9jb25maWcsIHRoYXQgZG9lcyB0aGUgbGVnYWN5IGJhY2tvZmYgZGFu Y2UgaW50ZXJuYWxseS4KPiA+Cj4gPiBOb3RlOiBKdXN0IGNvbXBpbGUtdGVzdGVkLiBUaGUgaWRl YSBpcyB0byB0YWtlCj4gPiBkcm1fbW9kZV9zZXRfY29uZmlnX2ludGVybmFsKCksIHJlbW92ZSB0 aGUgImlzIHRoaXMgYSBsZWdhY3kgZHJpdmVyIgo+ID4gY2hlY2ssIGFuZCB3aGFjayB0aGUgZHJt X2F0b21pY19sZWdhY3lfYmFja29mZiB0cmlja2VyeSBhdCB0aGUgZW5kLgo+ID4gU2luY2UgZHJt X2F0b21pY19sZWdhY3lfYmFja29mZiBpcyBmb3IgYXRvbWljIGNvbW1pdHMgb25seSB3ZSBuZWVk IHRvCj4gPiBvcGVuLWNvZGUgaXQuCj4gPgo+ID4gQ2M6IFRob21hcyBIZWxsc3Ryb20gPHRoZWxs c3Ryb21Adm13YXJlLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmll bC52ZXR0ZXJAaW50ZWwuY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92 bXdnZnhfZmIuYyB8IDU4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tCj4g PiAgMSBmaWxlIGNoYW5nZWQsIDU2IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gPgo+ ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS92bXdnZngvdm13Z2Z4X2ZiLmMgYi9kcml2 ZXJzL2dwdS9kcm0vdm13Z2Z4L3Ztd2dmeF9mYi5jCj4gPiBpbmRleCAwOWUxMjBkNTBlNjUuLjZm NGNiNDY3OGNiYyAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS92bXdnZngvdm13Z2Z4 X2ZiLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS92bXdnZngvdm13Z2Z4X2ZiLmMKPiA+IEBA IC00MTgsNiArNDE4LDYwIEBAIHN0YXRpYyBpbnQgdm13X2ZiX2NvbXB1dGVfZGVwdGgoc3RydWN0 IGZiX3Zhcl9zY3JlZW5pbmZvICp2YXIsCj4gPiAgCXJldHVybiAwOwo+ID4gIH0KPiA+ICAKPiA+ ICtzdGF0aWMgaW50IHZtd2dmeF9zZXRfY29uZmlnX2ludGVybmFsKHN0cnVjdCBkcm1fbW9kZV9z ZXQgKnNldCkKPiA+ICt7Cj4gPiArCXN0cnVjdCBkcm1fY3J0YyAqY3J0YyA9IHNldC0+Y3J0YzsK PiA+ICsJc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmI7Cj4gPiArCXN0cnVjdCBkcm1fY3J0YyAq dG1wOwo+ID4gKwlzdHJ1Y3QgZHJtX21vZGVzZXRfYWNxdWlyZV9jdHggKmN0eDsKPiA+ICsJc3Ry dWN0IGRybV9kZXZpY2UgKmRldiA9IHNldC0+Y3J0Yy0+ZGV2Owo+ID4gKwlpbnQgcmV0Owo+ID4g Kwo+ID4gKwljdHggPSBkZXYtPm1vZGVfY29uZmlnLmFjcXVpcmVfY3R4Owo+ID4gKwo+ID4gK3Jl c3RhcnQ6Cj4gPiArCS8qCj4gPiArCSAqIE5PVEU6IC0+c2V0X2NvbmZpZyBjYW4gYWxzbyBkaXNh YmxlIG90aGVyIGNydGNzIChpZiB3ZSBzdGVhbCBhbGwKPiA+ICsJICogY29ubmVjdG9ycyBmcm9t IGl0KSwgaGVuY2Ugd2UgbmVlZCB0byByZWZjb3VudCB0aGUgZmJzIGFjcm9zcyBhbGwKPiA+ICsJ ICogY3J0Y3MuIEF0b21pYyBtb2Rlc2V0IHdpbGwgaGF2ZSBzYW5lciBzZW1hbnRpY3MgLi4uCj4g PiArCSAqLwo+ID4gKwlkcm1fZm9yX2VhY2hfY3J0Yyh0bXAsIGRldikKPiA+ICsJCXRtcC0+cHJp bWFyeS0+b2xkX2ZiID0gdG1wLT5wcmltYXJ5LT5mYjsKPiA+ICsKPiA+ICsJZmIgPSBzZXQtPmZi Owo+ID4gKwo+ID4gKwlyZXQgPSBjcnRjLT5mdW5jcy0+c2V0X2NvbmZpZyhzZXQsIGN0eCk7Cj4g PiArCWlmIChyZXQgPT0gMCkgewo+ID4gKwkJY3J0Yy0+cHJpbWFyeS0+Y3J0YyA9IGNydGM7Cj4g PiArCQljcnRjLT5wcmltYXJ5LT5mYiA9IGZiOwo+ID4gKwl9Cj4gPiArCj4gPiArCWRybV9mb3Jf ZWFjaF9jcnRjKHRtcCwgZGV2KSB7Cj4gPiArCQlpZiAodG1wLT5wcmltYXJ5LT5mYikKPiA+ICsJ CQlkcm1fZnJhbWVidWZmZXJfZ2V0KHRtcC0+cHJpbWFyeS0+ZmIpOwo+ID4gKwkJaWYgKHRtcC0+ cHJpbWFyeS0+b2xkX2ZiKQo+ID4gKwkJCWRybV9mcmFtZWJ1ZmZlcl9wdXQodG1wLT5wcmltYXJ5 LT5vbGRfZmIpOwo+ID4gKwkJdG1wLT5wcmltYXJ5LT5vbGRfZmIgPSBOVUxMOwo+ID4gKwl9Cj4g PiArCj4gPiArCWlmIChyZXQgPT0gLUVERUFETEspIHsKPiA+ICsJCWRldi0+bW9kZV9jb25maWcu YWNxdWlyZV9jdHggPSBOVUxMOwo+ID4gKwo+ID4gK3JldHJ5X2xvY2tpbmc6Cj4gPiArCQlkcm1f bW9kZXNldF9iYWNrb2ZmKGN0eCk7Cj4gPiArCj4gPiArCQlyZXQgPSBkcm1fbW9kZXNldF9sb2Nr X2FsbF9jdHgoZGV2LCBjdHgpOwo+ID4gKwkJaWYgKHJldCkKPiA+ICsJCQlnb3RvIHJldHJ5X2xv Y2tpbmc7Cj4gPiArCj4gPiArCQlkZXYtPm1vZGVfY29uZmlnLmFjcXVpcmVfY3R4ID0gY3R4Owo+ ID4gKwo+ID4gKwkJZ290byByZXN0YXJ0Owo+ID4gKwl9Cj4gPiArCj4gPiArCXJldHVybiByZXQ7 Cj4gPiArfQo+ID4gKwo+ID4gIHN0YXRpYyBpbnQgdm13X2ZiX2ttc19kZXRhY2goc3RydWN0IHZt d19mYl9wYXIgKnBhciwKPiA+ICAJCQkgICAgIGJvb2wgZGV0YWNoX2JvLAo+ID4gIAkJCSAgICAg Ym9vbCB1bnJlZl9ibykKPiA+IEBAIC00MzYsNyArNDkwLDcgQEAgc3RhdGljIGludCB2bXdfZmJf a21zX2RldGFjaChzdHJ1Y3Qgdm13X2ZiX3BhciAqcGFyLAo+ID4gIAkJc2V0LmZiID0gTlVMTDsK PiA+ICAJCXNldC5udW1fY29ubmVjdG9ycyA9IDA7Cj4gPiAgCQlzZXQuY29ubmVjdG9ycyA9ICZw YXItPmNvbjsKPiA+IC0JCXJldCA9IGRybV9tb2RlX3NldF9jb25maWdfaW50ZXJuYWwoJnNldCk7 Cj4gPiArCQlyZXQgPSB2bXdnZnhfc2V0X2NvbmZpZ19pbnRlcm5hbCgmc2V0KTsKPiA+ICAJCWlm IChyZXQpIHsKPiA+ICAJCQlEUk1fRVJST1IoIkNvdWxkIG5vdCB1bnNldCBhIG1vZGUuXG4iKTsK PiA+ICAJCQlyZXR1cm4gcmV0Owo+ID4gQEAgLTU3OCw3ICs2MzIsNyBAQCBzdGF0aWMgaW50IHZt d19mYl9zZXRfcGFyKHN0cnVjdCBmYl9pbmZvICppbmZvKQo+ID4gIAlzZXQubnVtX2Nvbm5lY3Rv cnMgPSAxOwo+ID4gIAlzZXQuY29ubmVjdG9ycyA9ICZwYXItPmNvbjsKPiA+ICAKPiA+IC0JcmV0 ID0gZHJtX21vZGVfc2V0X2NvbmZpZ19pbnRlcm5hbCgmc2V0KTsKPiA+ICsJcmV0ID0gdm13Z2Z4 X3NldF9jb25maWdfaW50ZXJuYWwoJnNldCk7Cj4gPiAgCWlmIChyZXQpCj4gPiAgCQlnb3RvIG91 dF91bmxvY2s7Cj4gPiAgCj4gCj4gCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVl ciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==