From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934208AbdDGPX1 (ORCPT ); Fri, 7 Apr 2017 11:23:27 -0400 Received: from merlin.infradead.org ([205.233.59.134]:59588 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932913AbdDGPXU (ORCPT ); Fri, 7 Apr 2017 11:23:20 -0400 Date: Fri, 7 Apr 2017 17:23:04 +0200 From: Peter Zijlstra To: Sergey Senozhatsky Cc: Pavel Machek , Sergey Senozhatsky , Jan Kara , "Eric W. Biederman" , Ye Xiaolong , Steven Rostedt , Petr Mladek , Andrew Morton , Linus Torvalds , "Rafael J . Wysocki" , Greg Kroah-Hartman , Jiri Slaby , Len Brown , linux-kernel@vger.kernel.org, lkp@01.org Subject: Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage Message-ID: <20170407152304.bkbceqmg3kxeqvur@hirez.programming.kicks-ass.net> References: <87a881v52o.fsf@xmission.com> <20170403093152.GB15168@quack2.suse.cz> <20170406173306.GD10363@amd> <20170407044334.GA487@jagdpanzerIV.localdomain> <20170407071558.GA11792@amd> <20170407074634.GB1091@jagdpanzerIV.localdomain> <20170407081449.GA12859@amd> <20170407121021.GA379@jagdpanzerIV.localdomain> <20170407124455.GC4756@amd> <20170407151306.GA384@tigerII.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170407151306.GA384@tigerII.localdomain> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 08, 2017 at 12:13:06AM +0900, Sergey Senozhatsky wrote: > On (04/07/17 14:44), Pavel Machek wrote: > [..] > > > [..] > > > > I believe "spend at most 2 seconds in printk(), then print a warning > > > > and offload" is a solution closer to what we had before. > > > > > > a warning here can be very noisy. > > > > Well, on normally-configured it should be ok. We don't commonly see > > printk problems... If it is too noisy, perhaps we should increase from > > 2 seconds, but I don't think it will be problem. > > we are looking at different typical setups :) serial console being 45 > seconds behind logbuf does not surprise me anymore. That does sound like you're doing something wrong and should look at reducing printk() more than anything else. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============7359738010843680863==" MIME-Version: 1.0 From: Peter Zijlstra To: lkp@lists.01.org Subject: Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage Date: Fri, 07 Apr 2017 17:23:04 +0200 Message-ID: <20170407152304.bkbceqmg3kxeqvur@hirez.programming.kicks-ass.net> In-Reply-To: <20170407151306.GA384@tigerII.localdomain> List-Id: --===============7359738010843680863== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Sat, Apr 08, 2017 at 12:13:06AM +0900, Sergey Senozhatsky wrote: > On (04/07/17 14:44), Pavel Machek wrote: > [..] > > > [..] > > > > I believe "spend at most 2 seconds in printk(), then print a warning > > > > and offload" is a solution closer to what we had before. > > > = > > > a warning here can be very noisy. > > = > > Well, on normally-configured it should be ok. We don't commonly see > > printk problems... If it is too noisy, perhaps we should increase from > > 2 seconds, but I don't think it will be problem. > = > we are looking at different typical setups :) serial console being 45 > seconds behind logbuf does not surprise me anymore. That does sound like you're doing something wrong and should look at reducing printk() more than anything else. --===============7359738010843680863==--