From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932939AbdDGPX7 (ORCPT ); Fri, 7 Apr 2017 11:23:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57966 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753917AbdDGPXx (ORCPT ); Fri, 7 Apr 2017 11:23:53 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A1528EEF3D Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=acme@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com A1528EEF3D Date: Fri, 7 Apr 2017 12:23:41 -0300 From: Arnaldo Carvalho de Melo To: Christian Borntraeger Cc: linux-kernel@vger.kernel.org, Hendrik Brueckner , Andreas Krebbel , Peter Zijlstra , Ingo Molnar , linux-s390 , Martin Schwidefsky Subject: Re: [PATCH 1/2] s390/perf: fix perf annotate error -95 (4.10 regression) Message-ID: <20170407152341.GB2388@redhat.com> References: <1491465112-45819-1-git-send-email-borntraeger@de.ibm.com> <1491465112-45819-2-git-send-email-borntraeger@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1491465112-45819-2-git-send-email-borntraeger@de.ibm.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 07 Apr 2017 15:23:52 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Apr 06, 2017 at 09:51:51AM +0200, Christian Borntraeger escreveu: > since 4.10 perf annotate exits on s390 with an "unknown error -95". > Turns out that commit 786c1b51844d ("perf annotate: Start supporting > cross arch annotation") added a hard requirement for architecture Argh, that was unfortunate, I'll apply your patches and try to remove that restriction, using the defaults previously in place :-\ thanks, - Arnaldo > support when objdump is used but only provided x86 and arm > support. Meanwhile power was added so lets add s390 as well. > > While at it make sure to implement the branch and jump types. > > Signed-off-by: Christian Borntraeger > Fixes: 786c1b51844 "perf annotate: Start supporting cross arch annotation" > Cc: Arnaldo Carvalho de Melo > --- > tools/perf/util/annotate.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c > index 273f21f..7aa5722 100644 > --- a/tools/perf/util/annotate.c > +++ b/tools/perf/util/annotate.c > @@ -130,6 +130,12 @@ static struct arch architectures[] = { > .name = "powerpc", > .init = powerpc__annotate_init, > }, > + { > + .name = "s390", > + .objdump = { > + .comment_char = '#', > + }, > + }, > }; > > static void ins__delete(struct ins_operands *ops) > -- > 2.7.4