All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arushi Singhal <arushisinghal19971997@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/4] iptables: iptables: Add blank line after declaration
Date: Fri, 7 Apr 2017 18:12:19 +0200	[thread overview]
Message-ID: <20170407161219.GA9327@salvia> (raw)
In-Reply-To: <20170331161351.26141-2-arushisinghal19971997@gmail.com>

On Fri, Mar 31, 2017 at 09:43:48PM +0530, Arushi Singhal wrote:
> Add blank line after the declaration of variable to follow kernel coding
> style.
> 
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
>  iptables/getethertype.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/iptables/getethertype.c b/iptables/getethertype.c
> index 027ef4a..bf3e408 100644
> --- a/iptables/getethertype.c
> +++ b/iptables/getethertype.c
> @@ -75,6 +75,7 @@ struct ethertypeent *getethertypeent(void)
>  {
>  	char *e;
>  	char *endptr;
> +
>  	register char *cp, **q;

I don't see any need for this new empty line.

  reply	other threads:[~2017-04-07 16:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-31 16:13 [PATCH 0/4] Multiple checkpatch issues Arushi Singhal
2017-03-31 16:13 ` [PATCH 1/4] iptables: iptables: Add blank line after declaration Arushi Singhal
2017-04-07 16:12   ` Pablo Neira Ayuso [this message]
2017-03-31 16:13 ` [PATCH 2/4] iptables: iptables: Remove assignment in if condition Arushi Singhal
2017-03-31 16:13 ` [PATCH 3/4] iptables: iptables: Indent the code Arushi Singhal
2017-03-31 16:13 ` [PATCH 4/4] iptables: iptables: switch and case should be at the same indent Arushi Singhal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170407161219.GA9327@salvia \
    --to=pablo@netfilter.org \
    --cc=arushisinghal19971997@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.