From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932787AbdDGSem (ORCPT ); Fri, 7 Apr 2017 14:34:42 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34086 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751383AbdDGSee (ORCPT ); Fri, 7 Apr 2017 14:34:34 -0400 Date: Fri, 7 Apr 2017 20:34:30 +0200 From: Daniel Vetter To: jeffy Cc: linux-kernel@vger.kernel.org, briannorris@chromium.org, dianders@chromium.org, tfiga@chromium.org, dri-devel@lists.freedesktop.org, zyw@rock-chips.com, Daniel Vetter Subject: Re: [PATCH v5 12/12] drm/drm_ioctl.c: Break ioctl when drm device not registered Message-ID: <20170407183429.pcojsp63nlsaljdc@phenom.ffwll.local> Mail-Followup-To: jeffy , linux-kernel@vger.kernel.org, briannorris@chromium.org, dianders@chromium.org, tfiga@chromium.org, dri-devel@lists.freedesktop.org, zyw@rock-chips.com, Daniel Vetter References: <1491481885-13775-1-git-send-email-jeffy.chen@rock-chips.com> <1491481885-13775-13-git-send-email-jeffy.chen@rock-chips.com> <20170407071659.hwf5f7jf2bjjdata@phenom.ffwll.local> <58E75AEB.6070700@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <58E75AEB.6070700@rock-chips.com> X-Operating-System: Linux phenom 4.9.0-2-amd64 User-Agent: NeoMutt/20170306 (1.8.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 07, 2017 at 05:24:59PM +0800, jeffy wrote: > Hi Daniel, > > On 04/07/2017 03:16 PM, Daniel Vetter wrote: > > On Thu, Apr 06, 2017 at 08:31:25PM +0800, Jeffy Chen wrote: > > > After unbinding drm, the user space may still owns the drm dev fd, > > > and may still be able to call drm ioctl. > > > > > > Add a sanity check here to prevent that from happening. > > > > > > Signed-off-by: Jeffy Chen > > > --- > > > > > > Changes in v5: None > > > Changes in v4: None > > > Changes in v3: None > > > Changes in v2: None > > > > > > drivers/gpu/drm/drm_ioctl.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c > > > index 7d6deaa..15beb11 100644 > > > --- a/drivers/gpu/drm/drm_ioctl.c > > > +++ b/drivers/gpu/drm/drm_ioctl.c > > > @@ -674,7 +674,7 @@ long drm_ioctl(struct file *filp, > > > > > > dev = file_priv->minor->dev; > > > > > > - if (drm_device_is_unplugged(dev)) > > > + if (drm_device_is_unplugged(dev) || !dev->registered) > > > > Shouldn't we instead automatically unplug the device in > > drm_dev_unregister, instead of sprinkling tons of drm_device_is_unplugged > > || !registered all over the place? > > > it looks like the drm_unplug_dev would call drm_dev_unregister... > maybe we can: > 1/ replace the dev_unplug_dev in udl_drv.c to drm_dev_unregister > 2/ call dev_unplug_dev in drm_dev_unregister, and remove drm_dev_unregister > in dev_unplug_dev > 3/ add a drm_plug_dev or drm_device_set_plugged, and call it in > drm_dev_register Yeah, sounds like a reasonable plan. I didn't review the full implications of this because Fri evening :-) So pls double-check before you rewrite the world ... Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v5 12/12] drm/drm_ioctl.c: Break ioctl when drm device not registered Date: Fri, 7 Apr 2017 20:34:30 +0200 Message-ID: <20170407183429.pcojsp63nlsaljdc@phenom.ffwll.local> References: <1491481885-13775-1-git-send-email-jeffy.chen@rock-chips.com> <1491481885-13775-13-git-send-email-jeffy.chen@rock-chips.com> <20170407071659.hwf5f7jf2bjjdata@phenom.ffwll.local> <58E75AEB.6070700@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1E74B6E242 for ; Fri, 7 Apr 2017 18:34:34 +0000 (UTC) Received: by mail-wm0-x241.google.com with SMTP id o81so2720322wmb.0 for ; Fri, 07 Apr 2017 11:34:34 -0700 (PDT) Content-Disposition: inline In-Reply-To: <58E75AEB.6070700@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: jeffy Cc: dianders@chromium.org, briannorris@chromium.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tfiga@chromium.org, zyw@rock-chips.com, Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBBcHIgMDcsIDIwMTcgYXQgMDU6MjQ6NTlQTSArMDgwMCwgamVmZnkgd3JvdGU6Cj4g SGkgRGFuaWVsLAo+IAo+IE9uIDA0LzA3LzIwMTcgMDM6MTYgUE0sIERhbmllbCBWZXR0ZXIgd3Jv dGU6Cj4gPiBPbiBUaHUsIEFwciAwNiwgMjAxNyBhdCAwODozMToyNVBNICswODAwLCBKZWZmeSBD aGVuIHdyb3RlOgo+ID4gPiBBZnRlciB1bmJpbmRpbmcgZHJtLCB0aGUgdXNlciBzcGFjZSBtYXkg c3RpbGwgb3ducyB0aGUgZHJtIGRldiBmZCwKPiA+ID4gYW5kIG1heSBzdGlsbCBiZSBhYmxlIHRv IGNhbGwgZHJtIGlvY3RsLgo+ID4gPiAKPiA+ID4gQWRkIGEgc2FuaXR5IGNoZWNrIGhlcmUgdG8g cHJldmVudCB0aGF0IGZyb20gaGFwcGVuaW5nLgo+ID4gPiAKPiA+ID4gU2lnbmVkLW9mZi1ieTog SmVmZnkgQ2hlbiA8amVmZnkuY2hlbkByb2NrLWNoaXBzLmNvbT4KPiA+ID4gLS0tCj4gPiA+IAo+ ID4gPiBDaGFuZ2VzIGluIHY1OiBOb25lCj4gPiA+IENoYW5nZXMgaW4gdjQ6IE5vbmUKPiA+ID4g Q2hhbmdlcyBpbiB2MzogTm9uZQo+ID4gPiBDaGFuZ2VzIGluIHYyOiBOb25lCj4gPiA+IAo+ID4g PiAgIGRyaXZlcnMvZ3B1L2RybS9kcm1faW9jdGwuYyB8IDIgKy0KPiA+ID4gICAxIGZpbGUgY2hh bmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKPiA+ID4gCj4gPiA+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2lvY3RsLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2lv Y3RsLmMKPiA+ID4gaW5kZXggN2Q2ZGVhYS4uMTViZWIxMSAxMDA2NDQKPiA+ID4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2RybV9pb2N0bC5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1f aW9jdGwuYwo+ID4gPiBAQCAtNjc0LDcgKzY3NCw3IEBAIGxvbmcgZHJtX2lvY3RsKHN0cnVjdCBm aWxlICpmaWxwLAo+ID4gPiAKPiA+ID4gICAJZGV2ID0gZmlsZV9wcml2LT5taW5vci0+ZGV2Owo+ ID4gPiAKPiA+ID4gLQlpZiAoZHJtX2RldmljZV9pc191bnBsdWdnZWQoZGV2KSkKPiA+ID4gKwlp ZiAoZHJtX2RldmljZV9pc191bnBsdWdnZWQoZGV2KSB8fCAhZGV2LT5yZWdpc3RlcmVkKQo+ID4g Cj4gPiBTaG91bGRuJ3Qgd2UgaW5zdGVhZCBhdXRvbWF0aWNhbGx5IHVucGx1ZyB0aGUgZGV2aWNl IGluCj4gPiBkcm1fZGV2X3VucmVnaXN0ZXIsIGluc3RlYWQgb2Ygc3ByaW5rbGluZyB0b25zIG9m IGRybV9kZXZpY2VfaXNfdW5wbHVnZ2VkCj4gPiB8fCAhcmVnaXN0ZXJlZCBhbGwgb3ZlciB0aGUg cGxhY2U/Cj4gPiAKPiBpdCBsb29rcyBsaWtlIHRoZSBkcm1fdW5wbHVnX2RldiB3b3VsZCBjYWxs IGRybV9kZXZfdW5yZWdpc3Rlci4uLgo+IG1heWJlIHdlIGNhbjoKPiAxLyByZXBsYWNlIHRoZSBk ZXZfdW5wbHVnX2RldiBpbiB1ZGxfZHJ2LmMgdG8gZHJtX2Rldl91bnJlZ2lzdGVyCj4gMi8gY2Fs bCBkZXZfdW5wbHVnX2RldiBpbiBkcm1fZGV2X3VucmVnaXN0ZXIsIGFuZCByZW1vdmUgZHJtX2Rl dl91bnJlZ2lzdGVyCj4gaW4gZGV2X3VucGx1Z19kZXYKPiAzLyBhZGQgYSBkcm1fcGx1Z19kZXYg b3IgZHJtX2RldmljZV9zZXRfcGx1Z2dlZCwgYW5kIGNhbGwgaXQgaW4KPiBkcm1fZGV2X3JlZ2lz dGVyCgpZZWFoLCBzb3VuZHMgbGlrZSBhIHJlYXNvbmFibGUgcGxhbi4gSSBkaWRuJ3QgcmV2aWV3 IHRoZSBmdWxsIGltcGxpY2F0aW9ucwpvZiB0aGlzIGJlY2F1c2UgRnJpIGV2ZW5pbmcgOi0pIFNv IHBscyBkb3VibGUtY2hlY2sgYmVmb3JlIHlvdSByZXdyaXRlIHRoZQp3b3JsZCAuLi4KCkNoZWVy cywgRGFuaWVsCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jw b3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwK