From: Stephen Boyd <sboyd@codeaurora.org>
To: Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: add clk_possible_parents debugfs file
Date: Fri, 7 Apr 2017 12:45:06 -0700 [thread overview]
Message-ID: <20170407194506.GF7065@codeaurora.org> (raw)
In-Reply-To: <1490102432-21314-1-git-send-email-pdeschrijver@nvidia.com>
On 03/21, Peter De Schrijver wrote:
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index f5f2bcd..2fa2fb8 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -2128,6 +2128,34 @@ static int clk_dump_open(struct inode *inode, struct file *file)
> .release = single_release,
> };
>
> +static int possible_parents_dump(struct seq_file *s, void *data)
> +{
> + struct clk_core *core;
> + int i;
> +
> + core = (struct clk_core *)s->private;
Useless cast from void.
> +
> + for (i = 0; i < core->num_parents - 1; i++)
> + seq_printf(s, "%s ", core->parent_names[i]);
I hope we don't have spaces in clk names! I don't think we do.
> +
> + seq_printf(s, "%s\n", core->parent_names[i]);
> +
> + return 0;
> +}
> +
> +static int possible_parents_open(struct inode *inode, struct file *file)
> +{
> + return single_open(file, possible_parents_dump, inode->i_private);
> +}
> +
> +
Double newline.
I fixed both when applying to clk-next.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-04-07 19:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 13:20 [PATCH] clk: add clk_possible_parents debugfs file Peter De Schrijver
2017-04-07 19:45 ` Stephen Boyd [this message]
2017-04-11 13:47 ` Peter De Schrijver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170407194506.GF7065@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pdeschrijver@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.