All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stafford Horne <shorne@gmail.com>
To: openrisc@lists.librecores.org
Subject: [OpenRISC] [PATCH v5 2/4] gdb: provide openrisc target description XML files.
Date: Sat, 8 Apr 2017 18:38:01 +0900	[thread overview]
Message-ID: <20170408093801.GD2194@lianli.shorne-pla.net> (raw)
In-Reply-To: <86mvbv6f1c.fsf@gmail.com>

On Tue, Apr 04, 2017 at 10:25:51PM +0100, Yao Qi wrote:
> Stafford Horne <shorne@gmail.com> writes:
> 
> > diff --git a/gdb/features/or1k.xml b/gdb/features/or1k.xml
> > new file mode 100644
> > index 0000000..688b340
> > --- /dev/null
> > +++ b/gdb/features/or1k.xml
> > @@ -0,0 +1,2274 @@
> > +<?xml version="1.0"?>
> > +<!-- Copyright (C) 2016 Free Software Foundation, Inc.
> > +
> > +     Copying and distribution of this file, with or without modification,
> > +     are permitted in any medium without royalty provided the copyright
> > +     notice and this notice are preserved.  -->
> > +
> > +<!DOCTYPE target SYSTEM "gdb-target.dtd">
> > +<target>
> > +  <architecture>or1k</architecture>
> > +  <feature name="org.gnu.gdb.or1k.group0">
> 
> 11 features are defined, but your patch 1/4 only checks feature group0.
> Does it indicate that only group0 is a required feature?  If so, we need
> to document it here,
> https://sourceware.org/gdb/current/onlinedocs/gdb/Standard-Target-Features.html
> 
> Of course, the debugging stub,like OpenOCD, can provide more features
> than GDB required.  In GDB, we need only to define required features.

I have removed these 11 features and just left the 1.  I think its
better that the targets provide all the extras.

Also, I documented it.  I will send the patches.

> -- 
> Yao (齐尧)

  reply	other threads:[~2017-04-08  9:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-17  5:43 [OpenRISC] [PATCH v5 0/4] OpenRISC gdb port Stafford Horne
2017-03-17  5:43 ` [OpenRISC] [PATCH v5 1/4] gdb: Add OpenRISC or1k and or1knd target support Stafford Horne
2017-03-17  8:48   ` Eli Zaretskii
2017-03-17  9:32     ` Stafford Horne
2017-03-17  9:35       ` Eli Zaretskii
2017-03-17 10:03         ` Stafford Horne
2017-04-04 21:17   ` Yao Qi
2017-04-08  9:36     ` Stafford Horne
2017-03-17  5:43 ` [OpenRISC] [PATCH v5 2/4] gdb: provide openrisc target description XML files Stafford Horne
2017-04-04 21:25   ` Yao Qi
2017-04-08  9:38     ` Stafford Horne [this message]
2017-03-17  5:43 ` [OpenRISC] [PATCH v5 3/4] gdb: testsuite: Add or1k l.nop inscruction Stafford Horne
2017-04-04 21:29   ` Yao Qi
2017-03-17  5:43 ` [OpenRISC] [PATCH v5 4/4] Add gdb for or1k build Stafford Horne
2017-04-04 21:32   ` Yao Qi
2017-03-21  9:14 ` [OpenRISC] [PATCH v5 0/4] OpenRISC gdb port Yao Qi
2017-03-21 14:17   ` Stafford Horne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170408093801.GD2194@lianli.shorne-pla.net \
    --to=shorne@gmail.com \
    --cc=openrisc@lists.librecores.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.