All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: kusumi.tomohiro@gmail.com
Cc: fio@vger.kernel.org, Tomohiro Kusumi <tkusumi@tuxera.com>
Subject: Re: [PATCH 1/8] Don't silently terminate td when no I/O performed due to error
Date: Sat, 8 Apr 2017 11:05:00 -0600	[thread overview]
Message-ID: <20170408170459.GB13541@kernel.dk> (raw)
In-Reply-To: <20170404202218.52260-1-tkusumi@tuxera.com>

On Tue, Apr 04 2017, kusumi.tomohiro@gmail.com wrote:
> From: Tomohiro Kusumi <tkusumi@tuxera.com>
> 
> Some runtime configurations can cause threads/processes to terminate
> without any I/O performed, yet with no explicit error message, which
> is quite confusing. In the example below, fio finishes with neither
> error nor regular statistics due to file offset + bs being larger
> than the file size while in get_io_u().
> 
> This commit calls log_err() when this happens. Since it's difficult
> to tell the exact reason after thread has left the main I/O loop[*],
> it gives advice to use a command line option --debug=io, similar to
> the way td_io_init() gives advice.
> 
> [*] It can't just replace dprint(FD_IO, ...) calls with td_verror()
> for e.g. while in get_io_u(), since those are also used by non error
> paths too.

Thanks, applied 1-2, and 4-7.

-- 
Jens Axboe



      parent reply	other threads:[~2017-04-08 17:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-04 20:22 kusumi.tomohiro
2017-04-04 20:22 ` [PATCH 2/8] dump_td_info() doesn't really need to be a function kusumi.tomohiro
2017-04-04 20:22 ` [PATCH 3/8] Add assert(0) to DDIR_DATASYNC sync path if fdatasync(2) is unsupported kusumi.tomohiro
2017-04-08 17:02   ` Jens Axboe
2017-04-04 20:22 ` [PATCH 4/8] Make lib/prio_tree.c a stand-alone library kusumi.tomohiro
2017-04-04 20:22 ` [PATCH 5/8] Make lib/memalign.c " kusumi.tomohiro
2017-04-04 20:22 ` [PATCH 6/8] Make lib/num2str.c a stand-alone library by adding lib/num2str.h kusumi.tomohiro
2017-04-04 20:22 ` [PATCH 7/8] Fix num2str() output when maxlen <= strlen(tmp) kusumi.tomohiro
2017-04-04 20:22 ` [PATCH 8/8] Fix num2str() output when modulo != -1U kusumi.tomohiro
2017-04-04 20:46   ` Elliott, Robert (Persistent Memory)
2017-04-08 17:05 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170408170459.GB13541@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=fio@vger.kernel.org \
    --cc=kusumi.tomohiro@gmail.com \
    --cc=tkusumi@tuxera.com \
    --subject='Re: [PATCH 1/8] Don'\''t silently terminate td when no I/O performed due to error' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.