All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Paul Menzel <pmenzel@molgen.mpg.de>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: `pci_apply_final_quirks()` taking half a second
Date: Sat, 8 Apr 2017 14:06:28 -0500	[thread overview]
Message-ID: <20170408190628.GB16832@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <1491670819.6021.33.camel@infradead.org>

On Sat, Apr 08, 2017 at 07:00:19PM +0200, David Woodhouse wrote:
> ...
> I note it's also reading PCI_CACHE_LINE_SIZE From config space for each
> device in pci_apply_final_quirks(). How long does that take?

I don't know, but it's pointless on modern PCIe systems where the
Cache Line Size has no effect.  It'd be really nice if somebody
cleaned that up and got rid of the read itself and the useless
messages.

Bjorn

  reply	other threads:[~2017-04-08 19:06 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-07 21:07 `pci_apply_final_quirks()` taking half a second Paul Menzel
2017-04-08 15:41 ` Bjorn Helgaas
2017-04-08 17:00   ` David Woodhouse
2017-04-08 19:06     ` Bjorn Helgaas [this message]
2017-05-03 18:42       ` Andy Shevchenko
2017-12-26 15:55   ` Paul Menzel
2017-12-28 21:27     ` Bjorn Helgaas
2017-12-28 21:27       ` Bjorn Helgaas
2017-12-29 16:14       ` Alan Stern
2017-12-29 16:14         ` Alan Stern
2017-12-29 16:14         ` Alan Stern
2017-12-31  7:18         ` Paul Menzel
2017-12-31  7:18           ` Paul Menzel
2017-12-31 21:16           ` Alan Stern
2017-12-31 21:16             ` Alan Stern
2017-12-31 21:16             ` Alan Stern
2018-01-01 10:21             ` Paul Menzel
2018-01-01 10:21               ` Paul Menzel
2018-01-01 15:47               ` Alan Stern
2018-01-01 15:47                 ` Alan Stern
2018-01-01 15:47                 ` Alan Stern
2018-06-24 16:49             ` `quirk_usb_handoff_ohci` takes over 73 ms (twice) on AMD system (was: `pci_apply_final_quirks()` taking half a second) Paul Menzel
2018-06-24 16:49               ` `pci_apply_final_quirks()` taking half a second Paul Menzel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170408190628.GB16832@bhelgaas-glaptop.roam.corp.google.com \
    --to=helgaas@kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=pmenzel@molgen.mpg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.