Re: [PATCH] drm/i915: Use drm_i915_private directly from debugfs

From: kbuild test robot <lkp@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, kbuild-all@01.org
Subject: Re: [PATCH] drm/i915: Use drm_i915_private directly from debugfs
Date: Sat, 8 Apr 2017 20:55:18 +0800	[thread overview]
Message-ID: <201704082014.Nqze8x5N%fengguang.wu@intel.com> (raw)
In-Reply-To: <20170407184837.26195-1-chris@chris-wilson.co.uk>

[-- Attachment #1: Type: text/plain, Size: 3916 bytes --]

Hi Chris,

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on v4.11-rc5 next-20170407]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-Use-drm_i915_private-directly-from-debugfs/20170408-185408
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-x073-201714 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   In file included from include/linux/fs.h:19:0,
                    from include/linux/debugfs.h:18,
                    from drivers/gpu//drm/i915/i915_debugfs.c:29:
   drivers/gpu//drm/i915/i915_debugfs.c: In function 'i915_guc_log_control_set':
>> drivers/gpu//drm/i915/i915_debugfs.c:2589:34: error: 'dev' undeclared (first use in this function)
     ret = mutex_lock_interruptible(&dev->struct_mutex);
                                     ^
   include/linux/mutex.h:165:72: note: in definition of macro 'mutex_lock_interruptible'
    #define mutex_lock_interruptible(lock) mutex_lock_interruptible_nested(lock, 0)
                                                                           ^~~~
   drivers/gpu//drm/i915/i915_debugfs.c:2589:34: note: each undeclared identifier is reported only once for each function it appears in
     ret = mutex_lock_interruptible(&dev->struct_mutex);
                                     ^
   include/linux/mutex.h:165:72: note: in definition of macro 'mutex_lock_interruptible'
    #define mutex_lock_interruptible(lock) mutex_lock_interruptible_nested(lock, 0)
                                                                           ^~~~

vim +/dev +2589 drivers/gpu//drm/i915/i915_debugfs.c

685534ef Sagar Arun Kamble 2016-10-12  2573  	if (!dev_priv->guc.log.vma)
685534ef Sagar Arun Kamble 2016-10-12  2574  		return -EINVAL;
685534ef Sagar Arun Kamble 2016-10-12  2575  
685534ef Sagar Arun Kamble 2016-10-12  2576  	*val = i915.guc_log_level;
685534ef Sagar Arun Kamble 2016-10-12  2577  
685534ef Sagar Arun Kamble 2016-10-12  2578  	return 0;
685534ef Sagar Arun Kamble 2016-10-12  2579  }
685534ef Sagar Arun Kamble 2016-10-12  2580  
685534ef Sagar Arun Kamble 2016-10-12  2581  static int i915_guc_log_control_set(void *data, u64 val)
685534ef Sagar Arun Kamble 2016-10-12  2582  {
82580d06 Chris Wilson      2017-04-07  2583  	struct drm_i915_private *dev_priv = data;
685534ef Sagar Arun Kamble 2016-10-12  2584  	int ret;
685534ef Sagar Arun Kamble 2016-10-12  2585  
685534ef Sagar Arun Kamble 2016-10-12  2586  	if (!dev_priv->guc.log.vma)
685534ef Sagar Arun Kamble 2016-10-12  2587  		return -EINVAL;
685534ef Sagar Arun Kamble 2016-10-12  2588  
685534ef Sagar Arun Kamble 2016-10-12 @2589  	ret = mutex_lock_interruptible(&dev->struct_mutex);
685534ef Sagar Arun Kamble 2016-10-12  2590  	if (ret)
685534ef Sagar Arun Kamble 2016-10-12  2591  		return ret;
685534ef Sagar Arun Kamble 2016-10-12  2592  
685534ef Sagar Arun Kamble 2016-10-12  2593  	intel_runtime_pm_get(dev_priv);
685534ef Sagar Arun Kamble 2016-10-12  2594  	ret = i915_guc_log_control(dev_priv, val);
685534ef Sagar Arun Kamble 2016-10-12  2595  	intel_runtime_pm_put(dev_priv);
685534ef Sagar Arun Kamble 2016-10-12  2596  
685534ef Sagar Arun Kamble 2016-10-12  2597  	mutex_unlock(&dev->struct_mutex);

:::::: The code at line 2589 was first introduced by commit
:::::: 685534ef4c8faff1f69c9962ad3013e17354ff8b drm/i915: Debugfs support for GuC logging control

:::::: TO: Sagar Arun Kamble <sagar.a.kamble@intel.com>
:::::: CC: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 25035 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx