From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: linux-sparse@vger.kernel.org
Cc: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Subject: [PATCH v2 3/6] add test case for linearize_initializer() of bitfields
Date: Sat, 8 Apr 2017 23:18:58 +0200 [thread overview]
Message-ID: <20170408211901.40507-4-luc.vanoostenryck@gmail.com> (raw)
In-Reply-To: <20170408211901.40507-1-luc.vanoostenryck@gmail.com>
In linearize_initializer(), 'ad->bit_size' & 'ad->bit_offset' were
never set, making the correct initialization impossible (a bit_size of
zero being especially bad, resulting in a mask of -1 instead of 0).
This is now fixed since 'bit_size' & 'bit_offset' are taken directly
from 'result_type'.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
validation/linear/bitfield-init-mask.c | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
create mode 100644 validation/linear/bitfield-init-mask.c
diff --git a/validation/linear/bitfield-init-mask.c b/validation/linear/bitfield-init-mask.c
new file mode 100644
index 000000000..94afa400c
--- /dev/null
+++ b/validation/linear/bitfield-init-mask.c
@@ -0,0 +1,27 @@
+struct bfu {
+ unsigned int a:11;
+ unsigned int f:9;
+ unsigned int z:3;
+};
+
+struct bfu bfu_init_00_11(int a)
+{
+ struct bfu bfu = { .a = a, };
+ return bfu;
+}
+
+struct bfu bfu_init_20_23(int a)
+{
+ struct bfu bfu = { .z = a, };
+ return bfu;
+}
+
+/*
+ * check-name: bitfield initializer mask
+ * check-command: test-linearize -fdump-linearize=only -Wno-decl $file
+ * check-output-ignore
+ *
+ * check-output-contains: and\\..*fffff800\$
+ * check-output-contains: shl\\..* \\$20
+ * check-output-contains: and\\..*ff8fffff\$
+ */
--
2.12.0
next prev parent reply other threads:[~2017-04-08 21:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-08 21:18 [PATCH v2 0/6] fix bitfield initializers Luc Van Oostenryck
2017-04-08 21:18 ` [PATCH v2 1/6] add support for a new flag: -fdump-linearize[=only] Luc Van Oostenryck
2017-04-08 21:18 ` [PATCH v2 2/6] remove bit_size & bit_offset from struct access_data Luc Van Oostenryck
2017-04-08 21:18 ` Luc Van Oostenryck [this message]
2017-04-08 21:18 ` [PATCH v2 4/6] fix implicit zero initializer Luc Van Oostenryck
2017-06-01 6:41 ` Christopher Li
2017-04-08 21:19 ` [PATCH v2 5/6] remove alignment from struct access_data Luc Van Oostenryck
2017-04-08 21:19 ` [PATCH v2 6/6] remove origval " Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170408211901.40507-4-luc.vanoostenryck@gmail.com \
--to=luc.vanoostenryck@gmail.com \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.