From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752610AbdDITOl (ORCPT ); Sun, 9 Apr 2017 15:14:41 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:43668 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752400AbdDITOe (ORCPT ); Sun, 9 Apr 2017 15:14:34 -0400 X-ME-Sender: X-Sasl-enc: l6BlNZtvMbZcM0JqfUakCRwAC7EYofKcCObXey94kUeX 1491765273 Date: Sun, 9 Apr 2017 21:02:03 +0200 From: Greg KH To: "Arthur Brainville (Ybalrid)" Cc: abbotti@mev.co.uk, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: comedidev.h comedi_lrange should be const struct Message-ID: <20170409190203.GA26797@kroah.com> References: <20170409142812.3356-1-ybalrid@ybalrid.info> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170409142812.3356-1-ybalrid@ybalrid.info> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 09, 2017 at 04:28:12PM +0200, Arthur Brainville (Ybalrid) wrote: > According to checkpatch.pl, comedi_lrange should be declared as `const > struct` instead of `struct` in driver/staging/comedidev.h > > Signed-off-by: Arthur Brainville (Ybalrid) > --- > drivers/staging/comedi/comedidev.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h > index 1bb9986f865e..82df090783b5 100644 > --- a/drivers/staging/comedi/comedidev.h > +++ b/drivers/staging/comedi/comedidev.h > @@ -623,7 +623,7 @@ extern const struct comedi_lrange range_unknown; > * There may also be a flag that indicates the minimum and maximum are merely > * scale factors for an unknown, external reference. > */ > -struct comedi_lrange { > +const struct comedi_lrange { > int length; > struct comedi_krange range[]; > }; Huh? Please explain how this change is correct. greg k-h