From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753141AbdDJHpN (ORCPT ); Mon, 10 Apr 2017 03:45:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44994 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752962AbdDJHpL (ORCPT ); Mon, 10 Apr 2017 03:45:11 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7B5A13B71E Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jolsa@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 7B5A13B71E Date: Mon, 10 Apr 2017 09:44:57 +0200 From: Jiri Olsa To: Jiada Wang Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, jolsa@kernel.org, wangnan0@huawei.com, ravi.bangoria@linux.vnet.ibm.com, mhiramat@kernel.org, linux-kernel@vger.kernel.org, erosca@de.adit-jv.com Subject: Re: [PATCH v3 1/1] perf tools: fix perf build with ARCH=x86_64 Message-ID: <20170410074457.GB25354@krava> References: <1491373544-14504-1-git-send-email-jiada_wang@mentor.com> <1491373544-14504-2-git-send-email-jiada_wang@mentor.com> <20170409172711.GA16588@krava> <58EAF143.7090509@mentor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <58EAF143.7090509@mentor.com> User-Agent: Mutt/1.8.0 (2017-02-23) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 10 Apr 2017 07:45:00 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 09, 2017 at 07:43:15PM -0700, Jiada Wang wrote: > Hello Jiri > > On 04/09/2017 10:27 AM, Jiri Olsa wrote: > > On Tue, Apr 04, 2017 at 11:25:44PM -0700, jiada_wang@mentor.com wrote: > > > From: Jiada Wang > > > > > > with commit: 0a943cb10ce78 (tools build: Add HOSTARCH Makefile variable) > > > the following build failure is seen when build with ARCH=x86_64 > > is that described somewhere as a valid building interface? > > I never use it so I have no idea.. would you describe your > > build env/process? > I used "ARCH=x86_64 make -C tools perf V=1" to build perf for x86_64 ARCH. you're on x86 machine right? I don't see CROSS_COMPILE being used.. what's the purpose of the ARCH var setup then? > > > > In file included from util/event.c:2:0: > > > tools/include/uapi/linux/mman.h:4:27: fatal error: uapi/asm/mman.h: No such file or directory > > > compilation terminated. > > > > > > fix this issue by use SRCARCH instead of ARCH in perf. > > please describe also the the issue itself in the changelog, not just the fix > I will update changelog with detail information about the issue in v4 > > > > > > so objtool is using SRCARCH this way, I guess it's fine > > > > if we go this way, you also need to change the pmu-events/Build > > and there's some comment using $(ARCH) in util/header.c > will update pmu-events/Build in v4 I'll check thanks, jirka