From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753529AbdDJOCN (ORCPT ); Mon, 10 Apr 2017 10:02:13 -0400 Received: from foss.arm.com ([217.140.101.70]:48312 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752518AbdDJOCL (ORCPT ); Mon, 10 Apr 2017 10:02:11 -0400 Date: Mon, 10 Apr 2017 15:02:14 +0100 From: Juri Lelli To: Russell King - ARM Linux Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, peterz@infradead.org, vincent.guittot@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, sudeep.holla@arm.com, lorenzo.pieralisi@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, morten.rasmussen@arm.com, dietmar.eggemann@arm.com, broonie@kernel.org, gregkh@linuxfoundation.org Subject: Re: [PATCH v3 6/9] drivers: remove useless comment from base/arch_topology.c Message-ID: <20170410140214.GE30804@e106622-lin> References: <20170327131825.32134-1-juri.lelli@arm.com> <20170327131825.32134-7-juri.lelli@arm.com> <20170410135103.GR17774@n2100.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170410135103.GR17774@n2100.armlinux.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 10/04/17 14:51, Russell King - ARM Linux wrote: > On Mon, Mar 27, 2017 at 02:18:22PM +0100, Juri Lelli wrote: > > Printing out an error message when we failed to get the cpu device is > > not helping anyone. Remove it. > > (1) the subject line talks about removing a "comment" but you're > actually removing an error printk > (2) I don't think it's "not helping anyone", although the description > above doesn't say _why_ - it's reporting the lack of a missing CPU > device that we expect to be present. If it's not present, then > we're not going to end up with the cpu capacity attribute, and the > error message answers the "why is that sysfs file missing" question. That's the same I was thinking when I put the error message there in the first place. But, then Greg didn't seem to like it. > > I think a better commit message is needed for this change. > We could just skip this patch entirely. Or, of course, I can easily update the commit message. Which way is to be preferred? Thanks, - Juri > > > > Signed-off-by: Juri Lelli > > --- > > drivers/base/arch_topology.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c > > index c33482121b7d..b24d9a2af2c5 100644 > > --- a/drivers/base/arch_topology.c > > +++ b/drivers/base/arch_topology.c > > @@ -81,11 +81,9 @@ static int register_cpu_capacity_sysctl(void) > > > > for_each_possible_cpu(i) { > > cpu = get_cpu_device(i); > > - if (!cpu) { > > - pr_err("%s: too early to get CPU%d device!\n", > > - __func__, i); > > + if (!cpu) > > continue; > > - } > > + > > device_create_file(cpu, &dev_attr_cpu_capacity); > > } > > > > -- > > 2.10.0 > > > > -- > RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ > FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up > according to speedtest.net. From mboxrd@z Thu Jan 1 00:00:00 1970 From: juri.lelli@arm.com (Juri Lelli) Date: Mon, 10 Apr 2017 15:02:14 +0100 Subject: [PATCH v3 6/9] drivers: remove useless comment from base/arch_topology.c In-Reply-To: <20170410135103.GR17774@n2100.armlinux.org.uk> References: <20170327131825.32134-1-juri.lelli@arm.com> <20170327131825.32134-7-juri.lelli@arm.com> <20170410135103.GR17774@n2100.armlinux.org.uk> Message-ID: <20170410140214.GE30804@e106622-lin> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On 10/04/17 14:51, Russell King - ARM Linux wrote: > On Mon, Mar 27, 2017 at 02:18:22PM +0100, Juri Lelli wrote: > > Printing out an error message when we failed to get the cpu device is > > not helping anyone. Remove it. > > (1) the subject line talks about removing a "comment" but you're > actually removing an error printk > (2) I don't think it's "not helping anyone", although the description > above doesn't say _why_ - it's reporting the lack of a missing CPU > device that we expect to be present. If it's not present, then > we're not going to end up with the cpu capacity attribute, and the > error message answers the "why is that sysfs file missing" question. That's the same I was thinking when I put the error message there in the first place. But, then Greg didn't seem to like it. > > I think a better commit message is needed for this change. > We could just skip this patch entirely. Or, of course, I can easily update the commit message. Which way is to be preferred? Thanks, - Juri > > > > Signed-off-by: Juri Lelli > > --- > > drivers/base/arch_topology.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c > > index c33482121b7d..b24d9a2af2c5 100644 > > --- a/drivers/base/arch_topology.c > > +++ b/drivers/base/arch_topology.c > > @@ -81,11 +81,9 @@ static int register_cpu_capacity_sysctl(void) > > > > for_each_possible_cpu(i) { > > cpu = get_cpu_device(i); > > - if (!cpu) { > > - pr_err("%s: too early to get CPU%d device!\n", > > - __func__, i); > > + if (!cpu) > > continue; > > - } > > + > > device_create_file(cpu, &dev_attr_cpu_capacity); > > } > > > > -- > > 2.10.0 > > > > -- > RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ > FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up > according to speedtest.net.