All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: netdev@vger.kernel.org, Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH net-next v3 1/2] bpf: remove struct bpf_prog_type_list
Date: Mon, 10 Apr 2017 07:56:47 -0700	[thread overview]
Message-ID: <20170410145645.GA41264@ast-mbp.thefacebook.com> (raw)
In-Reply-To: <20170410124431.4305-2-johannes@sipsolutions.net>

On Mon, Apr 10, 2017 at 02:44:30PM +0200, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
> 
> There's no need to have struct bpf_prog_type_list since
> it just contains a list_head, the type, and the ops
> pointer. Since the types are densely packed and not
> actually dynamically registered, it's much easier and
> smaller to have an array of type->ops pointer. Also
> initialize this array statically to remove code needed
> to initialize it.
> 
> In order to save duplicating the list, move it to a new
> header file and include it in the places needing it.
> 
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>

looks great. Excellent cleanup.

Acked-by: Alexei Starovoitov <ast@kernel.org>

  reply	other threads:[~2017-04-10 14:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-10 12:44 [PATCH net-next v3 0/2] bpf: prog/map type reductions Johannes Berg
2017-04-10 12:44 ` [PATCH net-next v3 1/2] bpf: remove struct bpf_prog_type_list Johannes Berg
2017-04-10 14:56   ` Alexei Starovoitov [this message]
2017-04-10 16:00   ` Daniel Borkmann
2017-04-10 12:44 ` [PATCH net-next v3 2/2] bpf: remove struct bpf_map_type_list Johannes Berg
2017-04-10 14:58   ` Alexei Starovoitov
2017-04-10 16:06   ` Daniel Borkmann
2017-04-11 13:29   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170410145645.GA41264@ast-mbp.thefacebook.com \
    --to=alexei.starovoitov@gmail.com \
    --cc=johannes.berg@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.