All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Juri Lelli <juri.lelli@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	peterz@infradead.org, vincent.guittot@linaro.org,
	robh+dt@kernel.org, mark.rutland@arm.com, sudeep.holla@arm.com,
	lorenzo.pieralisi@arm.com, catalin.marinas@arm.com,
	will.deacon@arm.com, morten.rasmussen@arm.com,
	dietmar.eggemann@arm.com, broonie@kernel.org,
	gregkh@linuxfoundation.org
Subject: Re: [PATCH v3 6/9] drivers: remove useless comment from base/arch_topology.c
Date: Mon, 10 Apr 2017 17:33:25 +0100	[thread overview]
Message-ID: <20170410163325.GU17774@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20170410140214.GE30804@e106622-lin>

On Mon, Apr 10, 2017 at 03:02:14PM +0100, Juri Lelli wrote:
> Hi,
> 
> On 10/04/17 14:51, Russell King - ARM Linux wrote:
> > On Mon, Mar 27, 2017 at 02:18:22PM +0100, Juri Lelli wrote:
> > > Printing out an error message when we failed to get the cpu device is
> > > not helping anyone. Remove it.
> > 
> > (1) the subject line talks about removing a "comment" but you're
> >     actually removing an error printk
> > (2) I don't think it's "not helping anyone", although the description
> >     above doesn't say _why_ - it's reporting the lack of a missing CPU
> >     device that we expect to be present.  If it's not present, then
> >     we're not going to end up with the cpu capacity attribute, and the
> >     error message answers the "why is that sysfs file missing" question.
> 
> That's the same I was thinking when I put the error message there in the
> first place. But, then Greg didn't seem to like it.

I don't think it was a case of "not liking it" - Greg asked what use it
was.  Greg also pointed out the race with userspace.

I think dropping this patch is the quickest way to move forward.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

WARNING: multiple messages have this Message-ID (diff)
From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 6/9] drivers: remove useless comment from base/arch_topology.c
Date: Mon, 10 Apr 2017 17:33:25 +0100	[thread overview]
Message-ID: <20170410163325.GU17774@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20170410140214.GE30804@e106622-lin>

On Mon, Apr 10, 2017 at 03:02:14PM +0100, Juri Lelli wrote:
> Hi,
> 
> On 10/04/17 14:51, Russell King - ARM Linux wrote:
> > On Mon, Mar 27, 2017 at 02:18:22PM +0100, Juri Lelli wrote:
> > > Printing out an error message when we failed to get the cpu device is
> > > not helping anyone. Remove it.
> > 
> > (1) the subject line talks about removing a "comment" but you're
> >     actually removing an error printk
> > (2) I don't think it's "not helping anyone", although the description
> >     above doesn't say _why_ - it's reporting the lack of a missing CPU
> >     device that we expect to be present.  If it's not present, then
> >     we're not going to end up with the cpu capacity attribute, and the
> >     error message answers the "why is that sysfs file missing" question.
> 
> That's the same I was thinking when I put the error message there in the
> first place. But, then Greg didn't seem to like it.

I don't think it was a case of "not liking it" - Greg asked what use it
was.  Greg also pointed out the race with userspace.

I think dropping this patch is the quickest way to move forward.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

  reply	other threads:[~2017-04-10 16:33 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-27 13:18 [PATCH v3 0/9] Fix issues and factorize arm/arm64 capacity information code Juri Lelli
2017-03-27 13:18 ` Juri Lelli
2017-03-27 13:18 ` Juri Lelli
2017-03-27 13:18 ` [PATCH v3 1/9] Documentation: arm: fix wrong reference number in DT definition Juri Lelli
2017-03-27 13:18   ` Juri Lelli
2017-03-27 13:18   ` Juri Lelli
2017-03-27 13:18 ` [PATCH v3 2/9] Documentation/ABI: add information about cpu_capacity Juri Lelli
2017-03-27 13:18   ` Juri Lelli
2017-03-27 13:18 ` [PATCH v3 3/9] arm: fix return value of parse_cpu_capacity Juri Lelli
2017-03-27 13:18   ` Juri Lelli
2017-03-27 13:18   ` Juri Lelli
2017-03-29  7:37   ` Vincent Guittot
2017-03-29  7:37     ` Vincent Guittot
2017-03-29  8:06     ` Juri Lelli
2017-03-29  8:06       ` Juri Lelli
2017-03-29  8:06       ` Juri Lelli
2017-03-27 13:18 ` [PATCH v3 4/9] arm: remove wrong CONFIG_PROC_SYSCTL ifdef Juri Lelli
2017-03-27 13:18   ` Juri Lelli
2017-03-27 13:18   ` Juri Lelli
2017-03-29  7:39   ` Vincent Guittot
2017-03-29  7:39     ` Vincent Guittot
2017-03-29  7:39     ` Vincent Guittot
2017-03-27 13:18 ` [PATCH v3 5/9] arm, arm64: factorize common cpu capacity default code Juri Lelli
2017-03-27 13:18   ` Juri Lelli
2017-03-27 13:18   ` Juri Lelli
2017-04-08 16:25   ` Greg KH
2017-04-08 16:25     ` Greg KH
2017-04-08 16:25     ` Greg KH
2017-04-10  8:18   ` Catalin Marinas
2017-04-10  8:18     ` Catalin Marinas
2017-04-10 16:23     ` Juri Lelli
2017-04-10 16:23       ` Juri Lelli
2017-04-10 16:23       ` Juri Lelli
2017-03-27 13:18 ` [PATCH v3 6/9] drivers: remove useless comment from base/arch_topology.c Juri Lelli
2017-03-27 13:18   ` Juri Lelli
2017-03-27 13:18   ` Juri Lelli
2017-04-10 13:51   ` Russell King - ARM Linux
2017-04-10 13:51     ` Russell King - ARM Linux
2017-04-10 14:02     ` Juri Lelli
2017-04-10 14:02       ` Juri Lelli
2017-04-10 16:33       ` Russell King - ARM Linux [this message]
2017-04-10 16:33         ` Russell King - ARM Linux
2017-04-11 10:43         ` Juri Lelli
2017-04-11 10:43           ` Juri Lelli
2017-04-11 10:43           ` Juri Lelli
2017-03-27 13:18 ` [PATCH v3 7/9] arm,arm64,drivers: reduce scope of cap_parsing_failed Juri Lelli
2017-03-27 13:18   ` Juri Lelli
2017-03-27 13:18   ` Juri Lelli
2017-04-10  8:31   ` Catalin Marinas
2017-04-10  8:31     ` Catalin Marinas
2017-03-27 13:18 ` [PATCH v3 8/9] arm,arm64,drivers: move externs in a new header file Juri Lelli
2017-03-27 13:18   ` Juri Lelli
2017-03-27 13:18   ` Juri Lelli
2017-04-10  8:31   ` Catalin Marinas
2017-04-10  8:31     ` Catalin Marinas
2017-04-10  8:31     ` Catalin Marinas
2017-03-27 13:18 ` [PATCH v3 9/9] arm,arm64,drivers: add a prefix to drivers arch_topology interfaces Juri Lelli
2017-03-27 13:18   ` [PATCH v3 9/9] arm, arm64, drivers: " Juri Lelli
2017-04-10  8:32   ` Catalin Marinas
2017-04-10  8:32     ` Catalin Marinas
2017-04-10  8:32     ` Catalin Marinas
2017-04-06 14:14 ` [PATCH v3 0/9] Fix issues and factorize arm/arm64 capacity information code Juri Lelli
2017-04-06 14:14   ` Juri Lelli
2017-04-06 14:14   ` Juri Lelli
2017-04-10 15:05 ` Russell King - ARM Linux
2017-04-10 15:05   ` Russell King - ARM Linux
2017-04-10 15:05   ` Russell King - ARM Linux
2017-04-10 16:21   ` Juri Lelli
2017-04-10 16:21     ` Juri Lelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170410163325.GU17774@n2100.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=juri.lelli@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=morten.rasmussen@arm.com \
    --cc=peterz@infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=vincent.guittot@linaro.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.