All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Kiper <daniel.kiper@oracle.com>
To: Petr Tesarik <ptesarik@suse.com>
Cc: jgross@suse.com, konrad.wilk@oracle.com,
	boris.ostrovsky@oracle.com, xen-devel@lists.xenproject.org,
	eric.devolder@oracle.com, dkiper@net-space.pl,
	andrew.cooper3@citrix.com, linux-kernel@vger.kernel.org
Subject: Re: [Xen-devel] [PATCH v2] xen, kdump: handle pv domain in paddr_vmcoreinfo_note()
Date: Mon, 10 Apr 2017 22:49:33 +0200	[thread overview]
Message-ID: <20170410204933.GZ4372@olila.local.net-space.pl> (raw)
In-Reply-To: <20170407111622.3dfe44fe@hananiah.suse.cz>

On Fri, Apr 07, 2017 at 11:16:22AM +0200, Petr Tesarik wrote:
> On Wed, 5 Apr 2017 13:13:00 +0200
> Petr Tesarik <ptesarik@suse.com> wrote:
>
> > On Tue, 4 Apr 2017 12:42:53 -0700 (PDT)
> > Daniel Kiper <daniel.kiper@oracle.com> wrote:
> >
> >[...]
> > > So, if Petr did relevant tests that is nice. However, then, IMO, this
> > > patch begs Petr Tested-by.
> >
> > Actually, I tested with this patch applied on top of kernel 4.4 (SLES
> > 12 SP2). It matches what traditional Xen had always done, so I am quite
> > confident it will work with a later kernel, but to give my Tested-by,
> > let me first re-run the test on master, hopefully until today EOB.
>
> It took me much longer than anticipated (I had some trouble setting up
> the host again), but I can confirm that the patch works as expected on

No problem. I know how it works.

> top of 4.11-rc5.

Great!

> Without the patch, makedumpfile in the crash kernel complains:
>
> /proc/vmcore doesn't contain vmcoreinfo.

Though, I would like to ask you to do crash tool tests too.
Could you do that?

> With the patch applied, dumping still fails later because of an
> unrelated bug in makedumpfile, but I was able to extract the kernel
> message buffer with "makedumpfile --dump-dmesg". This already confirms
> VMCOREINFO presence and usability.

Is it Xen specific issue or more generic one?

Daniel

WARNING: multiple messages have this Message-ID
From: Daniel Kiper <daniel.kiper@oracle.com>
To: Petr Tesarik <ptesarik@suse.com>
Cc: jgross@suse.com, andrew.cooper3@citrix.com,
	linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
	boris.ostrovsky@oracle.com, eric.devolder@oracle.com,
	dkiper@net-space.pl
Subject: Re: [PATCH v2] xen, kdump: handle pv domain in paddr_vmcoreinfo_note()
Date: Mon, 10 Apr 2017 22:49:33 +0200	[thread overview]
Message-ID: <20170410204933.GZ4372@olila.local.net-space.pl> (raw)
In-Reply-To: <20170407111622.3dfe44fe@hananiah.suse.cz>

On Fri, Apr 07, 2017 at 11:16:22AM +0200, Petr Tesarik wrote:
> On Wed, 5 Apr 2017 13:13:00 +0200
> Petr Tesarik <ptesarik@suse.com> wrote:
>
> > On Tue, 4 Apr 2017 12:42:53 -0700 (PDT)
> > Daniel Kiper <daniel.kiper@oracle.com> wrote:
> >
> >[...]
> > > So, if Petr did relevant tests that is nice. However, then, IMO, this
> > > patch begs Petr Tested-by.
> >
> > Actually, I tested with this patch applied on top of kernel 4.4 (SLES
> > 12 SP2). It matches what traditional Xen had always done, so I am quite
> > confident it will work with a later kernel, but to give my Tested-by,
> > let me first re-run the test on master, hopefully until today EOB.
>
> It took me much longer than anticipated (I had some trouble setting up
> the host again), but I can confirm that the patch works as expected on

No problem. I know how it works.

> top of 4.11-rc5.

Great!

> Without the patch, makedumpfile in the crash kernel complains:
>
> /proc/vmcore doesn't contain vmcoreinfo.

Though, I would like to ask you to do crash tool tests too.
Could you do that?

> With the patch applied, dumping still fails later because of an
> unrelated bug in makedumpfile, but I was able to extract the kernel
> message buffer with "makedumpfile --dump-dmesg". This already confirms
> VMCOREINFO presence and usability.

Is it Xen specific issue or more generic one?

Daniel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-04-10 20:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-04 19:42 Daniel Kiper
2017-04-05 11:13 ` Petr Tesarik
2017-04-07  9:16   ` Petr Tesarik
2017-04-07  9:16   ` [Xen-devel] " Petr Tesarik
2017-04-10 20:49     ` Daniel Kiper [this message]
2017-04-10 20:49       ` Daniel Kiper
2017-04-11 10:49       ` [Xen-devel] " Petr Tesarik
2017-04-11 10:49         ` Petr Tesarik
2017-04-05 11:13 ` Petr Tesarik
  -- strict thread matches above, loose matches on Subject: below --
2017-03-31 10:14 [PATCH v2] xen,kdump: " Juergen Gross
2017-04-03 12:42 ` [Xen-devel] [PATCH v2] xen, kdump: " Daniel Kiper
2017-04-04 11:55   ` Juergen Gross
2017-04-11 12:45   ` Juergen Gross
2017-04-11 13:00     ` Daniel Kiper
2017-04-11 14:59       ` Petr Tesarik
2017-04-11 17:20         ` Daniel Kiper
2017-04-14 16:53           ` Petr Tesarik
2017-04-14 22:26             ` Daniel Kiper
2017-04-15 14:35               ` Petr Tesarik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170410204933.GZ4372@olila.local.net-space.pl \
    --to=daniel.kiper@oracle.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=dkiper@net-space.pl \
    --cc=eric.devolder@oracle.com \
    --cc=jgross@suse.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ptesarik@suse.com \
    --cc=xen-devel@lists.xenproject.org \
    --subject='Re: [Xen-devel] [PATCH v2] xen, kdump: handle pv domain in paddr_vmcoreinfo_note()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.