From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752114AbdDJUv0 (ORCPT ); Mon, 10 Apr 2017 16:51:26 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:47068 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751237AbdDJUvY (ORCPT ); Mon, 10 Apr 2017 16:51:24 -0400 Date: Mon, 10 Apr 2017 22:49:33 +0200 From: Daniel Kiper To: Petr Tesarik Cc: jgross@suse.com, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com, xen-devel@lists.xenproject.org, eric.devolder@oracle.com, dkiper@net-space.pl, andrew.cooper3@citrix.com, linux-kernel@vger.kernel.org Subject: Re: [Xen-devel] [PATCH v2] xen, kdump: handle pv domain in paddr_vmcoreinfo_note() Message-ID: <20170410204933.GZ4372@olila.local.net-space.pl> References: <0106a5b2-7c66-41bd-9a43-42974242b3af@default> <20170405131300.6a92fd6a@hananiah.suse.cz> <20170407111622.3dfe44fe@hananiah.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170407111622.3dfe44fe@hananiah.suse.cz> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 07, 2017 at 11:16:22AM +0200, Petr Tesarik wrote: > On Wed, 5 Apr 2017 13:13:00 +0200 > Petr Tesarik wrote: > > > On Tue, 4 Apr 2017 12:42:53 -0700 (PDT) > > Daniel Kiper wrote: > > > >[...] > > > So, if Petr did relevant tests that is nice. However, then, IMO, this > > > patch begs Petr Tested-by. > > > > Actually, I tested with this patch applied on top of kernel 4.4 (SLES > > 12 SP2). It matches what traditional Xen had always done, so I am quite > > confident it will work with a later kernel, but to give my Tested-by, > > let me first re-run the test on master, hopefully until today EOB. > > It took me much longer than anticipated (I had some trouble setting up > the host again), but I can confirm that the patch works as expected on No problem. I know how it works. > top of 4.11-rc5. Great! > Without the patch, makedumpfile in the crash kernel complains: > > /proc/vmcore doesn't contain vmcoreinfo. Though, I would like to ask you to do crash tool tests too. Could you do that? > With the patch applied, dumping still fails later because of an > unrelated bug in makedumpfile, but I was able to extract the kernel > message buffer with "makedumpfile --dump-dmesg". This already confirms > VMCOREINFO presence and usability. Is it Xen specific issue or more generic one? Daniel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Kiper Subject: Re: [PATCH v2] xen, kdump: handle pv domain in paddr_vmcoreinfo_note() Date: Mon, 10 Apr 2017 22:49:33 +0200 Message-ID: <20170410204933.GZ4372@olila.local.net-space.pl> References: <0106a5b2-7c66-41bd-9a43-42974242b3af@default> <20170405131300.6a92fd6a@hananiah.suse.cz> <20170407111622.3dfe44fe@hananiah.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cxgG0-000177-1C for xen-devel@lists.xenproject.org; Mon, 10 Apr 2017 20:49:52 +0000 Content-Disposition: inline In-Reply-To: <20170407111622.3dfe44fe@hananiah.suse.cz> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Petr Tesarik Cc: jgross@suse.com, andrew.cooper3@citrix.com, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, eric.devolder@oracle.com, dkiper@net-space.pl List-Id: xen-devel@lists.xenproject.org T24gRnJpLCBBcHIgMDcsIDIwMTcgYXQgMTE6MTY6MjJBTSArMDIwMCwgUGV0ciBUZXNhcmlrIHdy b3RlOgo+IE9uIFdlZCwgNSBBcHIgMjAxNyAxMzoxMzowMCArMDIwMAo+IFBldHIgVGVzYXJpayA8 cHRlc2FyaWtAc3VzZS5jb20+IHdyb3RlOgo+Cj4gPiBPbiBUdWUsIDQgQXByIDIwMTcgMTI6NDI6 NTMgLTA3MDAgKFBEVCkKPiA+IERhbmllbCBLaXBlciA8ZGFuaWVsLmtpcGVyQG9yYWNsZS5jb20+ IHdyb3RlOgo+ID4KPiA+Wy4uLl0KPiA+ID4gU28sIGlmIFBldHIgZGlkIHJlbGV2YW50IHRlc3Rz IHRoYXQgaXMgbmljZS4gSG93ZXZlciwgdGhlbiwgSU1PLCB0aGlzCj4gPiA+IHBhdGNoIGJlZ3Mg UGV0ciBUZXN0ZWQtYnkuCj4gPgo+ID4gQWN0dWFsbHksIEkgdGVzdGVkIHdpdGggdGhpcyBwYXRj aCBhcHBsaWVkIG9uIHRvcCBvZiBrZXJuZWwgNC40IChTTEVTCj4gPiAxMiBTUDIpLiBJdCBtYXRj aGVzIHdoYXQgdHJhZGl0aW9uYWwgWGVuIGhhZCBhbHdheXMgZG9uZSwgc28gSSBhbSBxdWl0ZQo+ ID4gY29uZmlkZW50IGl0IHdpbGwgd29yayB3aXRoIGEgbGF0ZXIga2VybmVsLCBidXQgdG8gZ2l2 ZSBteSBUZXN0ZWQtYnksCj4gPiBsZXQgbWUgZmlyc3QgcmUtcnVuIHRoZSB0ZXN0IG9uIG1hc3Rl ciwgaG9wZWZ1bGx5IHVudGlsIHRvZGF5IEVPQi4KPgo+IEl0IHRvb2sgbWUgbXVjaCBsb25nZXIg dGhhbiBhbnRpY2lwYXRlZCAoSSBoYWQgc29tZSB0cm91YmxlIHNldHRpbmcgdXAKPiB0aGUgaG9z dCBhZ2FpbiksIGJ1dCBJIGNhbiBjb25maXJtIHRoYXQgdGhlIHBhdGNoIHdvcmtzIGFzIGV4cGVj dGVkIG9uCgpObyBwcm9ibGVtLiBJIGtub3cgaG93IGl0IHdvcmtzLgoKPiB0b3Agb2YgNC4xMS1y YzUuCgpHcmVhdCEKCj4gV2l0aG91dCB0aGUgcGF0Y2gsIG1ha2VkdW1wZmlsZSBpbiB0aGUgY3Jh c2gga2VybmVsIGNvbXBsYWluczoKPgo+IC9wcm9jL3ZtY29yZSBkb2Vzbid0IGNvbnRhaW4gdm1j b3JlaW5mby4KClRob3VnaCwgSSB3b3VsZCBsaWtlIHRvIGFzayB5b3UgdG8gZG8gY3Jhc2ggdG9v bCB0ZXN0cyB0b28uCkNvdWxkIHlvdSBkbyB0aGF0PwoKPiBXaXRoIHRoZSBwYXRjaCBhcHBsaWVk LCBkdW1waW5nIHN0aWxsIGZhaWxzIGxhdGVyIGJlY2F1c2Ugb2YgYW4KPiB1bnJlbGF0ZWQgYnVn IGluIG1ha2VkdW1wZmlsZSwgYnV0IEkgd2FzIGFibGUgdG8gZXh0cmFjdCB0aGUga2VybmVsCj4g bWVzc2FnZSBidWZmZXIgd2l0aCAibWFrZWR1bXBmaWxlIC0tZHVtcC1kbWVzZyIuIFRoaXMgYWxy ZWFkeSBjb25maXJtcwo+IFZNQ09SRUlORk8gcHJlc2VuY2UgYW5kIHVzYWJpbGl0eS4KCklzIGl0 IFhlbiBzcGVjaWZpYyBpc3N1ZSBvciBtb3JlIGdlbmVyaWMgb25lPwoKRGFuaWVsCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGlu ZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4t ZGV2ZWwK