From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Gospodarek Subject: Re: [PATCH v2 net-next RFC] Generic XDP Date: Mon, 10 Apr 2017 17:30:25 -0400 Message-ID: <20170410213025.GC4730@C02RW35GFVH8.dhcp.broadcom.net> References: <20170409.133528.660876505013192371.davem@davemloft.net> <20170410183935.GB4730@C02RW35GFVH8.dhcp.broadcom.net> <20170410.152854.2025617543091711047.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, xdp-newbies@vger.kernel.org To: David Miller Return-path: Received: from mail-pg0-f48.google.com ([74.125.83.48]:35976 "EHLO mail-pg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752040AbdDJVaf (ORCPT ); Mon, 10 Apr 2017 17:30:35 -0400 Received: by mail-pg0-f48.google.com with SMTP id g2so110462496pge.3 for ; Mon, 10 Apr 2017 14:30:35 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20170410.152854.2025617543091711047.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Apr 10, 2017 at 03:28:54PM -0400, David Miller wrote: > From: Andy Gospodarek > Date: Mon, 10 Apr 2017 14:39:35 -0400 > > > As promised, I did some testing today with bnxt_en's implementation > > of XDP and this one. > > Thanks a lot Andy, obviously the patch needs some more work. > > I noticed GRO stuff in your profile, and Alexei mentioned this earlier > today. We probably should elide GRO if generic XDP is attached, since > in particular this makes the skb_linearize() really expensive. Good catch -- I actually thought we were disabling GRO automatically and it looks like we are not. :-/ I'll send Michael a patch. Disabling GRO allows me to process an additional 1Mpps, so I'm up to 7.5Mpps with this patch.