From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753623AbdDKGho (ORCPT ); Tue, 11 Apr 2017 02:37:44 -0400 Received: from mail-pf0-f178.google.com ([209.85.192.178]:33115 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753445AbdDKGhl (ORCPT ); Tue, 11 Apr 2017 02:37:41 -0400 Date: Tue, 11 Apr 2017 12:07:38 +0530 From: Viresh Kumar To: Leonard Crestez Cc: Lucas Stach , "Rafael J. Wysocki" , Sascha Hauer , Shawn Guo , Mark Brown , Robin Gong , Anson Huang , Irina Tirdea , Fabio Estevam , Octavian Purdila , Liam Girdwood , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/4] cpufreq: imx6q: Set max suspend_freq to avoid changes during suspend Message-ID: <20170411063738.GE3670@vireshk-i7> References: <5f61b819733127ddc7d41e82bf703a355c845b49.1491324640.git.leonard.crestez@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5f61b819733127ddc7d41e82bf703a355c845b49.1491324640.git.leonard.crestez@nxp.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04-04-17, 20:04, Leonard Crestez wrote: > If the cpufreq driver tries to modify voltage/freq during suspend/resume > it might need to control an external PMIC via I2C or SPI but those > devices might be already suspended. This issue is likely to happen > whenever the LDOs have their vin-supply set. > > To avoid this scenario we just increase cpufreq to the maximum before > suspend. > > Signed-off-by: Leonard Crestez > --- > drivers/cpufreq/imx6q-cpufreq.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) I have already Acked this earlier, why didn't you add it ? -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 From: viresh.kumar@linaro.org (Viresh Kumar) Date: Tue, 11 Apr 2017 12:07:38 +0530 Subject: [PATCH v2 2/4] cpufreq: imx6q: Set max suspend_freq to avoid changes during suspend In-Reply-To: <5f61b819733127ddc7d41e82bf703a355c845b49.1491324640.git.leonard.crestez@nxp.com> References: <5f61b819733127ddc7d41e82bf703a355c845b49.1491324640.git.leonard.crestez@nxp.com> Message-ID: <20170411063738.GE3670@vireshk-i7> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 04-04-17, 20:04, Leonard Crestez wrote: > If the cpufreq driver tries to modify voltage/freq during suspend/resume > it might need to control an external PMIC via I2C or SPI but those > devices might be already suspended. This issue is likely to happen > whenever the LDOs have their vin-supply set. > > To avoid this scenario we just increase cpufreq to the maximum before > suspend. > > Signed-off-by: Leonard Crestez > --- > drivers/cpufreq/imx6q-cpufreq.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) I have already Acked this earlier, why didn't you add it ? -- viresh